[pytest/ACL] fix acl cannot run on t1-64-lag#1648
Conversation
| # get the list of port to be combined to ACL tables | ||
| acl_table_ports += tor_ports | ||
| if testbed['topo']['name'] in ('t1', 't1-lag'): | ||
| acl_table_ports += tor_ports |
There was a problem hiding this comment.
Why not to bind ACL tables with ToR ports for rest of the supported topologies? The testing packets flow have two directions ToR -> Spine and Spine -> ToR.
If the ACL tables are not binded with the ToR ports, I suspect some of the testing will fail.
There was a problem hiding this comment.
because TOR port in t1-64-lag and t1-64-lag-clet is port-channel member, you cannot bind bound port-channel member in ACL table
There was a problem hiding this comment.
I see. But hard coding the topology name here is vulnerable if new topologies are introduced in the future. Maybe it is more robust to check if a ToR port is in a port channel. If yes, then skip it.
There was a problem hiding this comment.
Yes, it's more robust to check TOR port is a port channel to replace hard coding
There was a problem hiding this comment.
Do you like to make this improvement in this PR or in a separate one?
There was a problem hiding this comment.
I think separate is ok to me
- swss: * 459d09b 2021-02-22 | [acl] Enable VLAN ID qualifier for ACL rules (sonic-net#1648) (HEAD -> 202012) [Danny Allen] * 60859b1 2021-02-08 | [buffermgr] Support maximum port headroom checking (sonic-net#1607) [Stephen Sun] * 3161cbb 2021-02-17 | Add SAI_INGRESS_PRIORITY_GROUP_STAT_DROPPED_PACKETS counter, create new FlexCounter group (sonic-net#1600) [Andriy Yurkiv] * 256ed9c 2021-02-08 | Support shared headroom pool on top of dynamic buffer calculation (sonic-net#1581) [Stephen Sun] - utilities: * 30d7069 2021-02-16 | [decode-syseeprom] Refactor to utilize sonic-platform package (sonic-net#1435) (HEAD -> 202012, tag: foo) [Joe LeVeque] * 891fef4 2021-02-16 | [psuutil] Refactor to utilize sonic-platform package (sonic-net#1434) [Joe LeVeque] * 8c5e505 2021-02-17 | [sfputil] Refactor to utilize sonic-platform package (sonic-net#1421) [Joe LeVeque] * ca5dd2c 2021-02-17 | [sfpshow] Cleanup (sonic-net#1405) [Joe LeVeque] * bf489ea 2021-02-17 | Add new cli for SAI_INGRESS_PRIORITY_GROUP_STAT_DROPPED_PACKETS counter in counterpoll utility (sonic-net#1355) [Andriy Yurkiv] * 25feed3 2021-02-08 | Support shared headroom pool on top of dynamic buffer calculation (sonic-net#1348) [Stephen Sun] * aaa323a 2021-02-02 | [vrf]: Fix freezing during interface binding (sonic-net#1325) [maksymbelei95] * cc0bb6e 2021-01-27 | [show] fix "show interfaces breakout" command (sonic-net#1198) [Dmytro Shevchuk] Signed-off-by: Ying Xie <ying.xie@microsoft.com>
[201911][acl] Enable VLAN ID qualifier for ACL rules (sonic-net#1648) (sonic-net#1651) Skip setting not implemented brcm attr in buffer profile (sonic-net#1649)
Fix ACL failed on t1-64-lag
Summary: ACL cannot bound normal ports which belong to port-channel on t1-64-lag and dataplane cannot send packet by PTF container
Type of change
Approach
How did you do it?
How did you verify/test it?
run test on t1-64-lag show pass
Any platform specific information?
no
Supported testbed topology if it's a new test case?
t1-64-lag
Documentation