Add additional logging to script calculate_instance_number.py#16331
Merged
wangxin merged 2 commits intosonic-net:masterfrom Jan 6, 2025
Merged
Add additional logging to script calculate_instance_number.py#16331wangxin merged 2 commits intosonic-net:masterfrom
calculate_instance_number.py#16331wangxin merged 2 commits intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines failed to run 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
f5339e2 to
18dde23
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
18dde23 to
21de820
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
21de820 to
b13194e
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
calculate_instance_number.py
calculate_instance_number.pycalculate_instance_number.py
xwjiang-ms
reviewed
Jan 3, 2025
| parser.add_argument("--branch", help="Test branch", type=str, default="") | ||
| args = parser.parse_args() | ||
|
|
||
| logging.basicConfig(level=logging.INFO) |
Contributor
There was a problem hiding this comment.
suggest to add the basic config below the import
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
xwjiang-ms
approved these changes
Jan 3, 2025
wangxin
approved these changes
Jan 6, 2025
nnelluri-cisco
pushed a commit
to nnelluri-cisco/sonic-mgmt
that referenced
this pull request
Mar 15, 2025
…c-net#16331) What is the motivation for this PR? In this PR, we have added additional logging to the calculate_instance_number.py script to improve tracking and visibility of its operations. How did you do it? Add additional logging to the calculate_instance_number.py script. How did you verify/test it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
In this PR, we have added additional logging to the
calculate_instance_number.pyscript to improve tracking and visibility of its operations.Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
In this PR, we have added additional logging to the calculate_instance_number.py script to improve tracking and visibility of its operations.
How did you do it?
Add additional logging to the
calculate_instance_number.pyscript.How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation