[CRM] Replace fdbclear with swssconfig DEL#1578
[CRM] Replace fdbclear with swssconfig DEL#1578skshih wants to merge 3 commits intosonic-net:masterfrom skshih:PR0417
Conversation
The testing FDB record is added with swssconfig but removed with fdbclear. However with fdbclear the record is not removed from appDB after testing. It's better to remove fdb record with swssconfig DEL.
|
|
|
"However with fdbclear the record is not removed from appDB after testing.", why is this? is this a sonic bug, or test issue? |
| - set_fact: op="SET" | ||
|
|
||
| - name: Render FDB JSON config. | ||
| template: src=roles/test/templates/fdb_conf.j2 dest=/tmp/fdb_conf.json |
There was a problem hiding this comment.
you rename the file to fdb_json.j2 but here you use fdb_conf.j2, obviously, there is a mismatch of the name. Can you provide your test run results? We would expect you have run the test successfully before you submit the fix.
There was a problem hiding this comment.
Yes.. it's a typo. I'm sorry for that, will attach my test result later.
|
fdbclear removes FDB entry from ASIC and syncd notify fdborch to remove entry from stateDB. The record in appDB looks like user configuration. |
|
I think it's test issue, the fdbclear behavior just following the design document. |
FDB entry is binding to bridge port. Need to remove FDB entry first otherwise removing VLAN member will be failed.
This comment has been minimized.
This comment has been minimized.
|
i understand the issue here. i am discussing with the team what is the proper way to solve this issue. it looks like an image issue. |
|
@lguohan May I ask your opinion or plan about this issue after your discussion ? |
sonic-swss: bb69ca2 [portsorch] Avoid orchagent crash when set invalid interface types to port (sonic-net#1906) 6e1bacc [pfcwd] Fix the polling interval time granularity (sonic-net#1912) 564785b [teammgrd]: Improve LAGs cleanup on shutdown: send SIGTERM directly to PID. (sonic-net#1841) 7ee8d26 [tlm teamd] Add retry mechanism before logging the ERR in get_dumps. (sonic-net#1629) 7f57d3d [fgnhgorch] Enable packet flow when no FG ECMP neighbors are resolved (sonic-net#1900) 08d009f Mux state order change (sonic-net#1902) sonic-utilities: 1bc0f07 Provide support to install platform extensions (sonic-net#1578) 968c781 [config reload] Removed job-mode for sonic.target restart (sonic-net#1820)
Description of PR
During the fdb test, a testing FDB record is added with swssconfig but removed with fdbclear.
However with fdbclear the record is not removed from appDB after testing.
The remaining record in appDB may result in the next test case "warm-reboot" to fail
becauses orchagent restore failed and terminated after warm-reboot.
So I replace fdbclear command with swssconfig DEL.
Type of change
Approach
How did you do it?
Use j2 template to render FDB JSON config and apply with swssconfig.
How did you verify/test it?
Run the original test file "crm_test_fdb_entry.yml" first.
Check AppDB with redis-cli after testing , there is a record "FDB_TABLE:Vlan2:52-54-00-25-07-E9" left.
Apply the patch and run test file "crm_test_fdb_entry.yml" again.
Check AppDB with redis-cli after testing , the is no testing record left.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation