Fix REBOOT_TYPE_SUPERVISOR "check" value#15577
Merged
arlakshm merged 1 commit intosonic-net:masterfrom Nov 15, 2024
Merged
Conversation
* Correct REBOOT_TYPE_SUPERVISOR "check" regex value so it accurately detects supervisor cold reboot Signed-off-by: Javier Tan javiertan@microsoft.com
arlakshm
approved these changes
Nov 15, 2024
Contributor
|
@yejianquan, can you please approve this PR for 202405 |
Collaborator
|
@bingwang-ms could you help to approve cherry-pick? |
sreejithsreekumaran
pushed a commit
to sreejithsreekumaran/sonic-mgmt
that referenced
this pull request
Nov 15, 2024
sonic-net#15577) Description of PR Summary: Fixes sonic-net#15444 Approach What is the motivation for this PR? Bad regex in supervisor reboot check is causing unwarranted test failures How did you do it? Remove bad regex flags in supervisor reboot checks How did you verify/test it? Ran affected tests to ensure behaviour was correct Signed-off-by: Javier Tan javiertan@microsoft.com
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Nov 15, 2024
sonic-net#15577) Description of PR Summary: Fixes sonic-net#15444 Approach What is the motivation for this PR? Bad regex in supervisor reboot check is causing unwarranted test failures How did you do it? Remove bad regex flags in supervisor reboot checks How did you verify/test it? Ran affected tests to ensure behaviour was correct Signed-off-by: Javier Tan javiertan@microsoft.com
Collaborator
|
Cherry-pick PR to 202405: #15590 |
8 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Nov 15, 2024
#15577) Description of PR Summary: Fixes #15444 Approach What is the motivation for this PR? Bad regex in supervisor reboot check is causing unwarranted test failures How did you do it? Remove bad regex flags in supervisor reboot checks How did you verify/test it? Ran affected tests to ensure behaviour was correct Signed-off-by: Javier Tan javiertan@microsoft.com
yutongzhang-microsoft
pushed a commit
to yutongzhang-microsoft/sonic-mgmt
that referenced
this pull request
Nov 21, 2024
sonic-net#15577) Description of PR Summary: Fixes sonic-net#15444 Approach What is the motivation for this PR? Bad regex in supervisor reboot check is causing unwarranted test failures How did you do it? Remove bad regex flags in supervisor reboot checks How did you verify/test it? Ran affected tests to ensure behaviour was correct Signed-off-by: Javier Tan javiertan@microsoft.com
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes #15444
Type of change
Back port request
Approach
What is the motivation for this PR?
Bad regex in supervisor reboot check is causing unwarranted test failures
How did you do it?
Remove bad regex flags in supervisor reboot checks
How did you verify/test it?
Ran affected tests to ensure behaviour was correct
Any platform specific information?
N/A
Supported testbed topology if it's a new test case?
N/A
Documentation
N/A