Increase post-PDU state change delay to allow all PSUs to react#13793
Merged
kevinskwang merged 2 commits intosonic-net:masterfrom Jul 26, 2024
Merged
Increase post-PDU state change delay to allow all PSUs to react#13793kevinskwang merged 2 commits intosonic-net:masterfrom
kevinskwang merged 2 commits intosonic-net:masterfrom
Conversation
kevinskwang
requested changes
Jul 25, 2024
| for outlet in all_outlet_status: | ||
| if not outlet["outlet_on"]: | ||
| pdu_ctrl.turn_on_outlet(outlet) | ||
| time.sleep(5) |
Contributor
There was a problem hiding this comment.
Don't need to change here.
Contributor
Author
There was a problem hiding this comment.
It was adjusted in this PR since it was adjusted in the previous PR to increase the delay. I will remove this change though since it looks like it will not have any effect on test results.
kevinskwang
approved these changes
Jul 26, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jul 26, 2024
…c-net#13793) * Increase post-PDU state change delay to allow all PSUs to react * Revert delay increase for 'turn_all_outlets_on'
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jul 26, 2024
…c-net#13793) * Increase post-PDU state change delay to allow all PSUs to react * Revert delay increase for 'turn_all_outlets_on'
Collaborator
|
Cherry-pick PR to 202405: #13831 |
Collaborator
|
Cherry-pick PR to 202311: #13832 |
This was referenced Jul 26, 2024
mssonicbld
pushed a commit
that referenced
this pull request
Jul 26, 2024
* Increase post-PDU state change delay to allow all PSUs to react * Revert delay increase for 'turn_all_outlets_on'
mssonicbld
pushed a commit
that referenced
this pull request
Jul 26, 2024
* Increase post-PDU state change delay to allow all PSUs to react * Revert delay increase for 'turn_all_outlets_on'
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jul 31, 2024
…c-net#13793) * Increase post-PDU state change delay to allow all PSUs to react * Revert delay increase for 'turn_all_outlets_on'
Collaborator
|
Cherry-pick PR to 202305: #13892 |
8 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Jul 31, 2024
* Increase post-PDU state change delay to allow all PSUs to react * Revert delay increase for 'turn_all_outlets_on'
arista-hpandya
pushed a commit
to arista-hpandya/sonic-mgmt
that referenced
this pull request
Oct 2, 2024
…c-net#13793) * Increase post-PDU state change delay to allow all PSUs to react * Revert delay increase for 'turn_all_outlets_on'
vikshaw-Nokia
pushed a commit
to vikshaw-Nokia/sonic-mgmt
that referenced
this pull request
Oct 23, 2024
…c-net#13793) * Increase post-PDU state change delay to allow all PSUs to react * Revert delay increase for 'turn_all_outlets_on'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Increase delay between PDU state change and reading PSU details to 10 seconds (previously 5).
Type of change
Back port request
Approach
What is the motivation for this PR?
10 second delay between PDU state change and accessing PSU details is not always enough. The time needed depends on PDU hardware, psud update interval, and PSU hardware. Increasing to 20 seconds allows extra time for the PDU to apply a state change and PSU to reflect it, which MSFT has validated and found sufficient.
How did you do it?
Increase post-PDU state change delays to 20 seconds (previously 10 seconds). This is especially important anywhere the PDU state is changed to "on".
How did you verify/test it?
MSFT verified by setting the delay to 20 seconds since Cisco was unable to reproduce with our PDU hardware.