refactor: refactor bfd static route tests#13063
Merged
abdosi merged 2 commits intosonic-net:masterfrom Jun 7, 2024
Merged
Conversation
Contributor
Author
|
/azp run Azure.sonic-mgmt |
|
Commenter does not have sufficient privileges for PR 13063 in repo sonic-net/sonic-mgmt |
e3de118 to
302bf51
Compare
Contributor
|
This seems to be a huge change. Do you have chance to test on chassis testbed? |
Contributor
Author
Yes, I tested all test cases on a chassis testbed and can confirm they have passed |
cyw233
commented
Jun 5, 2024
| @@ -20,7 +22,7 @@ class TestBfdStaticRoute(BfdBase): | |||
| TOTAL_ITERATIONS = 100 | |||
Contributor
Author
There was a problem hiding this comment.
Currently we have 100 iterations for BFD flap test, which will take a long time (~4h) to complete. I will make the iteration number to be based on the completeness level in my next PR (Microsoft ADO 28301940)
abdosi
approved these changes
Jun 7, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jun 7, 2024
This is a follow-up PR for sonic-net#12995. This PR includes more code refactoring on bfd/test_bfd_static_route.py, such as parametrizing IPv4 and IPv6 for each test, moving static methods out of BfdBase class, removing unnecessary fixtures and etc.
Collaborator
|
Cherry-pick PR to 202405: #13183 |
8 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Jun 7, 2024
This is a follow-up PR for #12995. This PR includes more code refactoring on bfd/test_bfd_static_route.py, such as parametrizing IPv4 and IPv6 for each test, moving static methods out of BfdBase class, removing unnecessary fixtures and etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
This is a follow-up PR for #12995. This PR includes more code refactoring on
bfd/test_bfd_static_route.py, such as parametrizing IPv4 and IPv6 for each test, moving static methods out ofBfdBaseclass, removing unnecessary fixtures and etc.Summary:
Fixes # (issue) Microsoft ADO 27749982
Type of change
Back port request
Approach
What is the motivation for this PR?
To refactor the test cases in
bfd/test_bfd_static_route.pyto make it more readable and efficientHow did you do it?
How did you verify/test it?
I have run all test cases in this file in a T2 chassis device and can confirm they all passed.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation