Fix qos/test_qos_sai.py::TestQosSai::testQosSaiPfcXonLimit. #12868
Merged
bingwang-ms merged 1 commit intosonic-net:202311from May 17, 2024
Merged
Fix qos/test_qos_sai.py::TestQosSai::testQosSaiPfcXonLimit. #12868bingwang-ms merged 1 commit intosonic-net:202311from
bingwang-ms merged 1 commit intosonic-net:202311from
Conversation
8 tasks
bingwang-ms
approved these changes
May 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: Fix qos/test_qos_sai.py::TestQosSai::testQosSaiPfcXonLimit.
Fixes #111
Type of change
Back port request
Approach
What is the motivation for this PR?
Regression introduced by #9780
qos/test_qos_sai.py::TestQosSai::testQosSaiPfcXonLimit fails with
qos/test_qos_sai.py::TestQosSai::testQosSaiPfcXonLimit.Qos tests would fail on testQosSaiPfcXonLimit, because step 1 of the tests, which disable TX for dst_port_id, dst_port_2_id, dst_port_3_id is getting incorrect DST ports.
Due to this the tx is disabled on a port but never enabled and switch keeps on sending PFC packets and all the subsequent testcases in the module fail.
How did you do it?
Cherry picked #12151 to 202311 with additional fix mentioned in #12151 (review) as correct dst mac should be passed.
How did you verify/test it?
Verified on Arista-7050 platform with 202311 image.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation