Skip to content

[fib]: Fixed FIB V4/V6: aligned facts generator#1113

Merged
stcheng merged 1 commit intosonic-net:masterfrom
nazariig:master-fib-fix
Sep 16, 2019
Merged

[fib]: Fixed FIB V4/V6: aligned facts generator#1113
stcheng merged 1 commit intosonic-net:masterfrom
nazariig:master-fib-fix

Conversation

@nazariig
Copy link
Copy Markdown
Contributor

@nazariig nazariig commented Sep 13, 2019

Signed-off-by: Nazarii Hnydyn nazariig@mellanox.com

Description of PR

Fixed FIB V4/V6: aligned facts generator (fixes #1089)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

How did you do it?

  • Fixed roles/test/templates/fib.j2

How did you verify/test it?

  • Tested on t0/t1/t1-lag

Any platform specific information?

  • N/A

Supported testbed topology if it's a new test case?

  • N/A

Documentation

  • N/A

Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>
@nazariig
Copy link
Copy Markdown
Contributor Author

@avi-milner this fixes #1089

@liat-grozovik
Copy link
Copy Markdown
Collaborator

@nazariig do you know what was the PR who cause that break?

@nazariig
Copy link
Copy Markdown
Contributor Author

@liat-grozovik yes. This was mentioned in ticket: #1089

@lguohan lguohan requested a review from stcheng September 16, 2019 17:48
@stcheng stcheng changed the title Fixed FIB V4/V6: aligned facts generator [fib]: Fixed FIB V4/V6: aligned facts generator Sep 16, 2019
Copy link
Copy Markdown
Contributor

@stcheng stcheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this

@stcheng stcheng merged commit 4eb15bc into sonic-net:master Sep 16, 2019
@DhinakaranDayalan
Copy link
Copy Markdown

Hi,

I tired the fix and its not resolving this issue

@nazariig
Copy link
Copy Markdown
Contributor Author

nazariig commented Sep 26, 2019

Hi,

I tired the fix and its not resolving this issue

@DhinakaranDayalan please open a bug and attach all the relevant info.
BTW. Which topo are you using? The FIB v4/v6 tests are passing on t0/t1-lag.

kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
* 4d69425 2020-09-12 | [utilities] Define Explicit Dependency On Ipaddress Package (sonic-net#1113) (HEAD, origin/201811) [Guohan Lu]

Signed-off-by: Guohan Lu <lguohan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

template syntax error in FIB test caused by PR #1063

4 participants