The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/generic_config_updater/test_ntp.py:136:9: E722 do not use bare 'except'
tests/generic_config_updater/test_ntp.py:224:9: E722 do not use bare 'except'

flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
   the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
   docker container.
2. Ensure that the pre-commit package is installed:

sudo pip install pre-commit

3. Go to repository root folder
4. Install the pre-commit hooks:

pre-commit install

5. Use pre-commit to check staged file:

pre-commit

6. Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

Looks like there's a failure because of the changes?

Looks like there's a failure because of the changes?

My bad, I missed the fact that expect_op_success calls patest.fail, and I can't catch it. Aligned the test, waiting for the result.
I made the test to be backward compatible with old version, so it should pass here. And we will see the result on the new code in sonic-net/sonic-buildimage#15058

@saiarcot895 updated