Fix suppress fib failure#10697
Merged
StormLiangMS merged 1 commit intosonic-net:masterfrom Nov 10, 2023
Merged
Conversation
Collaborator
Author
|
@echuawu could you help to review and comment? |
lipxu
approved these changes
Nov 10, 2023
echuawu
approved these changes
Nov 10, 2023
Contributor
Approved. |
Collaborator
|
Cherry-pick PR to 202305: #10703 |
7 tasks
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Nov 10, 2023
What is the motivation for this PR? bgp suppress fib enabled by default, which could fail below two cases test_bgp_route_without_suppresstest_bgp_route_without_suppress test_credit_loop How did you do it? To disable the bgp suppress fib at the beginning of test. And enhance the restore_bgp_suppress_fib function How did you verify/test it? Run sonic-mgmt test
StormLiangMS
added a commit
that referenced
this pull request
Nov 10, 2023
What is the motivation for this PR? bgp suppress fib enabled by default, which could fail below two cases test_bgp_route_without_suppresstest_bgp_route_without_suppress test_credit_loop How did you do it? To disable the bgp suppress fib at the beginning of test. And enhance the restore_bgp_suppress_fib function How did you verify/test it? Run sonic-mgmt test Co-authored-by: StormLiangMS <89824293+StormLiangMS@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
bgp suppress fib enabled by default, which could fail below two cases
test_bgp_route_without_suppresstest_bgp_route_without_suppress
test_credit_loop
How did you do it?
To disable the bgp suppress fib at the beginning of test. And enhance the restore_bgp_suppress_fib function
How did you verify/test it?
Run sonic-mgmt test
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation