[minigraph] allow generating minigraph without data plane acl defined#1019
Merged
yxieca merged 2 commits intosonic-net:masterfrom Jul 19, 2019
Merged
[minigraph] allow generating minigraph without data plane acl defined#1019yxieca merged 2 commits intosonic-net:masterfrom
yxieca merged 2 commits intosonic-net:masterfrom
Conversation
Signed-off-by: Ying Xie <ying.xie@microsoft.com>
lguohan
reviewed
Jul 18, 2019
lguohan
approved these changes
Jul 19, 2019
yxieca
added a commit
that referenced
this pull request
Jul 19, 2019
…#1019) * [minigraph] allow generating minigraph without data plane acl defined Signed-off-by: Ying Xie <ying.xie@microsoft.com> * Change the default behavior to enable data plane acl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes # (issue)
Type of change
Approach
How did you do it?
Allow minigraph to be generated with or without data plane acl. Default without.
How did you verify/test it?
Generate minigraph without specifying enable_data_plane_acl
Generate minigraph with specifying enable_data_plane_acl=false
Generate minigraph with specifying enable_data_plane_acl=true