drivers/misc/eeprom: optoe patch - improve EOF handling for access beyond end of device#43
drivers/misc/eeprom: optoe patch - improve EOF handling for access beyond end of device#43donboll wants to merge 7 commits intosonic-net:masterfrom donboll:master
Conversation
* Add the optoe driver, copied from github.com/opencomputeproject/oom * Update Makefile to build optoe * Update Kconfig to conifuge optoe Signed-off-by: Don Bollinger <don@thebollingers.org>
|
Roy Lee at Accton discovered in his testing that attempts to read beyond the end of devices that do not page results in unexpected error messages. With this patch optoe returns '0' for accesses that start beyond the end of the device (256 bytes for a DAC or a QSFP without pages, 512 bytes for an SFP without pages, 32K+ for paged devices). According to the Linux Device Driver book (LDD3, ch3, page 66), "The return value for read is interpreted by the calling application program... If the value is 0, end-of-file was reached (and no data was read)." This patch implements this policy. Roy has confirmed the unexpected error messages are now gone. |
|
I seem to have done something wrong in the pull request. The only change I am requesting is the last commit, f88d7ab, the patch to improve optoe handling of EOF. Please advise if I need to change this PR. Don |
|
@donboll, you do not need all those kernel packages, and you need to put the patch into series |
|
Please disregard this pull request. I will send a cleaner PR with the same changes momentarily. |
[202412] Code sync sonic-net/sonic-linux-kernel:202411 => 202412 ``` * b865879 (HEAD -> code-sync-202412, origin/code-sync-202412) r12f 250417:0526 - Merge remote-tracking branch 'base/202411' into code-sync-202412 |\ | * a89afbc (base/202411) Saikrishna Arcot 250409:1858 - [202411] Update to Linux 6.1.123 (sonic-net#459) ```
Why I did it SONiC related packages shouldn't be intalled from Pypi. It is security compliance requirement. How I did it Check SONiC related packages when using setup.py.
No description provided.