Skip to content

Update Makefile to provision the ability of building with non-upstream patches#296

Merged
saiarcot895 merged 8 commits intosonic-net:masterfrom
vivekrnv:mlx_mod_tar
Oct 28, 2022
Merged

Update Makefile to provision the ability of building with non-upstream patches#296
saiarcot895 merged 8 commits intosonic-net:masterfrom
vivekrnv:mlx_mod_tar

Conversation

@vivekrnv
Copy link
Copy Markdown
Contributor

Dependent PR: sonic-net/sonic-buildimage#12428

Can be merged in any order

Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
Copy link
Copy Markdown
Contributor

@paulmenzel paulmenzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the patches. Please amend the commit messages to follow How to Write a Git Commit Message, and to clean it up.

Please also write a merge/pull request description describing the problem, and your solution. For example, it sounds like a directory non_upstream_patches is used by default. This has to be documented.

Lastly, what do you mean by upstream? https://www.kernel.org? Please clarify.

@liat-grozovik
Copy link
Copy Markdown
Collaborator

@saiarcot895 please help to review

Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
@vivekrnv vivekrnv requested a review from saiarcot895 October 18, 2022 22:29
@vivekrnv
Copy link
Copy Markdown
Contributor Author

Lastly, what do you mean by upstream? https://www.kernel.org? Please clarify.

It means patches that are not-yet or waiting to be upstreamed to mainline linux kernel. For a patch to be included in this repo, it has to be upstreamed in the mainline. This solution helps building the kernel with non-upstream patches (if any required)

Copy link
Copy Markdown
Contributor

@saiarcot895 saiarcot895 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New comments

Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
@vivekrnv vivekrnv requested a review from saiarcot895 October 27, 2022 00:22
@saiarcot895 saiarcot895 merged commit 686b9b1 into sonic-net:master Oct 28, 2022
Junchao-Mellanox pushed a commit to Junchao-Mellanox/sonic-linux-kernel that referenced this pull request Jan 27, 2025
…m patches (sonic-net#296)

* Update Makefile to include non-upstream patches

This adds the ability to include patches that are not yet upstream into the kernel build. This is not meant to be used in regular SONiC builds.

Signed-off-by: Vivek Reddy <vkarri@nvidia.com>

* Fix external link approach

Signed-off-by: Vivek Reddy <vkarri@nvidia.com>

* Use MLNX_PATCH_LOC as an absolute path

Signed-off-by: Vivek Reddy <vkarri@nvidia.com>

* Use MLNX_PATCH_LOC as absolute path

Signed-off-by: Vivek Reddy <vkarri@nvidia.com>

* Update minor mistake

Signed-off-by: Vivek Reddy <vkarri@nvidia.com>

* Removed hard-coded req on compression algo

Signed-off-by: Vivek Reddy <vkarri@nvidia.com>

* Handle Comments

Signed-off-by: Vivek Reddy <vkarri@nvidia.com>

* Minor update

Signed-off-by: Vivek Reddy <vkarri@nvidia.com>

Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
Junchao-Mellanox pushed a commit to Junchao-Mellanox/sonic-linux-kernel that referenced this pull request Feb 10, 2025
…m patches (sonic-net#296)

* Update Makefile to include non-upstream patches

This adds the ability to include patches that are not yet upstream into the kernel build. This is not meant to be used in regular SONiC builds.

Signed-off-by: Vivek Reddy <vkarri@nvidia.com>

* Fix external link approach

Signed-off-by: Vivek Reddy <vkarri@nvidia.com>

* Use MLNX_PATCH_LOC as an absolute path

Signed-off-by: Vivek Reddy <vkarri@nvidia.com>

* Use MLNX_PATCH_LOC as absolute path

Signed-off-by: Vivek Reddy <vkarri@nvidia.com>

* Update minor mistake

Signed-off-by: Vivek Reddy <vkarri@nvidia.com>

* Removed hard-coded req on compression algo

Signed-off-by: Vivek Reddy <vkarri@nvidia.com>

* Handle Comments

Signed-off-by: Vivek Reddy <vkarri@nvidia.com>

* Minor update

Signed-off-by: Vivek Reddy <vkarri@nvidia.com>

Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants