Skip to content

[Mellanox] Add kernel patches with hw-mgmt V.7.0010.1300#161

Merged
lguohan merged 2 commits intosonic-net:masterfrom
keboliu:patch-hw-mgmt-v1300
Nov 4, 2020
Merged

[Mellanox] Add kernel patches with hw-mgmt V.7.0010.1300#161
lguohan merged 2 commits intosonic-net:masterfrom
keboliu:patch-hw-mgmt-v1300

Conversation

@keboliu
Copy link
Copy Markdown
Collaborator

@keboliu keboliu commented Sep 11, 2020

Add new kernel patches for mlxsw driver:

  • Move PSU EEPROM configuration from kerenl to user space for SPC2 / SPC3 system
    official commit ID c071afcea6ecf24a3c119f25ce9f71ffd55b5dc2 torvalds/linux@c071afc
  • mlxsw: core: thermal: Enable thermal zones by default
    these codes are already in upstream, previously when backporting to SONiC this was set to disable, here we just restore it back, no new code added here comparing to the upstream.

Subject: [backport 4.19 3/3] mlxsw: core: thermal: Enable thermal zones by
default

Change default setting for the all thermal zones from "disabled" to
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the upstream commit id?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Guohan, actually these codes are already in upstream, previously when backporting to SONiC this was set to disable because of the thermal control not available, here we just restore it back, so no new code added here.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lguohan is it ok to be merged?
by accident i merged the dependent one before this one was taken properly to buildimage.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the upstream commit id? can you put it into the patch message?

Copy link
Copy Markdown
Contributor

@lguohan lguohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please put upstream commit id in the patch message.

@liat-grozovik
Copy link
Copy Markdown
Collaborator

@keboliu please refer to the last comment. We need the upstream commit id in the patch message. once all is clear we can move forarward.

@keboliu
Copy link
Copy Markdown
Collaborator Author

keboliu commented Oct 23, 2020

@lguohan I removed the patch which not yet merged to linux kernel community yet(which is in next next), please check again.

@keboliu keboliu force-pushed the patch-hw-mgmt-v1300 branch from 1b3c1c3 to 6cded50 Compare October 30, 2020 09:31
@keboliu
Copy link
Copy Markdown
Collaborator Author

keboliu commented Oct 30, 2020

@lguohan I removed the patch which not yet merged to linux kernel community yet(which is in next next), please check again.

@lguohan the first patch has been already merged to linux upstream, the official commit ID is: 9306c4761912961dc228c32b0de99571c3932928, I also updated the PR description.

@lguohan
Copy link
Copy Markdown
Contributor

lguohan commented Oct 30, 2020

i cannot find the 9306c4761912961dc228c32b0de99571c3932928 in this repo. https://github.com/torvalds/linux

@keboliu
Copy link
Copy Markdown
Collaborator Author

keboliu commented Nov 2, 2020

i cannot find the 9306c4761912961dc228c32b0de99571c3932928 in this repo. https://github.com/torvalds/linux

sorry, typo, check this: c071afcea6ecf24a3c119f25ce9f71ffd55b5dc2 torvalds/linux@c071afc

@liat-grozovik
Copy link
Copy Markdown
Collaborator

@lguohan anything else missing?

@lguohan lguohan merged commit dcf469b into sonic-net:master Nov 4, 2020
keboliu added a commit to keboliu/sonic-linux-kernel that referenced this pull request Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants