Skip to content

[unittest] Add missing intermediate states#16

Merged
lolyu merged 1 commit intosonic-net:masterfrom
lolyu:improve_state_machine_test_missing_states
Jan 7, 2022
Merged

[unittest] Add missing intermediate states#16
lolyu merged 1 commit intosonic-net:masterfrom
lolyu:improve_state_machine_test_missing_states

Conversation

@lolyu
Copy link
Copy Markdown
Contributor

@lolyu lolyu commented Jan 6, 2022

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • New feature
  • Doc/Design
  • Unit test

Approach

What is the motivation for this PR?

For those mux unknown states change tests, once the link manager state machine enters states like (unknown, unknown, up/down) or (wait, unknown, up/down), after mDeadlineTimer timeouts, the state machine will enter intermediate states with mux state as wait.

How did you do it?

Cover the state changes to those intermediate states:

  • (unknown, unknown, up/down) ---> (unknown, wait, up/down)
  • (wait, unknown, up/down) ---> (wait, wait, up/down)

How did you verify/test it?

Any platform specific information?

Documentation

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
@lolyu lolyu requested review from yxieca and zjswhhh January 6, 2022 02:12
@lolyu lolyu merged commit dfa2311 into sonic-net:master Jan 7, 2022
@lolyu lolyu deleted the improve_state_machine_test_missing_states branch January 7, 2022 02:58
yxieca pushed a commit that referenced this pull request Jan 14, 2022
Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
yxieca pushed a commit that referenced this pull request Jan 14, 2022
Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
zjswhhh pushed a commit to zjswhhh/sonic-linkmgrd that referenced this pull request Jan 19, 2022
Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
zjswhhh pushed a commit to zjswhhh/sonic-linkmgrd that referenced this pull request Jan 19, 2022
Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
zjswhhh pushed a commit to zjswhhh/sonic-linkmgrd that referenced this pull request Jan 24, 2022
Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
zjswhhh pushed a commit to zjswhhh/sonic-linkmgrd that referenced this pull request Jan 24, 2022
Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants