Skip to content

Pin PyGObject to 3.50.0#228

Merged
lguohan merged 1 commit intosonic-net:masterfrom
cpackham-atlnz:202411-pin-pygobject
Mar 26, 2025
Merged

Pin PyGObject to 3.50.0#228
lguohan merged 1 commit intosonic-net:masterfrom
cpackham-atlnz:202411-pin-pygobject

Conversation

@cpackham-atlnz
Copy link
Copy Markdown
Contributor

@cpackham-atlnz cpackham-atlnz commented Mar 11, 2025

Newer versions of PyGObject depend on libgirepository-2.0-dev which isn't packaged for Debian. This leads to build failures like

Collecting PyGObject
Downloading pygobject-3.52.1.tar.gz (1.2 MB)
...

× Preparing metadata (pyproject.toml) did not run successfully.
│ exit code: 1
╰─> [24 lines of output]
...

  ../meson.build:31:9: ERROR: Dependency 'girepository-2.0' is required but not found.

Pin the version of PyGObject to 3.50.0 which is the latest version known to work.

Fixes sonic-net/sonic-buildimage#21984

This needs to be cherry-picked onto the 202411branch. Probably 202405 and 202311 too. I don't think it'll apply cleanly to 202305 so that'd need a branch specific change.

@mssonicbld
Copy link
Copy Markdown

/azp run

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented Mar 11, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: cpackham-atlnz (6aa9c13)

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

@cpackham-atlnz
Copy link
Copy Markdown
Contributor Author

Would this get merged through to master or should I submit another PR for that branch?

@bradh352
Copy link
Copy Markdown

I'd think this should target master then list as cherry-pick for 202411

@cpackham-atlnz
Copy link
Copy Markdown
Contributor Author

@bradh352 yep OK. I was going to do one for master as well. Should I leave this open or will someone cherry-pick the change from the master PR?

@bhouse-nexthop
Copy link
Copy Markdown
Contributor

Just click edit at the top of this PR and change the target branch from 202411 to master. Then in the description put to cherry pick to 202411 ... at least that's how it works in other subrepositories ... you don't create a PR against a specific branch yourself unless it is branch-specific.

@cpackham-atlnz
Copy link
Copy Markdown
Contributor Author

OK cool. I'll need to rebase against master anyway

Newer versions of PyGObject depend on libgirepository-2.0-dev which
isn't packaged for Debian. This leads to build failures like

  Collecting PyGObject
  Downloading pygobject-3.52.1.tar.gz (1.2 MB)
  ...

  × Preparing metadata (pyproject.toml) did not run successfully.
  │ exit code: 1
  ╰─> [24 lines of output]
      ...

      ../meson.build:31:9: ERROR: Dependency 'girepository-2.0' is required but not found.

Pin the version of PyGObject to 3.50.0 which is the latest version known
to work.

Fixes sonic-net/sonic-buildimage#21984
@cpackham-atlnz cpackham-atlnz changed the base branch from 202411 to master March 13, 2025 19:59
@mssonicbld
Copy link
Copy Markdown

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Copy Markdown

@bradh352 bradh352 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes my build issues.

@lguohan lguohan merged commit 3ba0c59 into sonic-net:master Mar 26, 2025
5 checks passed
@dgsudharsan
Copy link
Copy Markdown
Contributor

@kperumalbfn Can you please help to cherry-pick for 202411? @r12f We would need this in 202412 as well.

@mssonicbld
Copy link
Copy Markdown

Cherry-pick PR to 202411: #233

@kperumalbfn
Copy link
Copy Markdown

@bingwang-ms We might need this in 202405 as well, pls check.

@mjonkers1989
Copy link
Copy Markdown

Is it possible to backport this fix also for the branche 202405?
Because cisco is still using that branche for sonic.

qiluo-msft added a commit to qiluo-msft/sonic-host-services that referenced this pull request Jun 2, 2025
@liushilongbuaa
Copy link
Copy Markdown
Contributor

liushilongbuaa commented Aug 28, 2025

This PR breaks build for 202412 armhf build and blocks 202411 submodule update.
Let's pin it to 3.42.2 in 202411 and msft-202412 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build failure: All branches are failing due to latest PyGObject 3.52.1 now requiring gitrepository-2.0

10 participants