[CoPP] Add always_enabled field#9302
Merged
prsunny merged 1 commit intosonic-net:masterfrom Nov 30, 2021
Merged
Conversation
dgsudharsan
previously approved these changes
Nov 22, 2021
prsunny
previously approved these changes
Nov 22, 2021
Collaborator
|
Seems lgtm feel difficult to fetch old commit on your forked repo. Could you rebase your commits onto latest master? |
348552e to
f8be269
Compare
Collaborator
Author
@qiluo-msft |
Contributor
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prsunny
approved these changes
Nov 30, 2021
Contributor
|
@dgsudharsan , please sign-off |
dgsudharsan
approved these changes
Nov 30, 2021
Collaborator
|
This commit could not be cleanly cherry-picked to 202012. Please submit another PR. |
5 tasks
liat-grozovik
pushed a commit
to sonic-net/sonic-swss
that referenced
this pull request
Jan 26, 2022
- What I did Add the new design for copp manager - always_enabled field in copp_cfg.json file. - Why I did it A change was done for traps needs to be installed but doesn't have feature (arp, udld, lacp, ip2me), in the new implementation, coppmgr will not automatically install traps which has no entry in features table, but will check first if the trap has "always_enabled":"true" field. - How I verified it run tests for making sure traps are installed and not when expecting them to. - Details if related Related to sonic-buildimage change - sonic-net/sonic-buildimage#9302 SONiC mgmt test plan can be found in sonic-net/SONiC#903.
judyjoseph
pushed a commit
to sonic-net/sonic-swss
that referenced
this pull request
Jan 31, 2022
- What I did Add the new design for copp manager - always_enabled field in copp_cfg.json file. - Why I did it A change was done for traps needs to be installed but doesn't have feature (arp, udld, lacp, ip2me), in the new implementation, coppmgr will not automatically install traps which has no entry in features table, but will check first if the trap has "always_enabled":"true" field. - How I verified it run tests for making sure traps are installed and not when expecting them to. - Details if related Related to sonic-buildimage change - sonic-net/sonic-buildimage#9302 SONiC mgmt test plan can be found in sonic-net/SONiC#903.
Contributor
|
Please raise a separate PR for 202012 |
noaOrMlnx
added a commit
to noaOrMlnx/sonic-swss
that referenced
this pull request
Feb 16, 2022
- What I did Add the new design for copp manager - always_enabled field in copp_cfg.json file. - Why I did it A change was done for traps needs to be installed but doesn't have feature (arp, udld, lacp, ip2me), in the new implementation, coppmgr will not automatically install traps which has no entry in features table, but will check first if the trap has "always_enabled":"true" field. - How I verified it run tests for making sure traps are installed and not when expecting them to. - Details if related Related to sonic-buildimage change - sonic-net/sonic-buildimage#9302 SONiC mgmt test plan can be found in sonic-net/SONiC#903.
noaOrMlnx
added a commit
to noaOrMlnx/sonic-buildimage
that referenced
this pull request
Feb 16, 2022
*Add the "always_enabled" field to copp_cfg.j2 file, in order to allow traps without an entry in features table, to be installed automatically.
6 tasks
liat-grozovik
pushed a commit
that referenced
this pull request
Feb 20, 2022
Add the "always_enabled" field to copp_cfg.j2 file, in order to allow traps without an entry in features table, to be installed automatically. This is a cherry-pick of #9302 - Why I did it In order to allow traps without an entry in features table, to be installed automatically. - How I did it Add always_enabled field to traps without a feature
arlakshm
pushed a commit
that referenced
this pull request
Mar 1, 2022
*Add the "always_enabled" field to copp_cfg.j2 file, in order to allow traps without an entry in features table, to be installed automatically.
This was referenced Mar 14, 2022
preetham-singh
pushed a commit
to preetham-singh/sonic-swss
that referenced
this pull request
Aug 6, 2022
- What I did Add the new design for copp manager - always_enabled field in copp_cfg.json file. - Why I did it A change was done for traps needs to be installed but doesn't have feature (arp, udld, lacp, ip2me), in the new implementation, coppmgr will not automatically install traps which has no entry in features table, but will check first if the trap has "always_enabled":"true" field. - How I verified it run tests for making sure traps are installed and not when expecting them to. - Details if related Related to sonic-buildimage change - sonic-net/sonic-buildimage#9302 SONiC mgmt test plan can be found in sonic-net/SONiC#903.
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
- What I did Add the new design for copp manager - always_enabled field in copp_cfg.json file. - Why I did it A change was done for traps needs to be installed but doesn't have feature (arp, udld, lacp, ip2me), in the new implementation, coppmgr will not automatically install traps which has no entry in features table, but will check first if the trap has "always_enabled":"true" field. - How I verified it run tests for making sure traps are installed and not when expecting them to. - Details if related Related to sonic-buildimage change - sonic-net/sonic-buildimage#9302 SONiC mgmt test plan can be found in sonic-net/SONiC#903.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Add the "always_enabled" field to copp_cfg.j2 file, in order to allow traps without an entry in features table, to be installed automatically.
How I did it
Add the new field, and changed the logic in sonic-swss.
In addition, add all of the enabled features to init_cfg.json.j2 file in order to have the UT passing.
How to verify it
Check that arp, udld, ip2me and lacp traps are auto installed, and traps that has no feature entry are not auto installed.
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)