[202012][submodule] update sonic-platform-common and sonic-platform-daemons by vdahiya12 · Pull Request #8607 · sonic-net/sonic-buildimage

vdahiya12 · 2021-08-26T20:08:14Z

This PR updates the following commits in sonic-platform-common
9d2e7d5 Add y-cable driver for simulated mux (#213)
e3e8f09 [Y-Cable][Broadcom] Broadcom implementation of YCable class which inherits from YCableBase required for Y-Cable API's in sonic-platform-daemons (#208)

This PR updates the following commits in sonic-platform-daemons

ebc4f3f [Y-Cable] create unknown entries for mux_cable when there is a cable present but module definition is not present/invalid module
b10c417 [xcvrd] initial support for integrating vendor specfic class objects for calling Y-Cable API's inside xcvrd (#197) (#213)
f3fc1ea [y-cable] fix for logging the xcvrd metrics before writing the state to the State-DB (#208)

Signed-off-by: vaibhav-dahiya vdahiya@microsoft.com

Why I did it

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

submodule update Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>

yxieca · 2021-08-26T20:40:47Z

Does the utilitie submodule update conflict with #8590 ? @vaibhavhd for viz.

yxieca · 2021-08-26T20:41:42Z

#8590 has been merged. This is an add-on?

vdahiya12 · 2021-08-26T20:54:45Z

#8590 has been merged. This is an add-on?

Yes This has all the changes for abstract class refactor for Y-Cables. It updates all dependencies together.

azure-pipelines · 2021-08-27T17:56:05Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2021-08-28T02:07:17Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2021-08-28T02:07:50Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2021-08-30T05:51:56Z

Azure Pipelines successfully started running 1 pipeline(s).

liat-grozovik · 2021-08-30T14:33:24Z

@vdahiya12 please note #8627 which integrating additional fixes on sonic-utilities.

vdahiya12 · 2021-08-30T17:33:05Z

Hi @qiluo-msft , @lguohan both #8627 and #8607 seems to be failing with same testcase on t1-lag. Do we need to fix this ?

____________________ 2021-08-30T12:19:46.6146965Z
2021-08-30T12:19:46.6147988Z 2021-08-30T12:19:46.6149358Z 2021-08-30T12:19:46.6150545Z 2021-08-30T12:19:46.6152197Z 2021-08-30T12:19:46.6152771Z
2021-08-30T12:19:46.6153942Z 2021-08-30T12:19:46.6156405Z 2021-08-30T12:19:46.6156878Z
2021-08-30T12:19:46.6157423Z 2021-08-30T12:19:46.6159241Z 2021-08-30T12:19:46.6159954Z
2021-08-30T12:19:46.6160517Z 2021-08-30T12:19:46.6161159Z 2021-08-30T12:19:46.6162102Z 2021-08-30T12:19:46.6163032Z 2021-08-30T12:19:46.6163649Z 2021-08-30T12:19:46.6164107Z
2021-08-30T12:19:46.6164664Z 2021-08-30T12:19:46.6165234Z 2021-08-30T12:19:46.6165594Z 2021-08-30T12:19:46.6172148Z 2021-08-30T12:19:46.6173280Z 2021-08-30T12:19:46.6174791Z 2021-08-30T12:19:46.6175624Z 2021-08-30T12:19:46.6176177Z 2021-08-30T12:19:46.6176606Z
2021-08-30T12:19:46.6177123Z 2021-08-30T12:19:46.6177753Z 2021-08-30T12:19:46.6178160Z
2021-08-30T12:19:46.6178643Z 2021-08-30T12:19:46.6179003Z
2021-08-30T12:19:46.6179265Z 2021-08-30T12:19:46.6179552Z 2021-08-30T12:19:46.6179861Z 2021-08-30T12:19:46.6180816Z 2021-08-30T12:19:46.6181428Z 2021-08-30T12:19:46.6181978Z 2021-08-30T12:19:46.6182339Z
2021-08-30T12:19:46.6182597Z 2021-08-30T12:19:46.6183162Z 2021-08-30T12:19:46.6183524Z 2021-08-30T12:19:46.6183745Z
2021-08-30T12:19:46.6184028Z 2021-08-30T12:19:46.6184369Z 2021-08-30T12:19:46.6184669Z 2021-08-30T12:19:46.6184902Z
2021-08-30T12:19:46.6185260Z 2021-08-30T12:19:46.6185929Z 2021-08-30T12:19:46.6186298Z 2021-08-30T12:19:46.6186616Z
2021-08-30T12:19:46.6187051Z 2021-08-30T12:19:46.6190985Z > 2021-08-30T12:19:46.6191338Z
2021-08-30T12:19:46.6200903Z 2021-08-30T12:19:46.6201964Z 2021-08-30T12:19:46.6202861Z dut_name 2021-08-30T12:19:46.6203554Z duthost 2021-08-30T12:19:46.6204061Z duthosts 2021-08-30T12:19:46.6205109Z 2021-08-30T12:19:46.6206358Z 2021-08-30T12:19:46.6207172Z 2021-08-30T12:19:46.6208371Z marker 2021-08-30T12:19:46.6210027Z 2021-08-30T12:19:46.6210880Z 2021-08-30T12:19:46.6211865Z tbinfo 2021-08-30T12:19:46.6212466Z
2021-08-30T12:19:46.6212895Z test_container_checker[vlab-03|teamd] _____________________
duthosts = <tests.common.devices.duthosts.DutHosts object at 0x7f4ed07e1350>
enum_dut_feature_container = 'vlab-03|teamd'
rand_selected_dut = vlab-03
tbinfo = {'auto_recover': 'False', 'comment': 'Tests virtual switch vm', 'conf-name': 'vms-kvm-t1-lag', 'duts': ['vlab-03'], ...}
def test_container_checker(duthosts, enum_dut_feature_container, rand_selected_dut, tbinfo):
"""Tests the feature of container checker.
This function will check whether the container names will appear in the Monit
alerting message if they are stopped explicitly or they hit start limitation.
Args:
duthosts: list of DUTs.
enum_dut_feature_container: A list contains strings ("<dut_name>|<container_name>").
rand_selected_dut: The fixture returns a randomly selected DuT.
tbinfo: Testbed information.
Returns:
None.
"""
dut_name, container_name = decode_dut_and_container_name(enum_dut_feature_container)
pytest_require(dut_name == rand_selected_dut.hostname and container_name != "unknown",
"Skips testing container_checker of container '{}' on the DuT '{}' since another DuT '{}' was chosen."
.format(container_name, dut_name, rand_selected_dut.hostname))
duthost = duthosts[dut_name]
loganalyzer = LogAnalyzer(ansible_host=duthost, marker_prefix="container_checker")
loganalyzer.expect_regex = []
disabled_containers = get_disabled_container_list(duthost)
skip_containers = disabled_containers[:]
skip_containers.append("gbsyncd")
skip_containers.append("database")
# Skip 'radv' container on devices whose role is not T0.
if tbinfo["topo"]["type"] != "t0":
skip_containers.append("radv")
pytest_require(container_name not in skip_containers,
"Container '{}' is skipped for testing.".format(container_name))
stop_container(duthost, container_name)
expected_alerting_message = get_expected_alerting_message(container_name)
loganalyzer.expect_regex.extend(expected_alerting_message)
marker = loganalyzer.init()
# Wait for 1 minutes such that Monit has a chance to write alerting message into syslog.
logger.info("Sleep 1 minutes to wait for the alerting message...")
time.sleep(70)
logger.info("Checking the alerting messages from syslog...")
loganalyzer.analyze(marker)
container_name = 'teamd'
disabled_containers = ['sflow', 'nat']
= 'vlab-03'
= vlab-03
= <tests.common.devices.duthosts.DutHosts object at 0x7f4ed07e1350>
enum_dut_feature_container = 'vlab-03|teamd'
expected_alerting_message = ['.*Expected containers not running.teamd.']
loganalyzer = <tests.common.plugins.loganalyzer.loganalyzer.LogAnalyzer instance at 0x7f4ecde00640>
= 'container_checker.2021-08-30-12:15:27'
rand_selected_dut = vlab-03
skip_containers = ['sflow', 'nat', 'gbsyncd', 'database', 'radv']
= {'auto_recover': 'False', 'comment': 'Tests virtual switch vm', 'conf-name': 'vms-kvm-t1-lag', 'duts': ['vlab-03'], ...}
container_checker/test_container_checker.py:244:

yozhao101 · 2021-08-30T20:34:33Z

Hi @qiluo-msft , @lguohan both #8627 and #8607 seems to be failing with same testcase on t1-lag. Do we need to fix this ?

____________________ test_container_checker[vlab-03|teamd] _____________________
2021-08-30T12:19:46.6146965Z
2021-08-30T12:19:46.6147988Z duthosts = <tests.common.devices.duthosts.DutHosts object at 0x7f4ed07e1350>
2021-08-30T12:19:46.6149358Z enum_dut_feature_container = 'vlab-03|teamd'
2021-08-30T12:19:46.6150545Z rand_selected_dut = vlab-03
2021-08-30T12:19:46.6152197Z tbinfo = {'auto_recover': 'False', 'comment': 'Tests virtual switch vm', 'conf-name': 'vms-kvm-t1-lag', 'duts': ['vlab-03'], ...}
2021-08-30T12:19:46.6152771Z
2021-08-30T12:19:46.6153942Z def test_container_checker(duthosts, enum_dut_feature_container, rand_selected_dut, tbinfo):
2021-08-30T12:19:46.6156405Z """Tests the feature of container checker.
2021-08-30T12:19:46.6156878Z
2021-08-30T12:19:46.6157423Z This function will check whether the container names will appear in the Monit
2021-08-30T12:19:46.6159241Z alerting message if they are stopped explicitly or they hit start limitation.
2021-08-30T12:19:46.6159954Z
2021-08-30T12:19:46.6160517Z Args:
2021-08-30T12:19:46.6161159Z duthosts: list of DUTs.
2021-08-30T12:19:46.6162102Z enum_dut_feature_container: A list contains strings ("<dut_name>|<container_name>").
2021-08-30T12:19:46.6163032Z rand_selected_dut: The fixture returns a randomly selected DuT.
2021-08-30T12:19:46.6163649Z tbinfo: Testbed information.
2021-08-30T12:19:46.6164107Z
2021-08-30T12:19:46.6164664Z Returns:
2021-08-30T12:19:46.6165234Z None.
2021-08-30T12:19:46.6165594Z """
2021-08-30T12:19:46.6172148Z dut_name, container_name = decode_dut_and_container_name(enum_dut_feature_container)
2021-08-30T12:19:46.6173280Z pytest_require(dut_name == rand_selected_dut.hostname and container_name != "unknown",
2021-08-30T12:19:46.6174791Z "Skips testing container_checker of container '{}' on the DuT '{}' since another DuT '{}' was chosen."
2021-08-30T12:19:46.6175624Z .format(container_name, dut_name, rand_selected_dut.hostname))
2021-08-30T12:19:46.6176177Z duthost = duthosts[dut_name]
2021-08-30T12:19:46.6176606Z
2021-08-30T12:19:46.6177123Z loganalyzer = LogAnalyzer(ansible_host=duthost, marker_prefix="container_checker")
2021-08-30T12:19:46.6177753Z loganalyzer.expect_regex = []
2021-08-30T12:19:46.6178160Z
2021-08-30T12:19:46.6178643Z disabled_containers = get_disabled_container_list(duthost)
2021-08-30T12:19:46.6179003Z
2021-08-30T12:19:46.6179265Z skip_containers = disabled_containers[:]
2021-08-30T12:19:46.6179552Z skip_containers.append("gbsyncd")
2021-08-30T12:19:46.6179861Z skip_containers.append("database")
2021-08-30T12:19:46.6180816Z # Skip 'radv' container on devices whose role is not T0.
2021-08-30T12:19:46.6181428Z if tbinfo["topo"]["type"] != "t0":
2021-08-30T12:19:46.6181978Z skip_containers.append("radv")
2021-08-30T12:19:46.6182339Z
2021-08-30T12:19:46.6182597Z pytest_require(container_name not in skip_containers,
2021-08-30T12:19:46.6183162Z "Container '{}' is skipped for testing.".format(container_name))
2021-08-30T12:19:46.6183524Z stop_container(duthost, container_name)
2021-08-30T12:19:46.6183745Z
2021-08-30T12:19:46.6184028Z expected_alerting_message = get_expected_alerting_message(container_name)
2021-08-30T12:19:46.6184369Z loganalyzer.expect_regex.extend(expected_alerting_message)
2021-08-30T12:19:46.6184669Z marker = loganalyzer.init()
2021-08-30T12:19:46.6184902Z
2021-08-30T12:19:46.6185260Z # Wait for 1 minutes such that Monit has a chance to write alerting message into syslog.
2021-08-30T12:19:46.6185929Z logger.info("Sleep 1 minutes to wait for the alerting message...")
2021-08-30T12:19:46.6186298Z time.sleep(70)
2021-08-30T12:19:46.6186616Z
2021-08-30T12:19:46.6187051Z logger.info("Checking the alerting messages from syslog...")
2021-08-30T12:19:46.6190985Z > loganalyzer.analyze(marker)
2021-08-30T12:19:46.6191338Z
2021-08-30T12:19:46.6200903Z container_name = 'teamd'
2021-08-30T12:19:46.6201964Z disabled_containers = ['sflow', 'nat']
2021-08-30T12:19:46.6202861Z dut_name = 'vlab-03'
2021-08-30T12:19:46.6203554Z duthost = vlab-03
2021-08-30T12:19:46.6204061Z duthosts = <tests.common.devices.duthosts.DutHosts object at 0x7f4ed07e1350>
2021-08-30T12:19:46.6205109Z enum_dut_feature_container = 'vlab-03|teamd'
2021-08-30T12:19:46.6206358Z expected_alerting_message = ['.*Expected containers not running.teamd.']
2021-08-30T12:19:46.6207172Z loganalyzer = <tests.common.plugins.loganalyzer.loganalyzer.LogAnalyzer instance at 0x7f4ecde00640>
2021-08-30T12:19:46.6208371Z marker = 'container_checker.2021-08-30-12:15:27'
2021-08-30T12:19:46.6210027Z rand_selected_dut = vlab-03
2021-08-30T12:19:46.6210880Z skip_containers = ['sflow', 'nat', 'gbsyncd', 'database', 'radv']
2021-08-30T12:19:46.6211865Z tbinfo = {'auto_recover': 'False', 'comment': 'Tests virtual switch vm', 'conf-name': 'vms-kvm-t1-lag', 'duts': ['vlab-03'], ...}
2021-08-30T12:19:46.6212466Z
2021-08-30T12:19:46.6212895Z container_checker/test_container_checker.py:244:

I am checking this issue and will figure out the root cause.

azure-pipelines · 2021-08-30T22:53:41Z

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>

liat-grozovik · 2021-08-31T14:31:38Z

@vdahiya12 can you please update PR description?

azure-pipelines · 2021-09-01T06:20:57Z

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>

vdahiya12 · 2021-09-01T20:40:20Z

/azp run

azure-pipelines · 2021-09-01T20:40:40Z

Azure Pipelines successfully started running 1 pipeline(s).

yozhao101 · 2021-09-02T02:14:42Z

/azp run

azure-pipelines · 2021-09-02T02:15:00Z

Azure Pipelines successfully started running 1 pipeline(s).

vdahiya12 · 2021-09-02T06:53:59Z

/azp run

azure-pipelines · 2021-09-02T06:54:17Z

Azure Pipelines successfully started running 1 pipeline(s).

yozhao101 · 2021-09-02T16:44:57Z

/azp run

azure-pipelines · 2021-09-02T16:45:15Z

Azure Pipelines successfully started running 1 pipeline(s).

vdahiya12 · 2021-09-02T22:03:07Z

/azp run

azure-pipelines · 2021-09-02T22:03:26Z

Azure Pipelines successfully started running 1 pipeline(s).

vdahiya12 · 2021-09-03T06:01:01Z

/azp run

azure-pipelines · 2021-09-03T06:01:19Z

Azure Pipelines successfully started running 1 pipeline(s).

vdahiya12 · 2021-09-04T04:06:55Z

/azp run

azure-pipelines · 2021-09-04T04:07:16Z

Azure Pipelines successfully started running 1 pipeline(s).

vdahiya12 · 2021-09-06T07:27:21Z

/azp run

azure-pipelines · 2021-09-06T07:27:38Z

Azure Pipelines successfully started running 1 pipeline(s).

[sonic-platform-common][sonic-platform-daemons][sonic-utilities]

a582901

submodule update Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>

vdahiya12 requested review from lguohan and yxieca August 26, 2021 20:13

vdahiya12 changed the title ~~[sonic-platform-common][sonic-platform-daemons][sonic-utilities] submodule update~~ [202012][sonic-platform-common][sonic-platform-daemons][sonic-utilities] submodule update Aug 26, 2021

vdahiya12 added the Submodule Update ⏫ label Aug 26, 2021

yxieca added the Included in 202012 Branch label Aug 26, 2021

yxieca approved these changes Aug 26, 2021

View reviewed changes

lguohan approved these changes Aug 27, 2021

View reviewed changes

rebase

5cce6ad

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>

vdahiya12 changed the title ~~[202012][sonic-platform-common][sonic-platform-daemons][sonic-utilities] submodule update~~ [202012][sonic-platform-common][sonic-platform-daemons] submodule update Aug 31, 2021

update submodule sonic-platform-daemon

4c534f4

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>

liat-grozovik changed the title ~~[202012][sonic-platform-common][sonic-platform-daemons] submodule update~~ [202012][submodule] update sonic-platform-common and sonic-platform-daemons Sep 2, 2021

vdahiya12 merged commit b82abd8 into sonic-net:202012 Sep 6, 2021

Conversation

vdahiya12 commented Aug 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why I did it

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

Uh oh!

yxieca commented Aug 26, 2021

Uh oh!

yxieca commented Aug 26, 2021

Uh oh!

vdahiya12 commented Aug 26, 2021

Uh oh!

azure-pipelines bot commented Aug 27, 2021

Uh oh!

azure-pipelines bot commented Aug 28, 2021

Uh oh!

azure-pipelines bot commented Aug 28, 2021

Uh oh!

azure-pipelines bot commented Aug 30, 2021

Uh oh!

liat-grozovik commented Aug 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vdahiya12 commented Aug 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yozhao101 commented Aug 30, 2021

Uh oh!

azure-pipelines bot commented Aug 30, 2021

Uh oh!

liat-grozovik commented Aug 31, 2021

Uh oh!

azure-pipelines bot commented Sep 1, 2021

Uh oh!

vdahiya12 commented Sep 1, 2021

Uh oh!

azure-pipelines bot commented Sep 1, 2021

Uh oh!

yozhao101 commented Sep 2, 2021

Uh oh!

azure-pipelines bot commented Sep 2, 2021

Uh oh!

vdahiya12 commented Sep 2, 2021

Uh oh!

azure-pipelines bot commented Sep 2, 2021

Uh oh!

yozhao101 commented Sep 2, 2021

Uh oh!

azure-pipelines bot commented Sep 2, 2021

Uh oh!

vdahiya12 commented Sep 2, 2021

Uh oh!

azure-pipelines bot commented Sep 2, 2021

Uh oh!

vdahiya12 commented Sep 3, 2021

Uh oh!

azure-pipelines bot commented Sep 3, 2021

Uh oh!

vdahiya12 commented Sep 4, 2021

Uh oh!

azure-pipelines bot commented Sep 4, 2021

Uh oh!

vdahiya12 commented Sep 6, 2021

Uh oh!

azure-pipelines bot commented Sep 6, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

vdahiya12 commented Aug 26, 2021 •

edited

Loading

liat-grozovik commented Aug 30, 2021 •

edited

Loading

vdahiya12 commented Aug 30, 2021 •

edited

Loading