[voq][minigraph] Add admin_status attribute for inband interface#8050
Merged
abdosi merged 2 commits intosonic-net:masterfrom Jul 26, 2021
Merged
[voq][minigraph] Add admin_status attribute for inband interface#8050abdosi merged 2 commits intosonic-net:masterfrom
abdosi merged 2 commits intosonic-net:masterfrom
Conversation
Changes to add admin_status attribute for voq inband interface port, if it exists in the PORT table keys. Signed-off-by: vedganes <vedavinayagam.ganesan@nokia.com>
|
@mlorrillere- could you please review, thanks! |
mlorrillere
previously approved these changes
Jul 12, 2021
abdosi
approved these changes
Jul 13, 2021
abdosi
requested changes
Jul 13, 2021
Contributor
abdosi
left a comment
There was a problem hiding this comment.
lets add unit test case to cover inband port status
Following changes done to add unit test to test addition of "admin_status" for Ethernet-IB entry in the PORT table. - Port type voq inband interface is added in the sample minigraph.xml - Sample port_config.ini is added for voq that has the Ethernet-IB port defined. - Test cases added to check for port type inband interface and presence of 'admin_status" for Ethernet-IB port in the PORT table. Signed-off-by: vedganes <vedavinayagam.ganesan@nokia.com>
Contributor
Author
Added unit tests. |
abdosi
approved these changes
Jul 26, 2021
judyjoseph
pushed a commit
that referenced
this pull request
Aug 4, 2021
Why I did it In the config_db.json generated by minigraph "admin_status" attribute is missing for the VOQ inband interface port in the PORT table. How I did it Changes done to add admin_status attribute for voq inband interface port, if it exists in the PORT table keys.
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
…ic-net#8050) Why I did it In the config_db.json generated by minigraph "admin_status" attribute is missing for the VOQ inband interface port in the PORT table. How I did it Changes done to add admin_status attribute for voq inband interface port, if it exists in the PORT table keys.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
In the config_db.json generated by minigraph "admin_status" attribute is missing for the VOQ inband interface port in the PORT table.
How I did it
Changes done to add admin_status attribute for voq inband interface port, if it exists in the PORT table keys.
How to verify it
Description for the changelog
admin_status attribute for inband interface port