[bgpcfgd] Remove unnecessary dependency for StaticRouteMgr#8037
Merged
shi-su merged 2 commits intosonic-net:masterfrom Jul 9, 2021
Merged
[bgpcfgd] Remove unnecessary dependency for StaticRouteMgr#8037shi-su merged 2 commits intosonic-net:masterfrom
shi-su merged 2 commits intosonic-net:masterfrom
Conversation
Collaborator
|
@vivekreddynv could you please review and provide feedback that indeed it is fixed following the issue you raised? |
Contributor
|
Verified. |
prsunny
approved these changes
Jul 9, 2021
qiluo-msft
pushed a commit
that referenced
this pull request
Jul 13, 2021
Why I did it Static route configuration should not depend on BGP_ASN. Remove the dependency on BGP_ASN for StaticRouteMgr. Fix #8027 How I did it Check if BGP_ASN field before configuring static route redistribution and wait until BGP_ASN is available to enable static route redistribution. How to verify it Add unit test to cover the scenario and verify the functionality on a virtual switch.
judyjoseph
pushed a commit
that referenced
this pull request
Jul 13, 2021
Why I did it Static route configuration should not depend on BGP_ASN. Remove the dependency on BGP_ASN for StaticRouteMgr. Fix #8027 How I did it Check if BGP_ASN field before configuring static route redistribution and wait until BGP_ASN is available to enable static route redistribution. How to verify it Add unit test to cover the scenario and verify the functionality on a virtual switch.
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
…#8037) Why I did it Static route configuration should not depend on BGP_ASN. Remove the dependency on BGP_ASN for StaticRouteMgr. Fix sonic-net#8027 How I did it Check if BGP_ASN field before configuring static route redistribution and wait until BGP_ASN is available to enable static route redistribution. How to verify it Add unit test to cover the scenario and verify the functionality on a virtual switch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Static route configuration should not depend on BGP_ASN. Remove the dependency on BGP_ASN for StaticRouteMgr.
Fix #8027
How I did it
Check if BGP_ASN field before configuring static route redistribution and wait until BGP_ASN is available to enable static route redistribution.
How to verify it
Add unit test to cover the scenario and verify the functionality on a virtual switch.
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)