[PDDF] Add get_sfp() to chassis to handle port idx#7980
Merged
lguohan merged 2 commits intosonic-net:masterfrom Jul 25, 2021
Merged
[PDDF] Add get_sfp() to chassis to handle port idx#7980lguohan merged 2 commits intosonic-net:masterfrom
lguohan merged 2 commits intosonic-net:masterfrom
Conversation
Signed-off-by: Jostar Yang <jostar_yang@accton.com.tw>
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lguohan
approved these changes
Jul 25, 2021
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
…7980) * Modify index start from 1 in in get_change_event() Co-authored-by: Jostar Yang <jostar_yang@accton.com.tw>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jostar Yang jostar_yang@accton.com.tw
Why I did it
Add get_sfp() to chassis to handle port_config.ini port index start from 1.
Configure use port start from 1, but code sfp_list[] is start from 0. It will cause port range error.
How I did it
Implement get_sfp() to chassis.py
How to verify it
Test script to check port range is ok from 1 to 58 on as7326 and other DUT.
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)