Skip to content

RADIUS Management User Authentication#7551

Merged
lguohan merged 2 commits intosonic-net:masterfrom
a-barboza:issue-radius-arm64-build
Jun 14, 2021
Merged

RADIUS Management User Authentication#7551
lguohan merged 2 commits intosonic-net:masterfrom
a-barboza:issue-radius-arm64-build

Conversation

@a-barboza
Copy link
Copy Markdown
Contributor

Fixed the RADIUS client debian packages build
for arm64, armhf PLATFORM_ARCH, by using the latest
config.sub/config.guess

Why I did it

Fixed the RADIUS client debian packages build for arm64, armhf PLATFORM_ARCH

How I did it

Used the latest config.sub/config.guess

How to verify it

Build the RADIUS client debian packages for arm64,armhf

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012

Description for the changelog

Fixed the RADIUS client debian packages build
for arm64, armhf PLATFORM_ARCH, by using the latest
config.sub/config.guess

A picture of a cute animal (not mandatory but encouraged)

* Fixed the RADIUS client debian packages build
  for arm64, armhf PLATFORM_ARCH, by using the latest
  config.sub/config.guess
@a-barboza a-barboza requested a review from lguohan as a code owner May 6, 2021 22:33
@lguohan
Copy link
Copy Markdown
Collaborator

lguohan commented May 7, 2021

config.sub and config.guess are generated file, we should not check-in those files.

can you take a look at debian packaging to see how they can enable the build of arm64?

https://packages.debian.org/buster/freeradius

@a-barboza
Copy link
Copy Markdown
Contributor Author

config.sub and config.guess are generated file, we should not check-in those files.

can you take a look at debian packaging to see how they can enable the build of arm64?

https://packages.debian.org/buster/freeradius

I used that similar technique as freeradius maintainers. Please see this commit id.

FreeRADIUS/freeradius-server@6d47caa

@lguohan
Copy link
Copy Markdown
Collaborator

lguohan commented May 7, 2021

i did not realize your version so old? 1.1.1? can you use later version. buster is using 3.0.17 now.

@a-barboza
Copy link
Copy Markdown
Contributor Author

i did not realize your version so old? 1.1.1? can you use later version. buster is using 3.0.17 now.

That is the server version. We are using the pam_radius client which does not have an official debian version, so it is being built from github.com/pam_radius. Some of the PEAP modules are used from freeradius-server for PEAP authentication

@lguohan
Copy link
Copy Markdown
Collaborator

lguohan commented May 7, 2021

for client, debian packaging also do not have guess. can you check how debian package and build on arm64? https://packages.debian.org/buster/libpam-radius-auth

why do we need build server here?

@a-barboza
Copy link
Copy Markdown
Contributor Author

for client, debian packaging also do not have guess. can you check how debian package and build on arm64? https://packages.debian.org/buster/libpam-radius-auth

why do we need build server here?

Cc: @adyeung

Got it. I will check the debian source package for libpam-radius-auth for buster for arm64/armhf compile.

The github sources for libpam-radius-auth (https://github.com/FreeRADIUS/pam_radius) did not have support for the PEAP/MSCHAPv2 authentication, therefore the library from the freeradius-server was used to implement this. Another option would be to look for this library if it appears separately, or write one from scratch. The latter would require considerable more effort, therefore the option of using freeradius-server (from that older version) was chosen.

@lguohan
Copy link
Copy Markdown
Collaborator

lguohan commented May 7, 2021

if you just want to use the library, why not use this one? https://packages.debian.org/buster/libfreeradius3

@a-barboza
Copy link
Copy Markdown
Contributor Author

if you just want to use the library, why not use this one? https://packages.debian.org/buster/libfreeradius3

libfreeradius3 is being built from the freeradius (previously freeradius-server) source tar ball. At the time of original writing the freeradius 1.1.x tree was being used. Now, it is 3.0.x. So, I understand the ask to mean: upgrade to 3.0.x for using the latest library from freeradius (server) source package. The re-write to use the 3.0.x interfaces would require more time.

@lguohan
Copy link
Copy Markdown
Collaborator

lguohan commented May 7, 2021

already, please fix the client side first? and then plan for upgrade to use the freeradius library accordingly.

@a-barboza
Copy link
Copy Markdown
Contributor Author

understood. Will update PR for the pam_radius to use the buster debian arm64.

Refactored for using buster debian scripts.
@a-barboza
Copy link
Copy Markdown
Contributor Author

understood. Will update PR for the pam_radius to use the buster debian arm64.

Updated on 05/14/21

@lguohan lguohan merged commit da3d3aa into sonic-net:master Jun 14, 2021
Junchao-Mellanox pushed a commit to Junchao-Mellanox/sonic-buildimage that referenced this pull request Jun 24, 2021
Fixed the RADIUS client debian packages build for arm64, armhf PLATFORM_ARCH
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
Fixed the RADIUS client debian packages build for arm64, armhf PLATFORM_ARCH
@a-barboza a-barboza deleted the issue-radius-arm64-build branch September 30, 2021 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants