[docker-gbsyncd-vs] Run new gbsyncdmgrd in lieu of deprecated gbsyncd_startup.py#7154
Merged
lguohan merged 1 commit intosonic-net:masterfrom Mar 27, 2021
jleveque:gbsyncdmgrd
Merged
[docker-gbsyncd-vs] Run new gbsyncdmgrd in lieu of deprecated gbsyncd_startup.py#7154lguohan merged 1 commit intosonic-net:masterfrom jleveque:gbsyncdmgrd
lguohan merged 1 commit intosonic-net:masterfrom
jleveque:gbsyncdmgrd
Conversation
lguohan
approved these changes
Mar 27, 2021
daall
pushed a commit
that referenced
this pull request
Apr 1, 2021
…_startup.py (#7154) To improve management of docker-gbsyncd-vs. gbsyncd_startup.py simply spawned syncd processes and then exited. In that case, supervisord would no longer manage any processes in the container, and thus there was no way to know if a critical process had exited. I recently created gbsyncdmgrd to be a more complete, robust replacement for gbsyncd_startup.py. NOTE: This PR is dependent on the inclusion of gbsyncdmgrd in the sonic-sairedis repo. A submodule update is pending at #7089
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-buildimage
that referenced
this pull request
May 23, 2021
…_startup.py (sonic-net#7154) To improve management of docker-gbsyncd-vs. gbsyncd_startup.py simply spawned syncd processes and then exited. In that case, supervisord would no longer manage any processes in the container, and thus there was no way to know if a critical process had exited. I recently created gbsyncdmgrd to be a more complete, robust replacement for gbsyncd_startup.py. NOTE: This PR is dependent on the inclusion of gbsyncdmgrd in the sonic-sairedis repo. A submodule update is pending at sonic-net#7089
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
…_startup.py (sonic-net#7154) To improve management of docker-gbsyncd-vs. gbsyncd_startup.py simply spawned syncd processes and then exited. In that case, supervisord would no longer manage any processes in the container, and thus there was no way to know if a critical process had exited. I recently created gbsyncdmgrd to be a more complete, robust replacement for gbsyncd_startup.py. NOTE: This PR is dependent on the inclusion of gbsyncdmgrd in the sonic-sairedis repo. A submodule update is pending at sonic-net#7089
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
To improve management of docker-gbsyncd-vs.
gbsyncd_startup.pysimply spawned syncd processes and then exited. In that case, supervisord would no longer manage any processes in the container, and thus there was no way to know if a critical process had exited.I recently created
gbsyncdmgrdto be a more complete, robust replacement forgbsyncd_startup.py.NOTE: This PR is dependent on the inclusion of
gbsyncdmgrdin the sonic-sairedis repo. A submodule update is pending at#7089
How I did it
Replace references to
gbsyncd_startup.pywithgbsyncdmgrd.How to verify it
Ensure gbsyncdmgrd spawns all applicable syncd processes, and that it will exit if any of the syncd subprocesses exits.
Which release branch to backport (provide reason below if selected)