[docker-teamd]: Explicitly set LAG hwaddr#664
Merged
lguohan merged 5 commits intosonic-net:masterfrom Jun 6, 2017
Merged
Conversation
Team device is initially created without any members and has a random HW address, which is later changed to port's address. This configuration sets team device's address explicitly to base MAC to avoid reassignment. Signed-off-by: marian-pritsak <marianp@mellanox.com>
Collaborator
|
test fails, can you check? |
Collaborator
|
also, I think centec also use your approach to set up the switch mac, can you check? https://github.com/Azure/sonic-sairedis/blob/master/syncd/scripts/syncd_init_common.sh#L63 |
dockers/docker-teamd/start.sh
Outdated
| SONIC_ASIC_TYPE=$(sonic-cfggen -y /etc/sonic/sonic_version.yml -v asic_type) | ||
| MAC_ADDRESS=$(ip link show eth0 | grep ether | awk '{print $2}') | ||
|
|
||
| # Nellanox platform requires has last byte aligned |
Signed-off-by: marian-pritsak <marianp@mellanox.com>
Signed-off-by: marian-pritsak <marianp@mellanox.com>
lguohan
requested changes
Jun 6, 2017
| @@ -1,5 +1,6 @@ | |||
| { | |||
| "device": "PortChannel04", | |||
| "hwaddr": "11:22:33:44:55:66", | |||
Collaborator
There was a problem hiding this comment.
11 is multicast address, not a valid src mac address.
Signed-off-by: marian-pritsak <marianp@mellanox.com>
lguohan
approved these changes
Jun 6, 2017
lguohan
added a commit
to lguohan/sonic-buildimage
that referenced
this pull request
Nov 1, 2018
swss: * 863b69c 2018-11-01 | [teamsyncd]: Fix bug when removing selectable in select function (sonic-net#665) (HEAD, origin/master, origin/HEAD) [Shuotian Cheng] * 2c83b68 2018-10-31 | Warm reboot: bring up ports for whole system warm reboot (sonic-net#653) [Qi Luo] * d049d65 2018-10-31 | [vstest]: get subscribed objects from appdb and asicdb (sonic-net#664) [lguohan] * 057a329 2018-10-31 | [vstest]: change the redis mount point when --dvsname is provided. (sonic-net#663) [lguohan] * 34e157e 2018-10-31 | [VS]: fix swss warm restart test (sonic-net#662) [Jipan Yang] sairedis: * c612c5e 2018-11-01 | Add specific comparison logic for more objects (sonic-net#360) (HEAD, origin/master, origin/HEAD) [Kamil Cudnik] * a6b709a 2018-10-31 | [syncd] re-establish notifications after warm boot (sonic-net#368) [Ying Xie] * d655d20 2018-10-29 | [syncd] partial warm recovery support (sonic-net#352) [Ying Xie] * 4d9aa18 2018-10-29 | Add missing object types to virtual switch (sonic-net#364) [Kamil Cudnik] * 1fdaf47 2018-10-29 | Add VS support for setting stats via redis DB channel (sonic-net#366) [Kamil Cudnik] Signed-off-by: Guohan Lu <gulv@microsoft.com>
lguohan
added a commit
that referenced
this pull request
Nov 1, 2018
swss: * 863b69c 2018-11-01 | [teamsyncd]: Fix bug when removing selectable in select function (#665) (HEAD, origin/master, origin/HEAD) [Shuotian Cheng] * 2c83b68 2018-10-31 | Warm reboot: bring up ports for whole system warm reboot (#653) [Qi Luo] * d049d65 2018-10-31 | [vstest]: get subscribed objects from appdb and asicdb (#664) [lguohan] * 057a329 2018-10-31 | [vstest]: change the redis mount point when --dvsname is provided. (#663) [lguohan] * 34e157e 2018-10-31 | [VS]: fix swss warm restart test (#662) [Jipan Yang] sairedis: * c612c5e 2018-11-01 | Add specific comparison logic for more objects (#360) (HEAD, origin/master, origin/HEAD) [Kamil Cudnik] * a6b709a 2018-10-31 | [syncd] re-establish notifications after warm boot (#368) [Ying Xie] * d655d20 2018-10-29 | [syncd] partial warm recovery support (#352) [Ying Xie] * 4d9aa18 2018-10-29 | Add missing object types to virtual switch (#364) [Kamil Cudnik] * 1fdaf47 2018-10-29 | Add VS support for setting stats via redis DB channel (#366) [Kamil Cudnik] Signed-off-by: Guohan Lu <gulv@microsoft.com>
yxieca
added a commit
to yxieca/sonic-buildimage
that referenced
this pull request
Oct 2, 2019
Submodule src/sonic-swss fcd091c..9585be4: > [teamsyncd]: Check if LAG exists before removing (sonic-net#1069) > [mirrororch]: Toggle the mirror session when moving between VLAN/non-VLAN (sonic-net#1078) Submodule src/sonic-utilities 7bb6ffb..2d721de: > [show] Properly replace port name with alias in command output (sonic-net#664) > [neighbor_advertiser] hand pick partial change from sonic-net#525 (sonic-net#689) > Revert "Revert "Fixed config Asym PFC CLI. (sonic-net#632)" (sonic-net#652)" Signed-off-by: Ying Xie <ying.xie@microsoft.com>
yxieca
added a commit
that referenced
this pull request
Oct 3, 2019
* [201811][swss][utilities] advance sub module head Submodule src/sonic-swss fcd091c..9585be4: > [teamsyncd]: Check if LAG exists before removing (#1069) > [mirrororch]: Toggle the mirror session when moving between VLAN/non-VLAN (#1078) Submodule src/sonic-utilities 7bb6ffb..2d721de: > [show] Properly replace port name with alias in command output (#664) > [neighbor_advertiser] hand pick partial change from #525 (#689) > Revert "Revert "Fixed config Asym PFC CLI. (#632)" (#652)" Signed-off-by: Ying Xie <ying.xie@microsoft.com> * address compile issue Submodule src/sonic-swss 9585be4..2529d79: > [mirrororch]: Address compiler switch issue (#1079) Signed-off-by: Ying Xie <ying.xie@microsoft.com>
madhanmellanox
pushed a commit
to madhanmellanox/sonic-buildimage
that referenced
this pull request
Mar 23, 2020
Signed-off-by: Guohan Lu <gulv@microsoft.com>
stepanblyschak
pushed a commit
to stepanblyschak/sonic-buildimage
that referenced
this pull request
May 10, 2021
AidanCopeland
pushed a commit
to Metaswitch/sonic-buildimage
that referenced
this pull request
Apr 14, 2022
During warm boot we also need to update notification pointers when creating switch in warm boot mode, since syncd/vendor_sai_lib could be loaded at different address space, and this can lead to SIGSEGV, since previous address may not be available
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Team device is initially created without any members and has a random HW
address, which is later changed to port's address. This configuration
sets team device's address explicitly to base MAC to avoid reassignment.
Signed-off-by: marian-pritsak marianp@mellanox.com