Skip to content

Use default table instead of main table for forced_mgmt_routes#635

Merged
stcheng merged 1 commit intosonic-net:masterfrom
taoyl-ms:taoyl/mgmt_route
May 27, 2017
Merged

Use default table instead of main table for forced_mgmt_routes#635
stcheng merged 1 commit intosonic-net:masterfrom
taoyl-ms:taoyl/mgmt_route

Conversation

@taoyl-ms
Copy link
Copy Markdown
Contributor

In the previous version, we forced certain prefixes to use mgmt route by adding routes into routing table in eth0 interface up script. This is mainly for connection to crucial mgmt services such as syslog when front panel port networking is not healthy. However, this creates an issue when BGP neighbor announces the same prefixes - those routes will fail to be added into kernel routing table, thus fail to be synced into ASIC.

The correct way to add forced mgmt routes is to create another routing table using mgmt network (which we already did), and to use ip rule to use this routing table for certain destinations. By this approach control plane and data plane routes are isolated and could be configured independently.

@stcheng
Copy link
Copy Markdown
Contributor

stcheng commented May 26, 2017

add some comments in the commit message?

@stcheng stcheng merged commit bd52f41 into sonic-net:master May 27, 2017
lguohan added a commit to lguohan/sonic-buildimage that referenced this pull request Dec 28, 2018
* 0c07a80 2018-12-27 | [intfmgrd]: Merge intfsyncd into intfmgrd (sonic-net#635) (HEAD, origin/master, origin/HEAD) [Marian Pritsak]
* a45c7b5 2018-12-23 | [watermark] fix watermark clear not working for PG (sonic-net#729) [Mykola F]
*   25d16b3 2018-12-23 | [neighorch] return back original condition for port oper status (sonic-net#727) [Qi Luo]
|\
| * 05a3558 2018-12-12 | [neighorch] return back original condition for port oper status [Stepan Blyschak]
* | 514cfef 2018-12-23 | [swssconfig]: Remove deprecated qos buffer configurations (sonic-net#726) [Shuotian Cheng]
* | 025268a 2018-12-22 | [WR]: Add reconciliation logic for teamsyncd (sonic-net#725) [pavel-shirshov]
* | 5803a8c 2018-12-21 | Fix: crash while destructing crmorch (sonic-net#731) [Qi Luo]
* | 998b4ab 2018-12-21 | Temporarily skip the testcase test_routing_WarmRestart to unblock other pull requests (sonic-net#733) [Qi Luo]
* | a7a68c1 2018-12-19 | Optimize neigh restore process during warm-reboot (sonic-net#722) [zhenggen-xu]
|/
* 3d60b3e 2018-12-03 | [portsorch] Portsorch simple improvements (sonic-net#718) [stepanblyschak]

Signed-off-by: Guohan Lu <gulv@microsoft.com>
lguohan added a commit that referenced this pull request Dec 29, 2018
* 0c07a80 2018-12-27 | [intfmgrd]: Merge intfsyncd into intfmgrd (#635) (HEAD, origin/master, origin/HEAD) [Marian Pritsak]
* a45c7b5 2018-12-23 | [watermark] fix watermark clear not working for PG (#729) [Mykola F]
*   25d16b3 2018-12-23 | [neighorch] return back original condition for port oper status (#727) [Qi Luo]
|\
| * 05a3558 2018-12-12 | [neighorch] return back original condition for port oper status [Stepan Blyschak]
* | 514cfef 2018-12-23 | [swssconfig]: Remove deprecated qos buffer configurations (#726) [Shuotian Cheng]
* | 025268a 2018-12-22 | [WR]: Add reconciliation logic for teamsyncd (#725) [pavel-shirshov]
* | 5803a8c 2018-12-21 | Fix: crash while destructing crmorch (#731) [Qi Luo]
* | 998b4ab 2018-12-21 | Temporarily skip the testcase test_routing_WarmRestart to unblock other pull requests (#733) [Qi Luo]
* | a7a68c1 2018-12-19 | Optimize neigh restore process during warm-reboot (#722) [zhenggen-xu]
|/
* 3d60b3e 2018-12-03 | [portsorch] Portsorch simple improvements (#718) [stepanblyschak]

Signed-off-by: Guohan Lu <gulv@microsoft.com>
yxieca pushed a commit that referenced this pull request Jan 4, 2019
* 0c07a80 2018-12-27 | [intfmgrd]: Merge intfsyncd into intfmgrd (#635) (HEAD, origin/master, origin/HEAD) [Marian Pritsak]
* a45c7b5 2018-12-23 | [watermark] fix watermark clear not working for PG (#729) [Mykola F]
*   25d16b3 2018-12-23 | [neighorch] return back original condition for port oper status (#727) [Qi Luo]
|\
| * 05a3558 2018-12-12 | [neighorch] return back original condition for port oper status [Stepan Blyschak]
* | 514cfef 2018-12-23 | [swssconfig]: Remove deprecated qos buffer configurations (#726) [Shuotian Cheng]
* | 025268a 2018-12-22 | [WR]: Add reconciliation logic for teamsyncd (#725) [pavel-shirshov]
* | 5803a8c 2018-12-21 | Fix: crash while destructing crmorch (#731) [Qi Luo]
* | 998b4ab 2018-12-21 | Temporarily skip the testcase test_routing_WarmRestart to unblock other pull requests (#733) [Qi Luo]
* | a7a68c1 2018-12-19 | Optimize neigh restore process during warm-reboot (#722) [zhenggen-xu]
|/
* 3d60b3e 2018-12-03 | [portsorch] Portsorch simple improvements (#718) [stepanblyschak]

Signed-off-by: Guohan Lu <gulv@microsoft.com>
madhanmellanox pushed a commit to madhanmellanox/sonic-buildimage that referenced this pull request Mar 23, 2020
* VNET/VRF Changes  (#6)

* VRF changes

* Fixed an IPv6 address parsing issue

* Updated logs, removed intfmgr changes in favour of PR sonic-net#635

* Updated VRF table name

* Addressed review comment, test fixes

* Remove extra semi-colon

* Route handling, review comments (#8)

* Vnet route table handling

* Addressed review comments

* Fix for interface routes, add debug logs
madhanmellanox pushed a commit to madhanmellanox/sonic-buildimage that referenced this pull request Mar 23, 2020
* [intfmgrd]: Merge intfsyncd into intfmgrd

Move intfsyncd functionality to intfmgrd, add VRF membership support.
stepanblyschak pushed a commit to stepanblyschak/sonic-buildimage that referenced this pull request Jul 15, 2020
Updated sonic-sairedis pointer:
    d54bfb4 [SAI] update pointer (sonic-net#636)
    1885a8c [syncd] Fix notification on shutdown request (sonic-net#635)
    9e57ba2 Fixing hostif For Genetlink host interfaces (sonic-net#633)
    449a092 sonic-sairedis: Add support to sonic-sairedis for gearbox phys (sonic-net#632)

Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
lguohan pushed a commit that referenced this pull request Jul 18, 2020
Upgrade to libsensors5

Updated sonic-sairedis pointer:
    d54bfb4 [SAI] update pointer (#636)
    1885a8c [syncd] Fix notification on shutdown request (#635)
    9e57ba2 Fixing hostif For Genetlink host interfaces (#633)
    449a092 sonic-sairedis: Add support to sonic-sairedis for gearbox phys (#632)

Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
dmytroxshevchuk pushed a commit to dmytroxshevchuk/sonic-buildimage that referenced this pull request Aug 31, 2020
* [syncd] Fix notification on shutdown request

* Move check to the beginning of the function
dprital pushed a commit to dprital/sonic-buildimage that referenced this pull request Feb 20, 2025
… automatically (sonic-net#635)

#### Why I did it
src/sonic-platform-common
```
* d9de488 - (HEAD -> 202412, origin/202412) [code sync] Merge code from sonic-net/sonic-platform-common:202411 to 202412 (#28) (7 hours ago) [mssonicbld]
* 30112ca - [code sync] Merge code from sonic-net/sonic-platform-common:202411 to 202412 (#26) (31 hours ago) [mssonicbld]
* a36263b - [code sync] Merge code from sonic-net/sonic-platform-common:202411 to 202412 (#24) (2 days ago) [mssonicbld]
```
#### How I did it
#### How to verify it
#### Description for the changelog
mssonicbld added a commit that referenced this pull request Nov 5, 2025
…D automatically (#24379)

#### Why I did it
src/sonic-platform-daemons
```
* 011d949 - (HEAD -> master, origin/master, origin/HEAD) [thermalctld] Change thermal monitor from sub-process to thread (#692) (4 days ago) [Junchao-Mellanox]
* ef9eb35 - Pass arguments to thermalctld.ThermalControlDaemon (#700) (4 days ago) [louis-nexthop]
* 959761c - Xcvrd Refactor 2/12: Move CmisManagerTask into it's own module (#691) (6 days ago) [Bobby McGonigle]
* e73eee5 - Make polling intervals in the ThermalMonitor class configurable (#635) (6 days ago) [michaelc-nexthop]
* 7c75b28 - add exception handling in get_chassis (#652) (7 days ago) [LinJin23]
```
#### How I did it
#### How to verify it
#### Description for the changelog
ashutosh-agrawal pushed a commit to AnantKishorSharma/sonic-buildimage that referenced this pull request Nov 30, 2025
…D automatically (sonic-net#24379)

#### Why I did it
src/sonic-platform-daemons
```
* 011d949 - (HEAD -> master, origin/master, origin/HEAD) [thermalctld] Change thermal monitor from sub-process to thread (sonic-net#692) (4 days ago) [Junchao-Mellanox]
* ef9eb35 - Pass arguments to thermalctld.ThermalControlDaemon (sonic-net#700) (4 days ago) [louis-nexthop]
* 959761c - Xcvrd Refactor 2/12: Move CmisManagerTask into it's own module (sonic-net#691) (6 days ago) [Bobby McGonigle]
* e73eee5 - Make polling intervals in the ThermalMonitor class configurable (sonic-net#635) (6 days ago) [michaelc-nexthop]
* 7c75b28 - add exception handling in get_chassis (sonic-net#652) (7 days ago) [LinJin23]
```
#### How I did it
#### How to verify it
#### Description for the changelog
FengPan-Frank pushed a commit to FengPan-Frank/sonic-buildimage that referenced this pull request Dec 4, 2025
…D automatically (sonic-net#24379)

#### Why I did it
src/sonic-platform-daemons
```
* 011d949 - (HEAD -> master, origin/master, origin/HEAD) [thermalctld] Change thermal monitor from sub-process to thread (sonic-net#692) (4 days ago) [Junchao-Mellanox]
* ef9eb35 - Pass arguments to thermalctld.ThermalControlDaemon (sonic-net#700) (4 days ago) [louis-nexthop]
* 959761c - Xcvrd Refactor 2/12: Move CmisManagerTask into it's own module (sonic-net#691) (6 days ago) [Bobby McGonigle]
* e73eee5 - Make polling intervals in the ThermalMonitor class configurable (sonic-net#635) (6 days ago) [michaelc-nexthop]
* 7c75b28 - add exception handling in get_chassis (sonic-net#652) (7 days ago) [LinJin23]
```
#### How I did it
#### How to verify it
#### Description for the changelog

Signed-off-by: Feng Pan <fenpan@microsoft.com>
xwjiang-ms pushed a commit to xwjiang-ms/sonic-buildimage that referenced this pull request Dec 22, 2025
…D automatically (sonic-net#24379)

#### Why I did it
src/sonic-platform-daemons
```
* 011d949 - (HEAD -> master, origin/master, origin/HEAD) [thermalctld] Change thermal monitor from sub-process to thread (sonic-net#692) (4 days ago) [Junchao-Mellanox]
* ef9eb35 - Pass arguments to thermalctld.ThermalControlDaemon (sonic-net#700) (4 days ago) [louis-nexthop]
* 959761c - Xcvrd Refactor 2/12: Move CmisManagerTask into it's own module (sonic-net#691) (6 days ago) [Bobby McGonigle]
* e73eee5 - Make polling intervals in the ThermalMonitor class configurable (sonic-net#635) (6 days ago) [michaelc-nexthop]
* 7c75b28 - add exception handling in get_chassis (sonic-net#652) (7 days ago) [LinJin23]
```
#### How I did it
#### How to verify it
#### Description for the changelog

Signed-off-by: xiaweijiang <xiaweijiang@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants