[psu] Fix incorrect file path for voltage, current and power.#6128
Merged
lguohan merged 1 commit intosonic-net:masterfrom Dec 4, 2020
Merged
[psu] Fix incorrect file path for voltage, current and power.#6128lguohan merged 1 commit intosonic-net:masterfrom
lguohan merged 1 commit intosonic-net:masterfrom
Conversation
There is a bug in getting the path of voltage, current and power. The list object is directly converted to string to format the file path. As a result, read_txt_file will get None value and a WARNING will be recorded. This commit fix the issue. Signed-off-by: bingwang <bingwang@microsoft.com>
jleveque
approved these changes
Dec 4, 2020
santhosh-kt
pushed a commit
to santhosh-kt/sonic-buildimage
that referenced
this pull request
Feb 25, 2021
…sonic-net#6128) Fixes sonic-net#6126. There is a bug in getting the path of voltage, current and power. The list object is directly converted to string to format the file path. As a result, read_txt_file will get None value and a WARNING will be recorded. This commit fix the issue. Signed-off-by: bingwang <bingwang@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: bingwang bingwang@microsoft.com
- Why I did it
Fixes #6126.
There is a bug in getting the path of voltage, current and power. The list object is directly converted to string to format the file path. As a result,
read_txt_filewill getNonevalue and aWARNINGwill be recorded. This commit fix the issue.- How I did it
Add a
jointo convertlisttostring.- How to verify it
Verified on DX010, and no WARNING is seen after this update.
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
Fix incorrect file path for voltage, current and power.
- A picture of a cute animal (not mandatory but encouraged)