Merged
Conversation
Signed-off-by: Prabhu Sreenivasan <prabhu.sreenivasan@broadcom.com>
PrabhuSreenivasan
pushed a commit
to PrabhuSreenivasan/sonic-buildimage
that referenced
this pull request
Dec 3, 2020
Signed-off-by: Prabhu Sreenivasan <prabhu.sreenivasan@broadcom.com>
lguohan
approved these changes
Dec 3, 2020
jleveque
approved these changes
Dec 3, 2020
4 tasks
santhosh-kt
pushed a commit
to santhosh-kt/sonic-buildimage
that referenced
this pull request
Feb 25, 2021
Make sure ntp-config service is executed before ntpd Updated ntp-config service files to force dependency with ntp service. Also resolved circular dependency with --no-block flag. (needed as ntp-config service internally invokes systemd to restart ntp which in turn waits for ntp-config to complete) Signed-off-by: Prabhu Sreenivasan <prabhu.sreenivasan@broadcom.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Prabhu Sreenivasan prabhu.sreenivasan@broadcom.com
- Why I did it
Make sure ntp-config service is executed before ntpd
- How I did it
Updated ntp-config service files to force dependency with ntp service. Also resolved circular dependency with --no-block flag. (needed as ntp-config service internally invokes systemd to restart ntp which in turn waits for ntp-config to complete)
- How to verify it
Existing ntp pytest.
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
Adjusted the ordering of ntp-config service to run before ntp service.
Avoided circular dependency due to above change with --no-block flag
- A picture of a cute animal (not mandatory but encouraged)