Skip to content

[Barefoot]: fix unresolved SFP type on Newport/Montara#6063

Merged
jleveque merged 1 commit intosonic-net:masterfrom
dmytroxshevchuk:fix_sfp_type_on_newport
Dec 4, 2020
Merged

[Barefoot]: fix unresolved SFP type on Newport/Montara#6063
jleveque merged 1 commit intosonic-net:masterfrom
dmytroxshevchuk:fix_sfp_type_on_newport

Conversation

@dmytroxshevchuk
Copy link
Copy Markdown
Contributor

@dmytroxshevchuk dmytroxshevchuk commented Nov 30, 2020 •
edited
Loading

- Why I did it
show interface status and sfpshow eeprom commands show not correct information about sfp status.
show interface status command result:

admin@sonic:~$ show interfaces status
  Interface            Lanes    Speed    MTU    FEC        Alias    Vlan    Oper    Admin             Type    Asym PFC
-----------  ---------------  -------  -----  -----  -----------  ------  ------  -------  ---------------  ----------
  Ethernet0          0,1,2,3     100G   9100    N/A    Ethernet0  routed    down       up              N/A         N/A
  Ethernet8        8,9,10,11     100G   9100    N/A    Ethernet8  routed    down       up  QSFP28 or later         N/A
 Ethernet16      16,17,18,19     100G   9100    N/A   Ethernet16  routed    down       up  QSFP28 or later         N/A
 Ethernet24      24,25,26,27     100G   9100    N/A   Ethernet24  routed    down       up  QSFP28 or later         N/A

For example sfpshow eeprom show something like this:

admin@sonic:~$ sfpshow eeprom
Ethernet0: SFP EEPROM Not detected

Ethernet8: SFP EEPROM detected
...

Also command sfpshow presence show Not present for Ethernet0

admin@sonic:~$ sfpshow presence
Port         Presence
-----------  -----------
Ethernet0    Not present
Ethernet8    Present
Ethernet16   Present

- How I did it

- How to verify it
After fix must be correct SFP status in show interface status command.
Before:

admin@sonic:~$ show interfaces status
  Interface            Lanes    Speed    MTU    FEC        Alias    Vlan    Oper    Admin             Type    Asym PFC
-----------  ---------------  -------  -----  -----  -----------  ------  ------  -------  ---------------  ----------
  Ethernet0          0,1,2,3     100G   9100    N/A    Ethernet0  routed    down       up              N/A         N/A
  Ethernet8        8,9,10,11     100G   9100    N/A    Ethernet8  routed    down       up  QSFP28 or later         N/A
 Ethernet16      16,17,18,19     100G   9100    N/A   Ethernet16  routed    down       up  QSFP28 or later         N/A
 Ethernet24      24,25,26,27     100G   9100    N/A   Ethernet24  routed    down       up  QSFP28 or later         N/A

After:

admin@sonic:~$ show interfaces status
  Interface            Lanes    Speed    MTU    FEC        Alias    Vlan    Oper    Admin             Type    Asym PFC
-----------  ---------------  -------  -----  -----  -----------  ------  ------  -------  ---------------  ----------
  Ethernet0          0,1,2,3     100G   9100    N/A    Ethernet0  routed    down       up  QSFP28 or later         N/A
  Ethernet8        8,9,10,11     100G   9100    N/A    Ethernet8  routed    down       up  QSFP28 or later         N/A
 Ethernet16      16,17,18,19     100G   9100    N/A   Ethernet16  routed    down       up  QSFP28 or later         N/A
 Ethernet24      24,25,26,27     100G   9100    N/A   Ethernet24  routed    down       up  QSFP28 or later         N/A

Also must be resolved sfpshow eeprom and sfpshow presence commands.

admin@sonic:~$ sfpshow presence
Port         Presence
-----------  ----------
Ethernet0    Present
Ethernet8    Present
Ethernet16   Present

- Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@dmytroxshevchuk dmytroxshevchuk changed the title [sfp]: fix unresolved type on Newport/Montara [sfp]: fix unresolved sfp type on Newport/Montara Nov 30, 2020
@dmytroxshevchuk dmytroxshevchuk changed the title [sfp]: fix unresolved sfp type on Newport/Montara [platform]: fix unresolved sfp type on Newport/Montara Nov 30, 2020
@dmytroxshevchuk dmytroxshevchuk mentioned this pull request Nov 30, 2020
Closed
3 tasks
@akokhan
Copy link
Copy Markdown
Contributor

akokhan commented Dec 1, 2020

retest vsimage please

@dmytroxshevchuk dmytroxshevchuk force-pushed the fix_sfp_type_on_newport branch from da63e52 to 682379e Compare December 1, 2020 13:43
@dmytroxshevchuk dmytroxshevchuk force-pushed the fix_sfp_type_on_newport branch from 682379e to c9c675e Compare December 1, 2020 17:02
@jleveque
Copy link
Copy Markdown
Contributor

jleveque commented Dec 2, 2020

@akokhan: Please review.

@akokhan
Copy link
Copy Markdown
Contributor

akokhan commented Dec 2, 2020

@vboykox , please take a look

@vboykox
Copy link
Copy Markdown
Member

vboykox commented Dec 2, 2020

Approved.

@jleveque
Copy link
Copy Markdown
Contributor

jleveque commented Dec 2, 2020

@dmytroxshevchuk: Can you please add a brief description for this PR?

@dmytroxshevchuk
Copy link
Copy Markdown
Contributor Author

dmytroxshevchuk commented Dec 4, 2020 •
edited
Loading

@dmytroxshevchuk: Can you please add a brief description for this PR?

done
@jleveque please check

@jleveque jleveque changed the title [platform]: fix unresolved sfp type on Newport/Montara [Barefoot]: fix unresolved SFP type on Newport/Montara Dec 4, 2020
@jleveque jleveque merged commit 026f0ec into sonic-net:master Dec 4, 2020
santhosh-kt pushed a commit to santhosh-kt/sonic-buildimage that referenced this pull request Feb 25, 2021
@dmytroxshevchuk @santhosh-kt
[Barefoot]: fix unresolved SFP type on Newport/Montara (sonic-net#6063)
0d99d09 
Fix `show interface status` and `sfpshow eeprom` commands showing incorrect information on Newport/Montara platforms
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akokhan akokhan akokhan approved these changes

@vboykox vboykox vboykox approved these changes

+1 more reviewer

@jleveque jleveque jleveque approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Bug 🐛 Platform: Barefoot

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dmytroxshevchuk @akokhan @jleveque @vboykox