Skip to content

Add teamd as a depedent service to swss#5628

Merged
lguohan merged 8 commits intosonic-net:masterfrom
judyjoseph:teamd_REPAIR
Oct 23, 2020
Merged

Add teamd as a depedent service to swss#5628
lguohan merged 8 commits intosonic-net:masterfrom
judyjoseph:teamd_REPAIR

Conversation

@judyjoseph
Copy link
Copy Markdown
Contributor

@judyjoseph judyjoseph commented Oct 14, 2020 •
edited
Loading

- Why I did it
On teamd docker restart, the swss and syncd needs to be restarted as there are dependent resources present.

- How I did it
Add the teamd as a dependent service for swss
Updated the docker-wait script to handle service and dependent services separately.
Handle the case of warm-restart for the dependent service

- How to verify it

Verified the following scenario's with the following testbed
VM1 ----------------------------[DUT 6100] -----------------------VM2, ping traffic continuous between VMs

  1. Stop teamd docker alone

    swss, syncd dockers seen going away
    The LAG reference count error messages seen for a while till swss docker stops.
    Dockers back up.

  2. Enable WR mode for teamd. Stop teamd docker alone

    swss, syncd dockers not removed.
    The LAG reference count error messages not seen
    Repeated stop teamd docker test - same result, no effect on swss/syncd.

  3. Stop swss docker.

    swss, teamd, syncd goes off - dockers comes back correctly, interfaces up

  4. Enable WR mode for swss . Stop swss docker

    swss goes off not affecting syncd/teamd dockers.

  5. Config reload

    no reference counter error seen, dockers comes back correctly, with interfaces up

  6. Warm reboot, observations below

    swss docker goes off first
    teamd + syncd goes off to the end of WR process.
    dockers comes back up fine.
    ping traffic between VM's was NOT HIT

  7. Fast reboot, observations below

    teamd goes off first ( confirmed swss don't exit here )
    swss goes off next
    syncd goes away at the end of the FR process
    dockers comes back up fine.
    there is a traffic HIT as per fast-reboot

  8. Verified in multi-asic platform, the tests above other than WR/FB scenarios

- Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@lguohan lguohan requested review from jleveque and yxieca October 15, 2020 17:57
jleveque
jleveque reviewed Oct 15, 2020
View reviewed changes
jleveque
jleveque suggested changes Oct 17, 2020
View reviewed changes
@judyjoseph
Copy link
Copy Markdown
Contributor Author

judyjoseph commented Oct 17, 2020 •
edited
Loading

Updated the tests done to verify this fix in the conversation comments

@jleveque jleveque self-requested a review October 17, 2020 01:25
jleveque
jleveque previously approved these changes Oct 17, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@jleveque jleveque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Please wait for other reviewers.

@jleveque jleveque requested a review from lguohan October 17, 2020 01:27
abdosi
abdosi reviewed Oct 18, 2020
View reviewed changes
abdosi
abdosi reviewed Oct 18, 2020
View reviewed changes
@judyjoseph judyjoseph marked this pull request as ready for review October 20, 2020 05:15
@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Oct 20, 2020

This pull request introduces 1 alert when merging 9be883d into 5c5e424 - view on LGTM.com

new alerts:

  • 1 for Syntax error

@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Oct 20, 2020

This pull request introduces 1 alert when merging 9c7c59e into 5c5e424 - view on LGTM.com

new alerts:

  • 1 for Unused import

yxieca
yxieca previously approved these changes Oct 21, 2020
View reviewed changes
@judyjoseph
Copy link
Copy Markdown
Contributor Author

judyjoseph commented Oct 21, 2020

retest vs please

abdosi
abdosi previously approved these changes Oct 21, 2020
View reviewed changes
@judyjoseph judyjoseph dismissed stale reviews from abdosi and yxieca via 82ea642 October 22, 2020 01:27
jleveque
jleveque reviewed Oct 22, 2020
View reviewed changes
@judyjoseph
Copy link
Copy Markdown
Contributor Author

judyjoseph commented Oct 22, 2020

retest mellanox please

@judyjoseph
Copy link
Copy Markdown
Contributor Author

judyjoseph commented Oct 22, 2020

retest mellanox please

@lguohan lguohan merged commit ace7f24 into sonic-net:master Oct 23, 2020
abdosi pushed a commit that referenced this pull request Oct 23, 2020
@judyjoseph @abdosi
[docker-teamd]: Add teamd as a depedent service to swss (#5628)
963bd7f 
**- Why I did it**
On teamd docker restart, the swss and syncd needs to be restarted as there are dependent resources present.

**- How I did it**
Add the teamd as a dependent service for swss
Updated the docker-wait script to handle service and dependent services separately.
Handle the case of warm-restart for the dependent service

**- How to verify it**

Verified the following scenario's with the following testbed
VM1 ----------------------------[DUT 6100] -----------------------VM2,  ping traffic continuous between VMs

1. Stop teamd docker alone
      >  swss, syncd dockers seen going away
      >  The LAG reference count error messages seen for a while till swss docker stops.
      >  Dockers back up.

2. Enable WR mode for teamd. Stop teamd docker alone
      >  swss, syncd dockers not removed.
      >  The LAG reference count error messages not seen
      >  Repeated stop teamd docker test - same result, no effect on swss/syncd.

3. Stop swss docker.
      >  swss, teamd, syncd goes off - dockers comes back correctly, interfaces up

4. Enable WR mode for swss . Stop swss docker
      >  swss goes off not affecting syncd/teamd dockers.

5. Config reload
      > no reference counter error seen, dockers comes back correctly, with interfaces up

6. Warm reboot, observations below
	 > swss docker goes off first
	 > teamd + syncd goes off to the end of WR process.
 	 > dockers comes back up fine.
	 > ping traffic between VM's was NOT HIT

7. Fast reboot, observations below
	 > teamd goes off first ( **confirmed swss don't exit here** )
	 > swss goes off next
	 > syncd goes away at the end of the FR process
	 > dockers comes back up fine.
	 > there is a traffic HIT as per fast-reboot

8. Verified in multi-asic platform, the tests above other than WR/FB scenarios
@judyjoseph judyjoseph mentioned this pull request Jan 11, 2021
Closed
santhosh-kt pushed a commit to santhosh-kt/sonic-buildimage that referenced this pull request Feb 25, 2021
@judyjoseph @santhosh-kt
[docker-teamd]: Add teamd as a depedent service to swss (sonic-net#5628)
088ec49 
**- Why I did it**
On teamd docker restart, the swss and syncd needs to be restarted as there are dependent resources present.

**- How I did it**
Add the teamd as a dependent service for swss
Updated the docker-wait script to handle service and dependent services separately.
Handle the case of warm-restart for the dependent service   

**- How to verify it**

Verified the following scenario's with the following testbed 
VM1 ----------------------------[DUT 6100] -----------------------VM2,  ping traffic continuous between VMs

1. Stop teamd docker alone  
      >  swss, syncd dockers seen going away
      >  The LAG reference count error messages seen for a while till swss docker stops.
      >  Dockers back up.

2. Enable WR mode for teamd. Stop teamd docker alone  
      >  swss, syncd dockers not removed.
      >  The LAG reference count error messages not seen
      >  Repeated stop teamd docker test - same result, no effect on swss/syncd.

3. Stop swss docker. 
      >  swss, teamd, syncd goes off - dockers comes back correctly, interfaces up

4. Enable WR mode for swss . Stop swss docker 
      >  swss goes off not affecting syncd/teamd dockers.

5. Config reload 
      > no reference counter error seen, dockers comes back correctly, with interfaces up

6. Warm reboot, observations below
	 > swss docker goes off first 
	 > teamd + syncd goes off to the end of WR process.
 	 > dockers comes back up fine.
	 > ping traffic between VM's was NOT HIT

7. Fast reboot, observations below
	 > teamd goes off first ( **confirmed swss don't exit here** )
	 > swss goes off next 
	 > syncd goes away at the end of the FR process
	 > dockers comes back up fine.
	 > there is a traffic HIT as per fast-reboot

8. Verified in multi-asic platform, the tests above other than WR/FB scenarios
@judyjoseph judyjoseph deleted the teamd_REPAIR branch March 1, 2022 23:32
@abdosi abdosi mentioned this pull request Mar 2, 2022
Closed
@abdosi abdosi mentioned this pull request Aug 3, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yxieca yxieca yxieca left review comments

@abdosi abdosi abdosi left review comments

@lguohan lguohan Awaiting requested review from lguohan lguohan is a code owner

+1 more reviewer

@jleveque jleveque jleveque approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Included in 201911 Branch Request for 201911 Branch :shipit:

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@judyjoseph @jleveque @yxieca @abdosi @lguohan