[docker-ptf]replace ping utility from inetutils-ping to iputils-ping by maggiemsft · Pull Request #523 · sonic-net/sonic-buildimage

maggiemsft · 2017-04-20T21:10:26Z

the inetutils-ping does not have source interface '-I' option

stcheng · 2017-04-20T21:14:49Z

dockers/docker-ptf/Dockerfile.j2

    && wget https://raw.githubusercontent.com/p4lang/ptf/master/ptf_nn/ptf_nn_agent.py
+    && wget https://launchpadlibrarian.net/265451319/iputils-ping_20150815-2ubuntu3_amd64.deb
+    && dpkg -r inetutils-ping
+    && dpkg -i dpkg -i iputils-ping_20150815-2ubuntu3_amd64.deb


two dpkg -i ?

sharp eye, thank you!

lguohan · 2017-04-20T21:25:15Z

dockers/docker-ptf/Dockerfile.j2

    && wget https://raw.githubusercontent.com/p4lang/ptf/master/ptf_nn/ptf_nn_agent.py
+    && wget https://launchpadlibrarian.net/265451319/iputils-ping_20150815-2ubuntu3_amd64.deb
+    && dpkg -r inetutils-ping
+    && dpkg -i iputils-ping_20150815-2ubuntu3_amd64.deb


why not use apt-get iptuils-ping

jleveque · 2017-04-28T18:14:14Z

dockers/docker-ptf/Dockerfile.j2

-        libqt5network5
+        libqt5network5      \
+    && dpkg -r inetutils-ping \
+    && apt-get install -y iputils-ping


Now that we're squashing dockers, this would be cleaner if broken out into a separate RUN dpkg -r inetutils-ping statement. Thoughts?

I think we can do dpkg -r inetutils-ping before line 15, and then attach iptuils-ping here.

thank you for the recommandation

stcheng · 2017-05-01T22:25:42Z

dockers/docker-ptf/Dockerfile.j2

        libqt5core5a        \
-        libqt5network5
+        libqt5network5      \
+        iputils-ping


so it will replace the old one?

maggiemsft · 2017-05-02T01:43:34Z

I locally built the docker image and loaded and start in my local docker machine. Look like it was building correctly with the new package.

root@85d6dcf4b6f4:/# dpkg -l | grep ping
ii iputils-ping 3:20121221-5+b2 amd64 Tools to test the reachability of network hosts
root@85d6dcf4b6f4:/# ping
Usage: ping [-aAbBdDfhLnOqrRUvV] [-c count] [-i interval] [-I interface]
[-m mark] [-M pmtudisc_option] [-l preload] [-p pattern] [-Q tos]
[-s packetsize] [-S sndbuf] [-t ttl] [-T timestamp_option]
[-w deadline] [-W timeout] [hop1 ...] destination

My local machine ping package is:
masun@masun-vm0:~/sonic/sonic-buildimage/target$ dpkg -l |grep ping
ii iputils-ping 3:20150815-2ubuntu3 amd64 Tools to test the reachability of network hosts
so I assume it was build correctly.

stcheng · 2017-05-02T02:28:54Z

thanks

* Allocate buffer for 256 entries for ACL resource query * Changed to MACRO

> Add a new field for FLEX_COUNTER_TABLE to indicate delay for flex counters (sonic-net#523) > [logger] Make map access thread safe and proper terminate thread (sonic-net#510) > Test with coverage output, publish gcov on Azure pipelines (sonic-net#517) > Update schema.h to include config_db DHCP and state_db counter table (sonic-net#521) > [schema] Add next hop group table to schema (sonic-net#475) > Fix: DBInterface::get() return nullable strings (sonic-net#516) > [netlink]refill netlink cache when failing to get the link object by name. (sonic-net#506) > Fix test_ConfigDBSubscribe timing risk (sonic-net#512) > added missing headers for building with gcc-10.3 (sonic-net#494) > Modify the hardcode separator ":" to variable. (sonic-net#473)

508202b 2021-08-24 Add a new field for FLEX_COUNTER_TABLE to indicate delay for flex counters (#523) 9fd7dbf 2021-08-20 [logger] Make map access thread safe and proper terminate thread (#510) e4c3d0b 2021-08-20 Test with coverage output, publish gcov on Azure pipelines (#517) ef21bec 2021-08-18 Update schema.h to include config_db DHCP and state_db counter table (#521) 4e4eb9d 2021-08-19 [schema] Add next hop group table to schema (#475) Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com>

sonic-swss 73f6f68 [Flex Counters] Delay flex counters even if tables are present in the DB (#1877) 5edb9e5 [buffer orch] Bugfix: Don't query counter SAI_BUFFER_POOL_STAT_XOFF_ROOM_WATERMARK_BYTES on a pool where it is not supported (#1857) fce0c60 [crm] Fix for Issue #8036 (#1829) sonic-utilities 2630ac1 [Fast-reboot] Set flex counters delay indicator to prevent flex counters enablement after fast-reboot (#1768) 606f1b1 [portstat pfcstat] Unify the packet number format in the output of portstat and pfcstat in all cases (#1755) 2c6a15e [ecnconfig] Fix exception seen during display and add unit tests (#1784) 9b1995e Fix logic in RIF counters print (#1732) sonic-swss-comon 3e7b81f Add a new field for FLEX_COUNTER_TABLE to indicate delay for flex counters (#523)

… automatically (#21217) #### Why I did it src/sonic-platform-common ``` * 9ca0f69 - (HEAD -> master, origin/master, origin/HEAD) Update azure pipeline to use Bookworm (#523) (13 hours ago) [Saikrishna Arcot] ``` #### How I did it #### How to verify it #### Description for the changelog

… automatically (sonic-net#21217) #### Why I did it src/sonic-platform-common ``` * 9ca0f69 - (HEAD -> master, origin/master, origin/HEAD) Update azure pipeline to use Bookworm (sonic-net#523) (13 hours ago) [Saikrishna Arcot] ``` #### How I did it #### How to verify it #### Description for the changelog

Fix conflict in .gitmodule when merging 202411 branch.

…lly (#24314) #### Why I did it src/sonic-gnmi ``` * 072f3a4 - (HEAD -> master, origin/master, origin/HEAD) gNOI file remove: add handler & tests; update builder and main (#520) (28 hours ago) [ravaliyel] * d79245b - Implements complete firmware file listing through gNMI interface with… (#523) (29 hours ago) [v-cshekar] ``` #### How I did it #### How to verify it #### Description for the changelog

…lly (sonic-net#24314) #### Why I did it src/sonic-gnmi ``` * 072f3a4 - (HEAD -> master, origin/master, origin/HEAD) gNOI file remove: add handler & tests; update builder and main (sonic-net#520) (28 hours ago) [ravaliyel] * d79245b - Implements complete firmware file listing through gNMI interface with… (sonic-net#523) (29 hours ago) [v-cshekar] ``` #### How I did it #### How to verify it #### Description for the changelog Signed-off-by: Feng Pan <fenpan@microsoft.com>

Signed-off-by: Stephen Sun <stephens@nvidia.com>

…tomatically (#24990) #### Why I did it src/sonic-linux-kernel ``` * e7fea60 - (HEAD -> master, origin/master, origin/HEAD) update docker slave name (#523) (3 days ago) [yijingyan2] * b363a5b - Add tpm_tis_i2c driver module for arm64 (#524) (3 days ago) [Pavan Prakash] ``` #### How I did it #### How to verify it #### Description for the changelog

…tomatically (sonic-net#24990) #### Why I did it src/sonic-linux-kernel ``` * e7fea60 - (HEAD -> master, origin/master, origin/HEAD) update docker slave name (sonic-net#523) (3 days ago) [yijingyan2] * b363a5b - Add tpm_tis_i2c driver module for arm64 (sonic-net#524) (3 days ago) [Pavan Prakash] ``` #### How I did it #### How to verify it #### Description for the changelog

…tomatically (sonic-net#24990) #### Why I did it src/sonic-linux-kernel ``` * e7fea60 - (HEAD -> master, origin/master, origin/HEAD) update docker slave name (sonic-net#523) (3 days ago) [yijingyan2] * b363a5b - Add tpm_tis_i2c driver module for arm64 (sonic-net#524) (3 days ago) [Pavan Prakash] ``` #### How I did it #### How to verify it #### Description for the changelog Signed-off-by: Feng Pan <fenpan@microsoft.com>

…tomatically (#24990) #### Why I did it src/sonic-linux-kernel ``` * e7fea60 - (HEAD -> master, origin/master, origin/HEAD) update docker slave name (#523) (3 days ago) [yijingyan2] * b363a5b - Add tpm_tis_i2c driver module for arm64 (#524) (3 days ago) [Pavan Prakash] ``` #### How I did it #### How to verify it #### Description for the changelog Signed-off-by: dprital <drorp@nvidia.com>

replace ping utility from inetutil-ping to iputils-ping

f451276

stcheng suggested changes Apr 20, 2017

View reviewed changes

stcheng added the Enhancement ➕ label Apr 20, 2017

stcheng assigned maggiemsft Apr 20, 2017

fix dup typo

91abe70

lguohan reviewed Apr 20, 2017

View reviewed changes

stcheng approved these changes Apr 27, 2017

View reviewed changes

change from package installing to using apt install

c1128d1

jleveque reviewed Apr 28, 2017

View reviewed changes

maggiemsft changed the title ~~replace ping utility from inetutils-ping to iputils-ping~~ [docker-ptf]replace ping utility from inetutils-ping to iputils-ping May 1, 2017

remove unnecessary package handling line

42ea13f

lguohan approved these changes May 1, 2017

View reviewed changes

stcheng reviewed May 1, 2017

View reviewed changes

maggiemsft merged commit 4dfe2a2 into sonic-net:master May 2, 2017

maggiemsft deleted the masun/replace_ping_util branch July 18, 2017 17:33

madhanmellanox pushed a commit to madhanmellanox/sonic-buildimage that referenced this pull request Mar 23, 2020

Allocate buffer for 256 entries for ACL resource query (sonic-net#523)

6189eaa

* Allocate buffer for 256 entries for ACL resource query * Changed to MACRO

shlomibitton mentioned this pull request Aug 24, 2021

[sonic-swss-common] submodule update #8565

Merged

TACappleman mentioned this pull request Aug 24, 2021

Updating sonic-swss-common submodule #8566

Closed

5 tasks

stepanblyschak pushed a commit to stepanblyschak/sonic-buildimage that referenced this pull request Jan 27, 2025

Merge pull request sonic-net#523 from Azure/lslmerge202411

e873cac

Fix conflict in .gitmodule when merging 202411 branch.

yuazhe pushed a commit to yuazhe/sonic-buildimage that referenced this pull request Dec 8, 2025

Add shared headroom pool parameters for headroom check (sonic-net#523)

ff4b2a2

Signed-off-by: Stephen Sun <stephens@nvidia.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[docker-ptf]replace ping utility from inetutils-ping to iputils-ping#523

[docker-ptf]replace ping utility from inetutils-ping to iputils-ping#523
maggiemsft merged 4 commits intosonic-net:masterfrom
maggiemsft:masun/replace_ping_util

maggiemsft commented Apr 20, 2017

Uh oh!

stcheng Apr 20, 2017

Uh oh!

maggiemsft Apr 20, 2017

Uh oh!

lguohan Apr 20, 2017

Uh oh!

jleveque Apr 28, 2017

Uh oh!

lguohan Apr 29, 2017

Uh oh!

maggiemsft May 1, 2017

Uh oh!

stcheng May 1, 2017

Uh oh!

maggiemsft commented May 2, 2017

Uh oh!

stcheng commented May 2, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

maggiemsft commented Apr 20, 2017

Uh oh!

stcheng Apr 20, 2017

Choose a reason for hiding this comment

Uh oh!

maggiemsft Apr 20, 2017

Choose a reason for hiding this comment

Uh oh!

lguohan Apr 20, 2017

Choose a reason for hiding this comment

Uh oh!

jleveque Apr 28, 2017

Choose a reason for hiding this comment

Uh oh!

lguohan Apr 29, 2017

Choose a reason for hiding this comment

Uh oh!

maggiemsft May 1, 2017

Choose a reason for hiding this comment

Uh oh!

stcheng May 1, 2017

Choose a reason for hiding this comment

Uh oh!

maggiemsft commented May 2, 2017

Uh oh!

stcheng commented May 2, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants