[docker-platform-monitor] Fix copy of fancontrol config file#5037
Merged
lguohan merged 1 commit intosonic-net:masterfrom Jul 28, 2020
jleveque:fix_fancontrol
Merged
[docker-platform-monitor] Fix copy of fancontrol config file#5037lguohan merged 1 commit intosonic-net:masterfrom jleveque:fix_fancontrol
lguohan merged 1 commit intosonic-net:masterfrom
jleveque:fix_fancontrol
Conversation
Contributor
Author
|
@zzhiyuan: Please review, as well. Thanks! |
Contributor
|
LGTM |
lguohan
approved these changes
Jul 28, 2020
lguohan
pushed a commit
that referenced
this pull request
Aug 16, 2020
Copy proper fancontrol config file to the proper destination. Also some minor refactoring for code reuse to help prevent issues like this in the future. Fixes a bug introduced by #4599
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copy proper fancontrol config file to the proper destination. Also some minor refactoring for code reuse to help prevent issues like this in the future.
Fixes a bug introduced by #4599