[bgpcfgd] Add fix to not require NEIGHBOR_METADATA entries for dynamic peers#5008
Merged
lguohan merged 1 commit intosonic-net:masterfrom Jul 21, 2020
Merged
Conversation
pavel-shirshov
approved these changes
Jul 20, 2020
Contributor
|
retest baseimage please |
abdosi
pushed a commit
that referenced
this pull request
Jul 26, 2020
… dynamic peers (#5008) This fix removes the requirement to have a NEIGHBOR_METADATA for dynamic peers. The change is made since it is not necessary for NEIGHBOR_METADATA entries be present for the dynamic neighbors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- Why I did it
Fix for #4972
This fix removes the requirement to have a NEIGHBOR_METADATA for dynamic peers. The change is made since it is not necessary for NEIGHBOR_METADATA entries be present for the dynamic neighbors
- How I did it
Changed bgpcfgd to limit checks for neigh_meta to dynamic peers
- How to verify it
Verified on DUT by creating a dynamic peer without NEIGHBOR_METADATA entries and ensure that bgpcfgd allows the creation of this dynamic peer in the FRR BGP config.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)