[rules/sonic-utilities.mk]: Add libyang as build time dependencies fo…#4850
Merged
lguohan merged 1 commit intosonic-net:masterfrom Jun 25, 2020
Merged
Conversation
…r sonic-utilities. sonic-utils has sonic-yang-mgmt as build time deps, which inturn installs libyang. libyang is needed to run newly added test. If sonic-yang-mgmt is already built then libyang will not be installed in slave docker without this PR and test will not run. Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com
lguohan
approved these changes
Jun 25, 2020
Collaborator
lguohan
left a comment
There was a problem hiding this comment.
@praveen-li , please book an issue to fix the build cache issue.
Collaborator
|
according to the log here, https://sonic-jenkins.westus2.cloudapp.azure.com/job/vs/job/buildimage-vs-image-pr/4498/artifact/target/python-debs/python-sonic-utilities_1.2-1_all.deb.log it newly added deb_depends are not added to cache dependency. |
pjaipakdee19
pushed a commit
to pjaipakdee19/sonic-buildimage
that referenced
this pull request
Jul 7, 2020
…r sonic-utilities. (sonic-net#4850) sonic-utils has sonic-yang-mgmt as build time deps, which inturn installs libyang. libyang is needed to run newly added test. If sonic-yang-mgmt is already built then libyang will not be installed in slave docker without this PR and test will not run. Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…r sonic-utilities.
sonic-utils has sonic-yang-mgmt as build time deps, which inturn installs libyang.
libyang is needed to run newly added test.
If sonic-yang-mgmt is already built then libyang will not be installed in slave docker
without this PR and test will not run.
Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com
- Why I did it
Add libyang as build time dependencies for sonic-utils.
Why needed:
sonic-utils has sonic-yang-mgmt as build time deps, which inturn installs libyang.
libyang is needed to run newly added test.
If sonic-yang-mgmt is already built then libyang will not be installed in slave docker
without this PR and test will not run.
Below error will be seen.
- How I did it
Add libyang as build time dependencies for sonic-utils.
- How to verify it
Built the PKG with pre-built sonic-yang-mgmt PKGs.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)