Fix bug: check port alias even when port_config_file parameter is not provided#4787
Merged
qiluo-msft merged 1 commit intosonic-net:masterfrom Jun 17, 2020
Merged
Conversation
lguohan
approved these changes
Jun 16, 2020
jleveque
approved these changes
Jun 16, 2020
Request for 201911 Branch
Bug 🐛
and removed
Bug 🐛
labels
Collaborator
|
retest broadcom please |
qiluo-msft
added a commit
that referenced
this pull request
Jun 18, 2020
abdosi
pushed a commit
that referenced
this pull request
Jun 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parse_xml will accept a parameter port_config_file which includes port_name <-> alias mapping. However if this parameter is not provided, it will search the file in a candidate list and find the mapping. So don't depend on the parameter to when checking alias.