[sonic-sairedis][sonic-swss-common] Update submodules#4708
Closed
smaheshm wants to merge 38 commits intosonic-net:masterfrom
smaheshm:sairedis
Closed
[sonic-sairedis][sonic-swss-common] Update submodules#4708smaheshm wants to merge 38 commits intosonic-net:masterfrom smaheshm:sairedis
smaheshm wants to merge 38 commits intosonic-net:masterfrom
smaheshm:sairedis
Conversation
Signed-off-by: Volodymyr Samotiy <volodymyrs@mellanox.com>
[Mellanox] Update SAI (release:v1.16.3; API:v1.6)
… 1.16.3 (API:v1.6) Signed-off-by: Volodymyr Samotiy <volodymyrs@mellanox.com>
[Mellanox] Update SDK to 4.4.0914 and FW to xx.2007.1112 to match SAI…
Signed-off-by: Volodymyr Samotiy <volodymyrs@mellanox.com>
[Mellanox] Update SAI (release:v1.16.3.2; API:v1.6)
…o undid the previous change'
Collaborator
|
You may need advance sonic-swss-common |
qiluo-msft
previously approved these changes
Jun 5, 2020
jleveque
suggested changes
Jun 5, 2020
Contributor
jleveque
left a comment
There was a problem hiding this comment.
Mellanox build failed:
21:50:14 configure: error: libthrift is required for rpcserver
21:50:14 Makefile:367: recipe for target 'config.status' failed
21:50:14 make[2]: *** [config.status] Error 1
21:50:14 make[2]: Leaving directory '/sonic/src/sonic-sairedis'
21:50:14 dh_auto_clean: make -j16 distclean returned exit code 2
21:50:14 debian/rules:37: recipe for target 'binary-syncd' failed
21:50:14 make[1]: *** [binary-syncd] Error 2
21:50:14 make[1]: Leaving directory '/sonic/src/sonic-sairedis'
21:50:14 dpkg-buildpackage: error: fakeroot debian/rules binary-syncd gave error exit status 2
21:50:14 [ FAIL LOG END ] [ target/debs/stretch/libsairedis_1.0.0_amd64.deb ]
Contributor
Author
checking. |
Contributor
Author
|
retest vsimage please |
Contributor
Author
|
retest mellanox please |
Collaborator
|
|
Collaborator
|
Retest mellanox please |
Contributor
Author
|
retest vsimage please |
Collaborator
|
why they are 28 commits. can you rebase and push? |
… dependency in the package" This reverts commit 18901c2.
Collaborator
|
your rebase does not work, I would expect to see only 1 or 2 commits after you rebase |
Collaborator
|
retest mellanox please |
qiluo-msft
approved these changes
Jun 7, 2020
Contributor
Author
|
retest vsimage please |
Contributor
Author
|
Closing this in favor of PR #4722 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- Why I did it
Linker error when compiling with ENABLE_SYNCD_RPC. Fix is in SAI repo.
- How I did it
Moved variable declaration to object file included in librpcserver.a
- How to verify it
compile with 'ENABLE_SYNCD_RPC" flag enabled.
- Description for the changelog
[sonic-sairedis]
update submodule to include SAI1.6.1.
[MultiDB] use get API to obtain dbid instead of hardcode value (#618) …
dzhangalibaba
Add synchronous mode to sairedis library (#617) …
kcudnik
[meta] Fix tests to be backward compatible (#619)
kcudnik
[sonic-swss-common]
EVPN VXLAN DB support (#339) …
srj102
tapashdas
Add modifyRedis flag to consumer table object (#344) …
kcudnik
Fix memory leak in pyext when Selectable is returned to Python (#343) …
pavel-shirshov
- A picture of a cute animal (not mandatory but encouraged)