Skip to content

[Mellanox] Never disable kernel thermal algorithm at real-time#4638

Merged
jleveque merged 2 commits intosonic-net:masterfrom
Junchao-Mellanox:never-dis-thermal
May 26, 2020
Merged

[Mellanox] Never disable kernel thermal algorithm at real-time#4638
jleveque merged 2 commits intosonic-net:masterfrom
Junchao-Mellanox:never-dis-thermal

Conversation

@Junchao-Mellanox
Copy link
Copy Markdown
Collaborator

- Why I did it

Since we will reset fan speed vector in user space, it is safe to run kernel algorithm and SONiC thermal control at the same time. So there is no need to enable/disable thermal algorithm at real-time.

- How I did it

  1. Remove all thermal actions related to start/stop thermal algorithm
  2. Add a new action "ThermalRecoverAction" for policy when all fan/PSU are in good state

- How to verify it

Manual test and regression.

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Copy link
Copy Markdown
Collaborator

@liat-grozovik liat-grozovik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Junchao-Mellanox just to be sure, this 2700 file is used for ALL mellanox platforms, right?

@liat-grozovik liat-grozovik requested a review from keboliu May 26, 2020 14:06
@jleveque jleveque merged commit e25c2d9 into sonic-net:master May 26, 2020
@abdosi
Copy link
Copy Markdown
Contributor

abdosi commented May 28, 2020

@Junchao-Mellanox Create pr for 201911. Cherry-pick has conflict.

@rlhui @liat-grozovik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants