Skip to content

[boot0]:remove no need files before extract image#460

Merged
lguohan merged 3 commits intosonic-net:masterfrom
sihuihan88:dev/sihan/cleanFile
Apr 1, 2017
Merged

[boot0]:remove no need files before extract image#460
lguohan merged 3 commits intosonic-net:masterfrom
sihuihan88:dev/sihan/cleanFile

Conversation

@sihuihan88
Copy link
Copy Markdown
Contributor

@sihuihan88 sihuihan88 commented Mar 30, 2017

Signed-off-by: Sihui Han sihan@microsoft.com

[Aboot]:remove no need files before extract image
c548592 
Signed-off-by: Sihui Han <sihan@microsoft.com>
@pavel-shirshov
Copy link
Copy Markdown
Contributor

pavel-shirshov commented Mar 30, 2017

Why old code doesn't work anymore for us? Why do we need a new one?

Also `` (backticks) outdated, it's better to use $() for this.

@sihuihan88
Copy link
Copy Markdown
Contributor Author

sihuihan88 commented Mar 30, 2017

When we convert the arista device to sonic, there is a disk space issue since the old code can only remove the rw and docker folders but not the files related to arista. After discussed with Guohan, he suggests to remove all the no need files before extracting the image.

lguohan
lguohan reviewed Mar 30, 2017
View reviewed changes
files/Aboot/boot0.j2 Outdated
rm -rf "$target_path/{{ DOCKERFS_DIR }}"
## Remove all the other unnecssary files except swi file, boot-config and boot0
for f in `ls -A $target_path`; do
if [ $f != "${swipath##*/}" ] && [ $f != "boot-config" ] && [ $f != "boot0" ]; then
Copy link
Copy Markdown
Collaborator

@lguohan lguohan Mar 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to preserve boot0? boot0 is embedded in the swi file.

Copy link
Copy Markdown
Contributor Author

@sihuihan88 sihuihan88 Mar 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. If so, we don't need to preserve it here. Was thinking it locates in /mnt/flash lol.

Sihui Han added 2 commits March 30, 2017 20:12
use and remove boot0 in the check
4df5e5d 
Signed-off-by: Sihui Han <sihan@microsoft.com>
change the comments accordingly
a542028 
Signed-off-by: Sihui Han <sihan@microsoft.com>
@lguohan lguohan merged commit 5c8bcef into sonic-net:master Apr 1, 2017
@sihuihan88 sihuihan88 deleted the dev/sihan/cleanFile branch April 3, 2017 17:22
yxieca added a commit to yxieca/sonic-buildimage that referenced this pull request Feb 21, 2019
@yxieca
[201811 submodules] advance sairedis, swss, swss-common, utilities
2d606f4 
Submodule src/sonic-sairedis d57222a..54b02a1:
  > Add support for fdb_event MOVE and check fdb event oids (sonic-net#420)
  > [vslib] add missing port attributes for virtual switch (sonic-net#419)

Submodule src/sonic-swss 584490c..62e2a20:
  > [fdborch] Store vlan id of FDB entry instead of port pvid into stateD… (sonic-net#759)
  > [portsorch] Change speed set flow (sonic-net#764)
  > Create egress ACL table group during the PFCWD stats list installment (sonic-net#787)

Submodule src/sonic-swss-common 286ef34..2592b0c:
  > Add support for WarmStart::setDataCheckState() (sonic-net#242)

Submodule src/sonic-utilities b44b462..d409987:
  > [sonic_installer] Improve error handling (sonic-net#460)
  > [clock] sync os time to CMOS before rebooting (sonic-net#465)
  > [intfstat] add intfstat script to output RIF counters (sonic-net#439)

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
@yxieca yxieca mentioned this pull request Feb 21, 2019
Merged
yxieca added a commit to yxieca/sonic-buildimage that referenced this pull request Feb 21, 2019
@yxieca
[201811 utilties] add 201811 branch for sonic-utilities repo
6809e34 
Submodule src/sonic-utilities d409987...ff1448c:
  > [sonic_installer] Improve error handling (sonic-net#460)
  > [clock] sync os time to CMOS before rebooting (sonic-net#465)
  < [sonic_installer] Improve error handling (sonic-net#460)
  < [clock] sync os time to CMOS before rebooting (sonic-net#465)
  < [intfstat] add intfstat script to output RIF counters (sonic-net#439)

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
yxieca added a commit that referenced this pull request Feb 22, 2019
@yxieca
[201811 submodules] advance sairedis, swss, swss-common, utilities (#…
1d11b95 
…2594)

* [201811 submodules] advance sairedis, swss, swss-common, utilities

Submodule src/sonic-sairedis d57222a..54b02a1:
  > Add support for fdb_event MOVE and check fdb event oids (#420)
  > [vslib] add missing port attributes for virtual switch (#419)

Submodule src/sonic-swss 584490c..62e2a20:
  > [fdborch] Store vlan id of FDB entry instead of port pvid into stateD… (#759)
  > [portsorch] Change speed set flow (#764)
  > Create egress ACL table group during the PFCWD stats list installment (#787)

Submodule src/sonic-swss-common 286ef34..2592b0c:
  > Add support for WarmStart::setDataCheckState() (#242)

Submodule src/sonic-utilities b44b462..d409987:
  > [sonic_installer] Improve error handling (#460)
  > [clock] sync os time to CMOS before rebooting (#465)
  > [intfstat] add intfstat script to output RIF counters (#439)

Signed-off-by: Ying Xie <ying.xie@microsoft.com>

* [201811 utilties] add 201811 branch for sonic-utilities repo

Submodule src/sonic-utilities d409987...ff1448c:
  > [sonic_installer] Improve error handling (#460)
  > [clock] sync os time to CMOS before rebooting (#465)
  < [sonic_installer] Improve error handling (#460)
  < [clock] sync os time to CMOS before rebooting (#465)
  < [intfstat] add intfstat script to output RIF counters (#439)

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
tiantianlv pushed a commit to SONIC-DEV/sonic-buildimage that referenced this pull request Apr 10, 2019
@yxieca @tiantianlv
[201811 submodules] advance sairedis, swss, swss-common, utilities (s…
617f3d0 
…onic-net#2594)

* [201811 submodules] advance sairedis, swss, swss-common, utilities

Submodule src/sonic-sairedis d57222a..54b02a1:
  > Add support for fdb_event MOVE and check fdb event oids (sonic-net#420)
  > [vslib] add missing port attributes for virtual switch (sonic-net#419)

Submodule src/sonic-swss 584490c..62e2a20:
  > [fdborch] Store vlan id of FDB entry instead of port pvid into stateD… (sonic-net#759)
  > [portsorch] Change speed set flow (sonic-net#764)
  > Create egress ACL table group during the PFCWD stats list installment (sonic-net#787)

Submodule src/sonic-swss-common 286ef34..2592b0c:
  > Add support for WarmStart::setDataCheckState() (#242)

Submodule src/sonic-utilities b44b462..d409987:
  > [sonic_installer] Improve error handling (sonic-net#460)
  > [clock] sync os time to CMOS before rebooting (sonic-net#465)
  > [intfstat] add intfstat script to output RIF counters (sonic-net#439)

Signed-off-by: Ying Xie <ying.xie@microsoft.com>

* [201811 utilties] add 201811 branch for sonic-utilities repo

Submodule src/sonic-utilities d409987...ff1448c:
  > [sonic_installer] Improve error handling (sonic-net#460)
  > [clock] sync os time to CMOS before rebooting (sonic-net#465)
  < [sonic_installer] Improve error handling (sonic-net#460)
  < [clock] sync os time to CMOS before rebooting (sonic-net#465)
  < [intfstat] add intfstat script to output RIF counters (sonic-net#439)

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
tiantianlv pushed a commit to SONIC-DEV/sonic-buildimage that referenced this pull request Apr 10, 2019
@yxieca @tiantianlv
[201811 submodules] advance sairedis, swss, swss-common, utilities (s…
c4cd84f 
…onic-net#2594)

* [201811 submodules] advance sairedis, swss, swss-common, utilities

Submodule src/sonic-sairedis d57222a..54b02a1:
  > Add support for fdb_event MOVE and check fdb event oids (sonic-net#420)
  > [vslib] add missing port attributes for virtual switch (sonic-net#419)

Submodule src/sonic-swss 584490c..62e2a20:
  > [fdborch] Store vlan id of FDB entry instead of port pvid into stateD… (sonic-net#759)
  > [portsorch] Change speed set flow (sonic-net#764)
  > Create egress ACL table group during the PFCWD stats list installment (sonic-net#787)

Submodule src/sonic-swss-common 286ef34..2592b0c:
  > Add support for WarmStart::setDataCheckState() (#242)

Submodule src/sonic-utilities b44b462..d409987:
  > [sonic_installer] Improve error handling (sonic-net#460)
  > [clock] sync os time to CMOS before rebooting (sonic-net#465)
  > [intfstat] add intfstat script to output RIF counters (sonic-net#439)

Signed-off-by: Ying Xie <ying.xie@microsoft.com>

* [201811 utilties] add 201811 branch for sonic-utilities repo

Submodule src/sonic-utilities d409987...ff1448c:
  > [sonic_installer] Improve error handling (sonic-net#460)
  > [clock] sync os time to CMOS before rebooting (sonic-net#465)
  < [sonic_installer] Improve error handling (sonic-net#460)
  < [clock] sync os time to CMOS before rebooting (sonic-net#465)
  < [intfstat] add intfstat script to output RIF counters (sonic-net#439)

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
tiantianlv pushed a commit to SONIC-DEV/sonic-buildimage that referenced this pull request Apr 10, 2019
@yxieca @tiantianlv
[201811 submodules] advance sairedis, swss, swss-common, utilities (s…
60f0f4e 
…onic-net#2594)

* [201811 submodules] advance sairedis, swss, swss-common, utilities

Submodule src/sonic-sairedis d57222a..54b02a1:
  > Add support for fdb_event MOVE and check fdb event oids (sonic-net#420)
  > [vslib] add missing port attributes for virtual switch (sonic-net#419)

Submodule src/sonic-swss 584490c..62e2a20:
  > [fdborch] Store vlan id of FDB entry instead of port pvid into stateD… (sonic-net#759)
  > [portsorch] Change speed set flow (sonic-net#764)
  > Create egress ACL table group during the PFCWD stats list installment (sonic-net#787)

Submodule src/sonic-swss-common 286ef34..2592b0c:
  > Add support for WarmStart::setDataCheckState() (#242)

Submodule src/sonic-utilities b44b462..d409987:
  > [sonic_installer] Improve error handling (sonic-net#460)
  > [clock] sync os time to CMOS before rebooting (sonic-net#465)
  > [intfstat] add intfstat script to output RIF counters (sonic-net#439)

Signed-off-by: Ying Xie <ying.xie@microsoft.com>

* [201811 utilties] add 201811 branch for sonic-utilities repo

Submodule src/sonic-utilities d409987...ff1448c:
  > [sonic_installer] Improve error handling (sonic-net#460)
  > [clock] sync os time to CMOS before rebooting (sonic-net#465)
  < [sonic_installer] Improve error handling (sonic-net#460)
  < [clock] sync os time to CMOS before rebooting (sonic-net#465)
  < [intfstat] add intfstat script to output RIF counters (sonic-net#439)

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
@stcheng stcheng mentioned this pull request Jun 12, 2019
Merged
stcheng pushed a commit to stcheng/sonic-buildimage that referenced this pull request Jun 13, 2019
[swss]: Update swss submodules change
ae2f7f5 
sonic-swss:
[vnet]: Extend Bitmap VNET test with "remove" flows (sonic-net#900)
[vxlanorch] Ambiguous return code for removeNextHopTunnel (sonic-net#880)
Address review comment: remove data member m_entriesCreated, which is introduced for dependancy resolution purpose. (sonic-net#839)
Set LAG mtu value based on kernel netlink msg (sonic-net#922)
[orchagent]: Remove try/catch for correct coredump file (sonic-net#790)
[aclorch] unittest by gtest (sonic-net#924)
[orchagent]: Added support of PFC WD for BFN platform (sonic-net#823)
[vnetorch]: Fix tunnel route removal flow for bitmap VNET (sonic-net#912)
pkill -9 zebra for frr warm restart VS test fix (sonic-net#927)
swss-orchagent: add new orch for vnet routes/tunnel routes tables in CONFIG_DB  (sonic-net#907)
[debian]: Do not build test when building with real SAI (sonic-net#932)

sonic-swss-common:
Add schema for dot1p to tc mapping config table (sonic-net#274)
Fix MIRROR_SESSION table macro name (sonic-net#264)
[schema] Add VNET Route tables in config_db (sonic-net#279)
[debian] increment debian compatibility to 10 to enable parallel package build (sonic-net#280)
White-list clear_stats op from orchagent to syncd (sonic-net#281)
Correct comment (sonic-net#282)

sonic-sairedis:
[debian]: Change build order in target binary (sonic-net#452)
[debian] increment debian compatibility to 10 to enable parallel package build (sonic-net#461)
Full sleep wait flex counter polling thread when POLL_COUNTER_STATUS is disable (sonic-net#462)
add support for SAI_ATTR_VALUE_TYPE_ACL_CAPABILITY (sonic-net#460)
Check if port VID exists in db on flex counter query (sonic-net#464)
Full sleep wait change for PFC watchdog (sonic-net#465)
Add synchronous clear_stats operation path (sonic-net#463)
Modify sai_create_port to breakout a port for virtual switch (sonic-net#454)
Fix typo  (sonic-net#467)

Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
stcheng pushed a commit that referenced this pull request Jun 14, 2019
[swss]: Update swss submodules change (#2995)
f8a4efc 
sonic-swss:
[vnet]: Extend Bitmap VNET test with "remove" flows (#900)
[vxlanorch] Ambiguous return code for removeNextHopTunnel (#880)
Address review comment: remove data member m_entriesCreated, which is introduced for dependancy resolution purpose. (#839)
Set LAG mtu value based on kernel netlink msg (#922)
[orchagent]: Remove try/catch for correct coredump file (#790)
[aclorch] unittest by gtest (#924)
[orchagent]: Added support of PFC WD for BFN platform (#823)
[vnetorch]: Fix tunnel route removal flow for bitmap VNET (#912)
pkill -9 zebra for frr warm restart VS test fix (#927)
swss-orchagent: add new orch for vnet routes/tunnel routes tables in CONFIG_DB  (#907)
[debian]: Do not build test when building with real SAI (#932)

sonic-swss-common:
Add schema for dot1p to tc mapping config table (#274)
Fix MIRROR_SESSION table macro name (#264)
[schema] Add VNET Route tables in config_db (#279)
[debian] increment debian compatibility to 10 to enable parallel package build (#280)
White-list clear_stats op from orchagent to syncd (#281)
Correct comment (#282)

sonic-sairedis:
[debian]: Change build order in target binary (#452)
[debian] increment debian compatibility to 10 to enable parallel package build (#461)
Full sleep wait flex counter polling thread when POLL_COUNTER_STATUS is disable (#462)
add support for SAI_ATTR_VALUE_TYPE_ACL_CAPABILITY (#460)
Check if port VID exists in db on flex counter query (#464)
Full sleep wait change for PFC watchdog (#465)
Add synchronous clear_stats operation path (#463)
Modify sai_create_port to breakout a port for virtual switch (#454)
Fix typo  (#467)

Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
Kalimuthu-Velappan pushed a commit to Kalimuthu-Velappan/sonic-buildimage that referenced this pull request Sep 12, 2019
@jleveque
[sonic_installer] Improve error handling (sonic-net#460)
d409987
seiferteric pushed a commit to project-arlo/sonic-buildimage that referenced this pull request Oct 14, 2019
@jangidrk
Update git submodules
0602e9b 
* Update src/sonic-sairedis from branch 'broadcom_sonic'
  to 9de2a0cd3371723c925341091c3ee9bc6df88527
  - Merge 201904 branch to broadcom_sonic branch on Mon Jul  1 13:57:56 PDT 2019
    
    Change-Id: Ibc8bd38f6819bda73ba52fff6358b794f7366d46
    
  - Fix typo  (sonic-net#467)
    
    * Rename to fix typo
    
    Signed-off-by: Wenda Ni <wenni@microsoft.com>
    
    * Correct shared_ptr creation parameters
    
    Signed-off-by: Wenda Ni <wenni@microsoft.com>
    
  - Modify sai_create_port to breakout a port for virtual switch (sonic-net#454)
    
    For breakout a port, it needs to support create port and remove port.
    When create a port, it needs to init some attributes.
    
    Signed-off-by: chiourung_huang <chiourung_huang@edge-core.com>
    
  - Add synchronous clear_stats operation path (sonic-net#463)
    
    * Send clear_stats op from orchagent to syncd via Redis pipeline
    
    Signed-off-by: Wenda Ni <wenni@microsoft.com>
    
    * Handle clear_stats op in syncd
    
    Signed-off-by: Wenda Ni <wenni@microsoft.com>
    
    * Receive clear_stats op status response from sycnd in orchagent context
    
    Signed-off-by: Wenda Ni <wenni@microsoft.com>
    
    * Shift clear_stats to get synchronous response from ASIC
    
    Signed-off-by: Wenda Ni <wenni@microsoft.com>
    
    * Fix compilation error
    
    Signed-off-by: Wenda Ni <wenni@microsoft.com>
    
    * Fix log message output
    
    Signed-off-by: Wenda Ni <wenni@microsoft.com>
    
    * Remove debugging symbols
    
    Signed-off-by: Wenda Ni <wenni@microsoft.com>
    
    * Remove debugging symbols
    
    Signed-off-by: Wenda Ni <wenni@microsoft.com>
    
    * Change the validation order of KeyOpFieldsValuesTuple responded from
    syncd
    
    Signed-off-by: Wenda Ni <wenni@microsoft.com>
    
    * Expand status log utility to include op type as argument
    
    Signed-off-by: Wenda Ni <wenni@microsoft.com>
    
    * Address comments: check if object id is present in local db
    
    Signed-off-by: Wenda Ni <wenni@microsoft.com>
    
    * Leverage newly merged infrastructure to check if object id is present in
    the local db
    
    Signed-off-by: Wenda Ni <wenni@microsoft.com>
    
    * Fix compile error
    
    Signed-off-by: Wenda Ni <wenni@microsoft.com>
    
  - Full sleep wait change for PFC watchdog (sonic-net#465)
    
    * Sleep wait change for pfc watchdog, which still has plugins in place so
    isEmpty() always returns true.
    
    When issuing 'pfcwd stop' cli to stop PFC watchdog, it only clears the counter id list for physical ports under the hood, leaving lua script plugins still installed and ieEmpty() returns false.
    
    So even when PFC watchdog is stopped, the flex counter thread would wake up every 200 ms.
    
    Jun 4 17:58:51.273413 str-a7050-acs-1 ERR syncd#syncd: :- flexCounterThread: End of flex counter thread FC PFC_WD, took 33 ms
    Jun 4 17:58:51.471288 str-a7050-acs-1 ERR syncd#syncd: :- flexCounterThread: End of flex counter thread FC PFC_WD, took 30 ms
    Jun 4 17:58:51.672930 str-a7050-acs-1 ERR syncd#syncd: :- flexCounterThread: End of flex counter thread FC PFC_WD, took 31 ms
    Jun 4 17:58:51.882972 str-a7050-acs-1 ERR syncd#syncd: :- flexCounterThread: End of flex counter thread FC PFC_WD, took 40 ms
    Jun 4 17:58:52.074862 str-a7050-acs-1 ERR syncd#syncd: :- flexCounterThread: End of flex counter thread FC PFC_WD, took 31 ms
    
    This PR is to address the above observation:
    
    Fine granularize the isEmpty() to two functions---isIdsEmpty() and isPluginsEmpty(), and use the emptiness check of the counter id list, isIdsEmpty(), as the criteria for full sleep wait. This approach is generally valid because current flex counter use cases would have the presence of non-empty counter id list to be meaningful, followed by an optional execution of the Lua script plugins if they are installed.
    
    Signed-off-by: Wenda Ni <wenni@microsoft.com>
    
  - Check if port VID exists in db on flex counter query (sonic-net#464)
    
    
  - add support for SAI_ATTR_VALUE_TYPE_ACL_CAPABILITY (sonic-net#460)
    
    Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
  - Full sleep wait flex counter polling thread when POLL_COUNTER_STATUS is disable (sonic-net#462)
    
    Signed-off-by: Wenda Ni <wenni@microsoft.com>
    
  - [debian] increment debian compatibility to 10 to enable parallel package build (sonic-net#461)
    
    * fix parallel build
    
    Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
    
    * [debian] increment debian compatibility to 10 to enable parallel package
    build
    
    From debhelper man pages:
    
    "If neither option is specified, debhelper currently defaults to
    --parallel in compat 10 (or later) and --no-parallel otherwise."
    
    Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
    
    * make tests run serial
    
    Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
    
  - [debian]: Change build order in target binary (sonic-net#452)
    
    Make binary-syncd the last target, so the non-rpc requisites will be available after the first build
    It will allow doing incremental builds later on for the main binary type
  - Add buffer pool stat to flex counter architecture (sonic-net#451)
    
    
  -  Watermark: test SAI clear api if the stats mode is READ_AND_CLEAR (sonic-net#427)
    
    * Test SAI clear api if the stats mode is READ_AND_CLEAR
    
    Signed-off-by: Wenda <wenni@microsoft.com>
    
    * Address compile error
madhanmellanox pushed a commit to madhanmellanox/sonic-buildimage that referenced this pull request Mar 23, 2020
@sihuihan88
[portsorch]: Add asymmetric PFC support (sonic-net#460)
7e27af9 
* [portsorch]: Add asymmetric PFC support

* Implement asymmetric PFC feature
* Implement unit test on top of virtual switch

Signed-off-by: Volodymyr Samotiy <volodymyrs@mellanox.com>

* [portsorch]: Add asymmetric PFC support

* Fix review comments

Signed-off-by: Volodymyr Samotiy <volodymyrs@mellanox.com>

* [portsorch]: Add asymmetric PFC support

* Fix review comments

Signed-off-by: Volodymyr Samotiy <volodymyrs@mellanox.com>
dmytroxshevchuk pushed a commit to dmytroxshevchuk/sonic-buildimage that referenced this pull request Aug 31, 2020
@stepanblyschak @lguohan
add support for SAI_ATTR_VALUE_TYPE_ACL_CAPABILITY (sonic-net#460)
37b9dff 
Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
mssonicbld added a commit that referenced this pull request Apr 9, 2024
@mssonicbld
[submodule] Update submodule sonic-platform-daemons to the latest HEA…
30d3eb6 
…D automatically (#18602)

#### Why I did it
src/sonic-platform-daemons
```
* 6d8ccbe - (HEAD -> 202311, origin/202311) [202311] Support to get MEDIA_SETTING and OPTICS_SI from both platform folder and HWSKU folder (#460) (20 minutes ago) [Kebo Liu]
```
#### How I did it
#### How to verify it
#### Description for the changelog
mssonicbld added a commit that referenced this pull request Apr 11, 2025
@mssonicbld
[submodule] Update submodule sonic-linux-kernel to the latest HEAD au…
2abc2b5 
…tomatically (#22142)

#### Why I did it
src/sonic-linux-kernel
```
* ccde25c - (HEAD -> 202405, origin/202405) [202405] Update to Linux 6.1.123 (#460) (9 days ago) [Saikrishna Arcot]
```
#### How I did it
#### How to verify it
#### Description for the changelog
mssonicbld added a commit that referenced this pull request Jul 25, 2025
@mssonicbld
[submodule] Update submodule sonic-gnmi to the latest HEAD automatica…
81ee560 
…lly (#23473)

#### Why I did it
src/sonic-gnmi
```
* 500addd - (HEAD -> master, origin/master, origin/HEAD) Add implementation and UT for SHOW clock and SHOW clock timezones (#456) (5 hours ago) [Zain Budhwani]
* 1c77a6c - Ensure test signal is created after watcher is added (#460) (8 hours ago) [Zain Budhwani]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lguohan lguohan lguohan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sihuihan88 @pavel-shirshov @lguohan