[interfaces]: Restart networking service after the file is updated#430
Merged
stcheng merged 1 commit intosonic-net:masterfrom Mar 23, 2017
stcheng:intfs
Merged
[interfaces]: Restart networking service after the file is updated#430stcheng merged 1 commit intosonic-net:masterfrom stcheng:intfs
stcheng merged 1 commit intosonic-net:masterfrom
stcheng:intfs
Conversation
Signed-off-by: Shuotian Cheng <shuche@microsoft.com>
jleveque
reviewed
Mar 23, 2017
| ifdown eth0 && ifup eth0 | ||
| ifdown lo && ifup lo | ||
|
|
||
| service networking restart |
Contributor
There was a problem hiding this comment.
Just curious if we prefer to use service networking restart or systemctl restart networking. Either way, we should choose one method and stick with it.
Contributor
Author
There was a problem hiding this comment.
i think they are here doing the same thing. is systemctl newer than service command? I could switch to systemctl.
Contributor
There was a problem hiding this comment.
Yes, they do the same thing. systemctl is part of systemd, whereas service has been around awhile and has been made to wrap a few different service managers.
taoyl-ms
approved these changes
Mar 23, 2017
Contributor
|
Cavium build failed due to no space left on devic. I think this is good to merge. |
Contributor
|
Just adding a note that this change was implemented in order to make sure Vlans are brought up on boot. |
lguohan
pushed a commit
that referenced
this pull request
Apr 12, 2019
…2755) sonic-sairedis: e8cb879 Make object list deterministic when iterating (#438) 5486f97 Ignore ACL_COUNTER bytes and packets during comparison logic (#443) b138ff9 Notify OA about exception and process only restart query events (#437) 0974a43 Set MTU value on created tap device for virtual switch (#436) e2f50e8 Increase eth buffer size to 16k for virtual switch (#435) 79fb388 [bfn] Ged rid of ld_preload. Link against libsai only (#429) 2e47b78 Remove MAC alignment WA for Mellanox platforms. (#430) e1354fe Add pre match to comparison logic and unittests (#423) 18a5ebb Drop FDB notifications if they contain invalid OIDs (#428) sonic-swss-common: 8af58ad sonic-swss-common: Add vxlan macros to schema (#269) 76837bf Make class Select support batch read from selectables (#270) 4cf643e Add multiple fields hdel support (#267) a710529 Update PFC_WD table name in CONFIG_DB (#266) 3c452c1 Update README.md (#268) sonic-swss: e329dbd Survive pfc watchdog storm action across warm-reboot (#794) sonic-utilities: 6ee0aea (HEAD, origin/master, origin/HEAD) [config]: Change the order of interface commands (#504) 5ae30d2 [show vlan brief] Support 'alias' interface naming mode (#497) bafebf9 Update neighbor advertiser (#498) fa90083 [clear/main.py]: clear ndp command. (#450) 65f69e4 [show interface neighbor expected] Support 'alias' interface naming mode (#495) aae39e7 updated show ipv6 interface for alias mode (#493) 170fed9 [warm-reboot] initialize warm reboot state table before warm rebooting (#492) 06cd99f Allow config shutdown and startup operations on valid PortChannel interface names (#474) 98cdebb [show ip interface] Add support for 'alias' interface naming mode (#486) 5f1de81 [show] Add serial numbers/uptime/hwinfo to 'show version' output (#488) e78a866 [route_check] Move scripts under scripts/ directory, add to setup.py (#489) d347527 Change PFC watchdog CONFIG_DB table name from PFC_WD_TABLE to PFC_WD (#475) Signed-off-by: Wenda Ni <wenni@microsoft.com>
dmytroxshevchuk
pushed a commit
to dmytroxshevchuk/sonic-buildimage
that referenced
this pull request
Aug 31, 2020
Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>
bobby-nexthop
pushed a commit
to bobby-nexthop/sonic-buildimage
that referenced
this pull request
Aug 1, 2025
* Enhance port_mapping to be multi-thread safe * Increase cov for handle_port_update_event test in test_xcvrd.py * Fix comment in test_xcvrd.py * Migrate to PortChangeObserver class to handle port update events * Rename port_mapping.py to port_event_helper.py * Remove unused import statement in port_event_helper.py * Resolve issue after update branch to latest master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shuotian Cheng shuche@microsoft.com