Skip to content

[MultiDB] : add persistence field for each redis instance#4254

Merged
lguohan merged 2 commits intosonic-net:masterfrom
dzhangalibaba:multi-db
Apr 8, 2020
Merged

[MultiDB] : add persistence field for each redis instance#4254
lguohan merged 2 commits intosonic-net:masterfrom
dzhangalibaba:multi-db

Conversation

@dzhangalibaba
Copy link
Copy Markdown
Collaborator

  • add "persistence" field for each redis instance in database_config.json
  • we will use this information to decide if saving redis instance data while warm/fast reboot
    • before multiDB changes, SONiC uses "redis-cli save " to save all the data into rdb file on default instance on port 6379
    • with multiDB changes, we plan to implement "sonic-db-cli save" to save all data to corresponding rdb files on all listed redis instances which has "persistence" field set "yes"

Signed-off-by: Dong Zhang d.zhang@alibaba-inc.com

@dzhangalibaba
Copy link
Copy Markdown
Collaborator Author

@qiluo-msft please check with @lguohan this design is OK to go or not

@qiluo-msft qiluo-msft requested a review from lguohan March 11, 2020 21:28
@qiluo-msft
Copy link
Copy Markdown
Collaborator

Looks good to me

@dzhangalibaba
Copy link
Copy Markdown
Collaborator Author

retest this please

@lguohan
Copy link
Copy Markdown
Collaborator

lguohan commented Mar 22, 2020

retest vs please

@lguohan
Copy link
Copy Markdown
Collaborator

lguohan commented Mar 22, 2020

retest vsimage please

@dzhangalibaba
Copy link
Copy Markdown
Collaborator Author

@qiluo could we merge this , then I can start next based on this design.

@qiluo-msft
Copy link
Copy Markdown
Collaborator

@lguohan do you have more concerns?

qiluo-msft
qiluo-msft previously approved these changes Apr 6, 2020
@dzhangalibaba
Copy link
Copy Markdown
Collaborator Author

retest vsimage please

1 similar comment
@dzhangalibaba
Copy link
Copy Markdown
Collaborator Author

retest vsimage please

@lguohan lguohan merged commit de5a04a into sonic-net:master Apr 8, 2020
@dzhangalibaba dzhangalibaba deleted the multi-db branch April 14, 2020 00:20
mssonicbld added a commit that referenced this pull request Mar 1, 2026
…lly (#25690)

#### Why I did it
src/sonic-swss
```
* 5d80c66 - (HEAD -> master, origin/master, origin/HEAD) Build swss for Trixie, and fix compilation errors that have popped up (#4254) (27 hours ago) [Saikrishna Arcot]
* baa5a73 - orchagent: Add support to program gearbox SI settings from APPL_DB (#4113) (2 days ago) [Brian Gallagher]
* 771ef1f - Merge pull request #4145 from divyagayathri-hcl/sws_2 (3 days ago) [StephenWangGoogle]
|\ 
| failure_prs.log skip_prs.log 979a7fd - Add tunnel->neighbor reference. (3 days ago) [mint570]
|/ 
* e367e3a - Merge pull request #4100 from divyagayathri-hcl/15_multicast (4 days ago) [StephenWangGoogle]
* c0b5c5b - [P4Orch] Implement function to update routes entries that assign multicast. (4 days ago) [mint570]
```
#### How I did it
#### How to verify it
#### Description for the changelog
tahvane1 pushed a commit to tahvane1/sonic-buildimage that referenced this pull request Mar 2, 2026
…lly (sonic-net#25690)

#### Why I did it
src/sonic-swss
```
* 5d80c66 - (HEAD -> master, origin/master, origin/HEAD) Build swss for Trixie, and fix compilation errors that have popped up (sonic-net#4254) (27 hours ago) [Saikrishna Arcot]
* baa5a73 - orchagent: Add support to program gearbox SI settings from APPL_DB (sonic-net#4113) (2 days ago) [Brian Gallagher]
* 771ef1f - Merge pull request sonic-net#4145 from divyagayathri-hcl/sws_2 (3 days ago) [StephenWangGoogle]
|\
| failure_prs.log skip_prs.log 979a7fd - Add tunnel->neighbor reference. (3 days ago) [mint570]
|/
* e367e3a - Merge pull request sonic-net#4100 from divyagayathri-hcl/15_multicast (4 days ago) [StephenWangGoogle]
* c0b5c5b - [P4Orch] Implement function to update routes entries that assign multicast. (4 days ago) [mint570]
```
#### How I did it
#### How to verify it
#### Description for the changelog

Signed-off-by: Erkka Tahvanainen <tahvanainen.erkka@gmail.com>
FengPan-Frank pushed a commit to FengPan-Frank/sonic-buildimage that referenced this pull request Mar 6, 2026
…lly (sonic-net#25690)

#### Why I did it
src/sonic-swss
```
* 5d80c66 - (HEAD -> master, origin/master, origin/HEAD) Build swss for Trixie, and fix compilation errors that have popped up (sonic-net#4254) (27 hours ago) [Saikrishna Arcot]
* baa5a73 - orchagent: Add support to program gearbox SI settings from APPL_DB (sonic-net#4113) (2 days ago) [Brian Gallagher]
* 771ef1f - Merge pull request sonic-net#4145 from divyagayathri-hcl/sws_2 (3 days ago) [StephenWangGoogle]
|\
| failure_prs.log skip_prs.log 979a7fd - Add tunnel->neighbor reference. (3 days ago) [mint570]
|/
* e367e3a - Merge pull request sonic-net#4100 from divyagayathri-hcl/15_multicast (4 days ago) [StephenWangGoogle]
* c0b5c5b - [P4Orch] Implement function to update routes entries that assign multicast. (4 days ago) [mint570]
```
#### How I did it
#### How to verify it
#### Description for the changelog

Signed-off-by: Feng Pan <fenpan@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants