Skip to content

[Seastone] Add new HWSKU for 48x50G+8x40G#4156

Merged
lguohan merged 1 commit intosonic-net:masterfrom
zhenggen-xu:seastone-new-hwsku
Apr 5, 2020
Merged

[Seastone] Add new HWSKU for 48x50G+8x40G#4156
lguohan merged 1 commit intosonic-net:masterfrom
zhenggen-xu:seastone-new-hwsku

Conversation

@zhenggen-xu
Copy link
Copy Markdown
Collaborator

@zhenggen-xu zhenggen-xu commented Feb 14, 2020

[Seastone] Add new HWSKU for 48x50G+8x40G

Signed-off-by: Zhenggen Xu zxu@linkedin.com

Need backport to 201911.

- What I did
[Seastone] Add new HWSKU for 48x50G+8x40G

- How I did it
Add the port_config.ini and sai.profile, leveraging the same bcm file.

- How to verify it

Build image and config to new HWSKU:

admin@sonic:~$ show platform summary 
Platform: x86_64-cel_seastone-r0
HwSKU: Seastone-DX010-50-50-40
ASIC: broadcom

admin@lnos-x1-a-asw03:~$ show interfaces status 
  Interface    Admin    Oper    Alias            Lanes    Speed    MTU    Vlan    Type    Asym PFC  
-----------  -------  ------  -------  ---------------  -------  -----  ------  ------  ----------  
  Ethernet0       up    down   Eth1/1            65,66      50G   9100  routed  QSFP28         N/A  
  Ethernet2       up    down   Eth1/2            67,68      50G   9100  routed  QSFP28         N/A  
  Ethernet4       up    down   Eth2/1            69,70      50G   9100  routed     N/A         N/A  
  Ethernet6       up    down   Eth2/2            71,72      50G   9100  routed     N/A         N/A  
  Ethernet8       up    down   Eth3/1            73,74      50G   9100  routed     N/A         N/A  
 Ethernet10       up    down   Eth3/2            75,76      50G   9100  routed     N/A         N/A  
 Ethernet12       up    down   Eth4/1            77,78      50G   9100  routed     N/A         N/A  
 Ethernet14       up    down   Eth4/2            79,80      50G   9100  routed     N/A         N/A  
 Ethernet16       up    down   Eth5/1            33,34      50G   9100  routed     N/A         N/A  
 Ethernet18       up    down   Eth5/2            35,36      50G   9100  routed     N/A         N/A  
 Ethernet20       up    down   Eth6/1            37,38      50G   9100  routed     N/A         N/A  
 Ethernet22       up    down   Eth6/2            39,40      50G   9100  routed     N/A         N/A  
 Ethernet24       up    down   Eth7/1            41,42      50G   9100  routed     N/A         N/A  
 Ethernet26       up    down   Eth7/2            43,44      50G   9100  routed     N/A         N/A  
 Ethernet28       up    down   Eth8/1            45,46      50G   9100  routed     N/A         N/A  
 Ethernet30       up    down   Eth8/2            47,48      50G   9100  routed     N/A         N/A  
 Ethernet32       up    down   Eth9/1            49,50      50G   9100  routed     N/A         N/A  
 Ethernet34       up    down   Eth9/2            51,52      50G   9100  routed     N/A         N/A  
 Ethernet36       up    down  Eth10/1            53,54      50G   9100  routed     N/A         N/A  
 Ethernet38       up    down  Eth10/2            55,56      50G   9100  routed     N/A         N/A  
 Ethernet40       up    down  Eth11/1            57,58      50G   9100  routed     N/A         N/A  
 Ethernet42       up    down  Eth11/2            59,60      50G   9100  routed     N/A         N/A  
 Ethernet44       up    down  Eth12/1            61,62      50G   9100  routed     N/A         N/A  
 Ethernet46       up    down  Eth12/2            63,64      50G   9100  routed     N/A         N/A  
 Ethernet48       up    down  Eth13/1            81,82      50G   9100  routed     N/A         N/A  
 Ethernet50       up    down  Eth13/2            83,84      50G   9100  routed     N/A         N/A  
 Ethernet52       up    down  Eth14/1            85,86      50G   9100  routed     N/A         N/A  
 Ethernet54       up    down  Eth14/2            87,88      50G   9100  routed     N/A         N/A  
 Ethernet56       up    down  Eth15/1            89,90      50G   9100  routed     N/A         N/A  
 Ethernet58       up    down  Eth15/2            91,92      50G   9100  routed     N/A         N/A  
 Ethernet60       up    down  Eth16/1            93,94      50G   9100  routed     N/A         N/A  
 Ethernet62       up    down  Eth16/2            95,96      50G   9100  routed     N/A         N/A  
 Ethernet64       up    down  Eth17/1            97,98      50G   9100  routed     N/A         N/A  
 Ethernet66       up    down  Eth17/2           99,100      50G   9100  routed     N/A         N/A  
 Ethernet68       up    down  Eth18/1          101,102      50G   9100  routed     N/A         N/A  
 Ethernet70       up    down  Eth18/2          103,104      50G   9100  routed     N/A         N/A  
 Ethernet72       up    down  Eth19/1          105,106      50G   9100  routed     N/A         N/A  
 Ethernet74       up    down  Eth19/2          107,108      50G   9100  routed     N/A         N/A  
 Ethernet76       up    down  Eth20/1          109,110      50G   9100  routed     N/A         N/A  
 Ethernet78       up    down  Eth20/2          111,112      50G   9100  routed     N/A         N/A  
 Ethernet80       up    down  Eth21/1              1,2      50G   9100  routed     N/A         N/A  
 Ethernet82       up    down  Eth21/2              3,4      50G   9100  routed     N/A         N/A  
 Ethernet84       up    down  Eth22/1              5,6      50G   9100  routed     N/A         N/A  
 Ethernet86       up    down  Eth22/2              7,8      50G   9100  routed     N/A         N/A  
 Ethernet88       up    down  Eth23/1             9,10      50G   9100  routed     N/A         N/A  
 Ethernet90       up    down  Eth23/2            11,12      50G   9100  routed     N/A         N/A  
 Ethernet92       up    down  Eth24/1            13,14      50G   9100  routed     N/A         N/A  
 Ethernet94       up    down  Eth24/2            15,16      50G   9100  routed     N/A         N/A  
 Ethernet96       up    down    Eth25      17,18,19,20      40G   9100  routed     N/A         N/A  
Ethernet100       up    down    Eth26      21,22,23,24      40G   9100  routed     N/A         N/A  
Ethernet104       up    down    Eth27      25,26,27,28      40G   9100  routed     N/A         N/A  
Ethernet108       up    down    Eth28      29,30,31,32      40G   9100  routed     N/A         N/A  
Ethernet112       up    down    Eth29  113,114,115,116      40G   9100  routed  QSFP28         N/A  
Ethernet116       up    down    Eth30  117,118,119,120      40G   9100  routed   QSFP+         N/A  
Ethernet120       up    down    Eth31  121,122,123,124      40G   9100  routed   QSFP+         N/A  
Ethernet124       up    down    Eth32  125,126,127,128      40G   9100  routed   QSFP+         N/A

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

prsunny
prsunny previously approved these changes Feb 15, 2020
View reviewed changes
@zhenggen-xu
[Seastone] Add new HWSKU for 48x50G+8x40G
7d1a649 
Signed-off-by: Zhenggen Xu <zxu@linkedin.com>
@prsunny
Copy link
Copy Markdown
Contributor

prsunny commented Feb 19, 2020

@zhenggen-xu, what is 50-50-40 means? It doesn't look to convey the meaning.. Can you follow the name like D48Q8 (Refer https://github.com/Azure/sonic-buildimage/tree/master/device/arista/x86_64-arista_7060_cx32s/Arista-7060CX-32S-D48C8)

Also you've https://github.com/Azure/sonic-buildimage/tree/master/device/celestica/x86_64-cel_seastone-r0/Seastone-DX010-50-40 and the only change on this is the number of 50G ports

@lguohan
Copy link
Copy Markdown
Collaborator

lguohan commented Feb 27, 2020

retest vsimage please

@zhenggen-xu
Copy link
Copy Markdown
Collaborator Author

zhenggen-xu commented Mar 9, 2020

@zhenggen-xu, what is 50-50-40 means? It doesn't look to convey the meaning.. Can you follow the name like D48Q8 (Refer https://github.com/Azure/sonic-buildimage/tree/master/device/arista/x86_64-arista_7060_cx32s/Arista-7060CX-32S-D48C8)

Also you've https://github.com/Azure/sonic-buildimage/tree/master/device/celestica/x86_64-cel_seastone-r0/Seastone-DX010-50-40 and the only change on this is the number of 50G ports

The HWSKU names are used internally and already deployed so won't be able to change. I was not aware of any naming convention of the HWSKU. To understand the meaning, people who deployment it just look at the port_config.ini. For future HWSKUs I would follow the convention if any. To be honest, I personally don't know what 32S-D48C8 means either. :-)

@lguohan lguohan merged commit b9f6353 into sonic-net:master Apr 5, 2020
abdosi pushed a commit that referenced this pull request Apr 7, 2020
@zhenggen-xu @abdosi
[Seastone] Add new HWSKU for 48x50G+8x40G (#4156)
0a4f164 
Add the port_config.ini and sai.profile, leveraging the same bcm file.

Signed-off-by: Zhenggen Xu <zxu@linkedin.com>
tiantianlv pushed a commit to SONIC-DEV/sonic-buildimage that referenced this pull request Apr 24, 2020
@zhenggen-xu @tiantianlv
[Seastone] Add new HWSKU for 48x50G+8x40G (sonic-net#4156)
3cc6058 
Add the port_config.ini and sai.profile, leveraging the same bcm file.

Signed-off-by: Zhenggen Xu <zxu@linkedin.com>
@zhenggen-xu zhenggen-xu deleted the seastone-new-hwsku branch May 24, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@prsunny prsunny prsunny left review comments

+1 more reviewer

@jleveque jleveque jleveque approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Enhancement ➕ Included in 201911 Branch Platform: Celestica Request for 201911 Branch :shipit:

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zhenggen-xu @prsunny @lguohan @jleveque @abdosi