[fancontrol] Restart process upon unexpected exit, not entire pmon container#4101
Merged
sujinmkang merged 3 commits intosonic-net:masterfrom Mar 20, 2020
sujinmkang:fancontrol
Merged
[fancontrol] Restart process upon unexpected exit, not entire pmon container#4101sujinmkang merged 3 commits intosonic-net:masterfrom sujinmkang:fancontrol
sujinmkang merged 3 commits intosonic-net:masterfrom
sujinmkang:fancontrol
Conversation
Collaborator
|
can you please have descriptions? what you did, why did this? |
Collaborator
Author
|
retest this please |
jleveque
reviewed
Feb 18, 2020
dockers/docker-platform-monitor/docker-pmon.supervisord.conf.j2
Outdated
Show resolved
Hide resolved
Contributor
|
Retest vsimage please |
Collaborator
Author
|
retest vsimage please |
jleveque
approved these changes
Mar 19, 2020
Contributor
jleveque
left a comment
There was a problem hiding this comment.
I'm OK with this change. If fancontrol crashes, we should just try restarting the process. Restarting the entire container shouldn't give us any better chances of getting it in a working state. If there's an underlying issue, it would be due to a device driver malfunction, which restarting the container will not solve.
lguohan
pushed a commit
that referenced
this pull request
Apr 27, 2020
…ntainer (#4101) * fancontrol restart * Cleanup the default setting for exitcodes * Remove the unnecessary stopwaitsecs default settin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Remove fancontrol from critical process list for pmon
Add restart logic of fancontrol for unexpected exit cases
- How I did it
Configure the supervisord.conf for pmon to restart the fancontrol
- How to verify it
Login to pmon
Run 'kill -9 ; rm /var/run/fancontrol.pid'
Check if fancontrol restarted
- Description for the changelog
Add restart configuration of fancontrol for pmon.
- A picture of a cute animal (not mandatory but encouraged)