[cfggen] Add tool to translate openconfig acl into sonic format by taoyl-ms · Pull Request #388 · sonic-net/sonic-buildimage

taoyl-ms · 2017-03-08T02:17:35Z

No description provided.

stcheng · 2017-03-09T08:44:48Z

src/sonic-config-engine/translate_acl

i'm just curious what they do for the reject action. any difference from the drop? #Closed

By openconfig definition, REJECT is to "Drop the packet and send an ICMP error message to the source". We don't support ICMP error message right now, of course. #Closed

aha thanks. #Closed

lguohan · 2017-03-13T15:34:32Z

src/sonic-config-engine/translate_acl

+        if flag == "TCP_SYN":
+            tcp_flags = tcp_flags | 0x02
+        if flag == "TCP_FIN":
+            tcp_flags = tcp_flags | 0x01


probably swap the order of SYN and FIN? #Resolved

lguohan · 2017-03-13T15:35:20Z

src/sonic-config-engine/translate_acl

+    table_props = {}
+    table_props["policy_desc"] = table_name
+    table_props["type"] = "L3"
+    table_props["ports"] = "Ethernet0"


why is this Ethernet0? #Resolved

lguohan · 2017-03-13T15:36:38Z

src/sonic-config-engine/translate_acl

+
+
+def main():
+    translate(sys.argv[1])


rename to translate_acl for better clarity? #Resolved

lguohan · 2017-03-13T15:42:18Z

dockers/docker-config-engine/Dockerfile.j2

 debs/
+{%- endif -%}

+{% if docker_config_engine_debs != '' %}


-> {% if docker_config_engine_debs.strip() -%} #Resolved

lguohan · 2017-03-13T15:42:49Z

dockers/docker-config-engine/Dockerfile.j2

 {%- endfor %}
+{%- endif -%}
+
+{% if docker_config_engine_whls != '' %}


see above #Resolved

lguohan · 2017-03-13T15:48:24Z

files/build_templates/sonic_debian_extension.j2

-# TODO: pip-install instead of apt-get after config engine wrapped into a wheel, even better use pip implicitly installing dependencies
+# Install dependencies for SONiC config engine 
 sudo LANG=C DEBIAN_FRONTEND=noninteractive chroot $FILESYSTEM_ROOT apt-get -y install \
+    python-dev     \


also need to remove python-dev later? #Resolved

It's in base image. Do we also care a lot about size here? I prefer we keep it for easier usage of pip.

In reply to: 105694773 [](ancestors = 105694773)

we care about size since some switch only have 2G disk, what's the size we are talking about? #Resolved

lguohan · 2017-03-13T15:50:02Z

src/sonic-config-engine/translate_acl

+    rule_data["ACL_RULE_TABLE:"+table_name+":Rule_"+str(rule_idx)] = rule_props
+    rule_data["OP"] = "SET"
+
+    rule_props["priority"] = 10000 - rule_idx


make 10000 as a parameter with default value, it should not be hardcoded in the code. #Resolved

lguohan · 2017-03-13T15:50:53Z

src/sonic-config-engine/translate_acl

+    elif rule.ip.config.protocol == "IP_AUTH":
+        rule_props["IP_PROTOCOL"] = "51" 
+    elif rule.ip.config.protocol == "IP_L2TP":
+        rule_props["IP_PROTOCOL"] = "115" 


better to create a map for such translation? #Resolved

lguohan · 2017-03-13T15:54:33Z

src/sonic-config-engine/translate_acl

+        print "Unknown rule action %s in table %s, rule %d!" % (rule.actions.config.forwarding_action, table_name, rule_idx)
+        return {}
+
+    if rule.ip.config.protocol == "":


compare with "" does not look like a good practice. check below

http://stackoverflow.com/questions/9573244/most-elegant-way-to-check-if-the-string-is-empty-in-python #Resolved

lguohan · 2017-03-13T16:01:53Z

src/sonic-config-engine/translate_acl

+    table_data = [{}]
+    table_data[0]["ACL_TABLE:"+table_name] = table_props
+    table_data[0]["OP"] = "SET"
+    dump_json("table_"+table_name+".json", table_data)


which directory do we put them into? can you add an option to specify the output directory? #Resolved

lguohan · 2017-03-13T16:04:16Z

what's the license for openconfig_acl.py? can we import the whole github instead of this one file? How do we plan to maintain this file? #Resolved

lguohan

see the comments

taoyl-ms · 2017-03-14T02:40:46Z

This file is not in openconfig github. It is an auto-generated file by pyangbind taking openconfig and ietf-config github as input. We can also rerun the generation process during every build, but I doubt if we really have the need to do that as it will quite complicate the build process.

In reply to: 286154088 [](ancestors = 286154088)

lguohan · 2017-03-14T17:15:36Z

ok, can you put comments in the file, to describe how this file is generated? #Resolved

… yang model

…#416) The path moved from /usr/bin/ to /usr/local/bin due to the installation change from deb to whl

* cd97c60 2018-12-03 | Add support for recreate host interfaces tap devices on warm start (sonic-net#392) [Kamil Cudnik] * b4a7160 2018-12-03 | Drain asic queue before processing shutdown request (sonic-net#388) [Kamil Cudnik] Signed-off-by: Guohan Lu <gulv@microsoft.com>

- [warm boot] introduce command line options to warm/fast reboot scripts (sonic-net#399) - Use -d instead of -m in config qos (sonic-net#388) Signed-off-by: Ying Xie <ying.xie@microsoft.com>

- [warm boot] introduce command line options to warm/fast reboot scripts (#399) - Use -d instead of -m in config qos (#388) Signed-off-by: Ying Xie <ying.xie@microsoft.com>

…onic-net#358)" (sonic-net#371)" (sonic-net#388) This reverts commit 8fc09d0.

Update the sonic-swss-common submodule. The following are the commits in the submodule. ``` 95f9e11 2020-11-19 | [pyext] allow to catch exceptions raised in python (sonic-net#415) [Stepan Blyshchak] 5a718f9 2020-11-18 | [swig] translate C++ `del` to python `delete` (sonic-net#416) [Qi Luo] 40b255b 2020-11-12 | Fix: SWIG dict.get() should have optional default value parameter (sonic-net#413) [Qi Luo] 91e484d 2020-11-07 | Reduce notice logging (sonic-net#412) [Qi Luo] f5945ae 2020-11-05 | Mux Cable schema definitions for interaction between linkmanager and xcvrd (sonic-net#411) [vdahiya12] 602f9c2 2020-11-05 | [lua] load lua script on demand (sonic-net#409) [Dong Zhang] d88412b 2020-11-04 | Rename hdel to del when using multiple keys as param (sonic-net#410) [Kamil Cudnik] e0c229a 2020-11-04 | CHASSIS_STATE_DB on control-card for chassis state (sonic-net#395) [mprabhu-nokia] a4e3ac8 2020-11-04 | Chassisd config table to store admin state (sonic-net#388) [mprabhu-nokia] ```

Update the sonic-swss-common submodule. The following are the commits in the submodule. ``` 95f9e11 2020-11-19 | [pyext] allow to catch exceptions raised in python (#415) [Stepan Blyshchak] 5a718f9 2020-11-18 | [swig] translate C++ `del` to python `delete` (#416) [Qi Luo] 40b255b 2020-11-12 | Fix: SWIG dict.get() should have optional default value parameter (#413) [Qi Luo] 91e484d 2020-11-07 | Reduce notice logging (#412) [Qi Luo] f5945ae 2020-11-05 | Mux Cable schema definitions for interaction between linkmanager and xcvrd (#411) [vdahiya12] 602f9c2 2020-11-05 | [lua] load lua script on demand (#409) [Dong Zhang] d88412b 2020-11-04 | Rename hdel to del when using multiple keys as param (#410) [Kamil Cudnik] e0c229a 2020-11-04 | CHASSIS_STATE_DB on control-card for chassis state (#395) [mprabhu-nokia] a4e3ac8 2020-11-04 | Chassisd config table to store admin state (#388) [mprabhu-nokia] ```

Update the sonic-swss-common submodule. The following are the commits in the submodule. ``` 95f9e11 2020-11-19 | [pyext] allow to catch exceptions raised in python (sonic-net#415) [Stepan Blyshchak] 5a718f9 2020-11-18 | [swig] translate C++ `del` to python `delete` (sonic-net#416) [Qi Luo] 40b255b 2020-11-12 | Fix: SWIG dict.get() should have optional default value parameter (sonic-net#413) [Qi Luo] 91e484d 2020-11-07 | Reduce notice logging (sonic-net#412) [Qi Luo] f5945ae 2020-11-05 | Mux Cable schema definitions for interaction between linkmanager and xcvrd (sonic-net#411) [vdahiya12] 602f9c2 2020-11-05 | [lua] load lua script on demand (sonic-net#409) [Dong Zhang] d88412b 2020-11-04 | Rename hdel to del when using multiple keys as param (sonic-net#410) [Kamil Cudnik] e0c229a 2020-11-04 | CHASSIS_STATE_DB on control-card for chassis state (sonic-net#395) [mprabhu-nokia] a4e3ac8 2020-11-04 | Chassisd config table to store admin state (sonic-net#388) [mprabhu-nokia] ```

… automatically (#16676) #### Why I did it src/sonic-platform-common ``` * c63abc0 - (HEAD -> master, origin/master, origin/HEAD) [Credo][Ycable] Remove the thread locker protection from the thread-safe APIs (#388) (21 hours ago) [Xinyu Lin] ``` #### How I did it #### How to verify it #### Description for the changelog

… automatically (#17084) #### Why I did it src/sonic-platform-common ``` * e7325db - (HEAD -> 202305, origin/202305) Fix SSD health percentage issue for vendor Virtium (#407) (#408) (11 hours ago) [Stephen Sun] * 87e33ab - [Credo][Ycable] Remove the thread locker protection from the thread-safe APIs (#388) (11 hours ago) [Xinyu Lin] ``` #### How I did it #### How to verify it #### Description for the changelog

… automatically (#17451) src/sonic-platform-common * 39ade8d - (HEAD -> 202205, origin/202205) [Credo][Ycable] Remove the thread locker protection from the thread-safe APIs (#388) (4 days ago) [Xinyu Lin]

…afe APIs (sonic-net#388) Signed-off-by: Xinyu <xinyu0123@gmail.com> Co-authored-by: Prince George <45705344+prgeor@users.noreply.github.com>

taoyl-ms added 2 commits March 8, 2017 01:54

Build sonic-config-engine as whl instead of deb package

bcd361e

[cfggen] Add tool to translate openconfig acl into sonic format

e4d0024

stcheng reviewed Mar 9, 2017

View reviewed changes

taoyl-ms force-pushed the taoyl/pyangbind branch 2 times, most recently from 07cd100 to 38d19ce Compare March 10, 2017 19:30

Install buildessential for bitarray setup.py dependency

b7486c2

taoyl-ms force-pushed the taoyl/pyangbind branch from 38d19ce to b7486c2 Compare March 11, 2017 01:00

lguohan reviewed Mar 13, 2017

View reviewed changes

lguohan requested changes Mar 13, 2017

View reviewed changes

Resolve CR comments

0ed95cf

taoyl-ms force-pushed the taoyl/pyangbind branch from 8e18b73 to 4a3c0e1 Compare March 16, 2017 21:16

Resolve CR comments

fa2ff78

taoyl-ms force-pushed the taoyl/pyangbind branch from 4a3c0e1 to fa2ff78 Compare March 17, 2017 04:45

Add into comments the detail steps to generate openconfig_acl.py from…

982c065

… yang model

lguohan approved these changes Mar 17, 2017

View reviewed changes

Merge branch 'master' into taoyl/pyangbind

8685acf

taoyl-ms merged commit 3643281 into sonic-net:master Mar 17, 2017

stcheng added the Enhancement ➕ label Mar 17, 2017

stcheng pushed a commit that referenced this pull request Mar 20, 2017

[cfggen]: Fix the path to sonic-cfggen due to the path change in #388 (…

7a16e02

…#416) The path moved from /usr/bin/ to /usr/local/bin due to the installation change from deb to whl

lguohan mentioned this pull request Dec 3, 2018

[submodules]: update sonic-sairedis #2332

Closed

yxieca mentioned this pull request Dec 5, 2018

[sonic-utilities] move sonic-utilities submodule point #2350

Merged

Kalimuthu-Velappan pushed a commit to Kalimuthu-Velappan/sonic-buildimage that referenced this pull request Sep 12, 2019

Use -d instead of -m in config qos (sonic-net#388)

e438c66

madhanmellanox pushed a commit to madhanmellanox/sonic-buildimage that referenced this pull request Mar 23, 2020

Revert "Revert "Update port and queue stat counters by Flex counter (s…

2a7d2a7

…onic-net#358)" (sonic-net#371)" (sonic-net#388) This reverts commit 8fc09d0.

dmytroxshevchuk pushed a commit to dmytroxshevchuk/sonic-buildimage that referenced this pull request Aug 31, 2020

Drain asic queue before processing shutdown request (sonic-net#388)

b4a7160

Conversation

taoyl-ms commented Mar 8, 2017

Uh oh!

stcheng Mar 9, 2017 • edited by taoyl-ms Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

taoyl-ms Mar 9, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stcheng Mar 9, 2017 • edited by taoyl-ms Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lguohan Mar 13, 2017 • edited by taoyl-ms Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lguohan Mar 13, 2017 • edited by taoyl-ms Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lguohan Mar 13, 2017 • edited by taoyl-ms Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lguohan Mar 13, 2017 • edited by taoyl-ms Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lguohan Mar 13, 2017 • edited by taoyl-ms Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lguohan Mar 13, 2017 • edited by taoyl-ms Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

taoyl-ms Mar 14, 2017

Choose a reason for hiding this comment

Uh oh!

lguohan Mar 14, 2017 • edited by taoyl-ms Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lguohan Mar 13, 2017 • edited by taoyl-ms Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lguohan Mar 13, 2017 • edited by taoyl-ms Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lguohan Mar 13, 2017 • edited by taoyl-ms Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lguohan Mar 13, 2017 • edited by taoyl-ms Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lguohan commented Mar 13, 2017 • edited by taoyl-ms Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lguohan left a comment

Choose a reason for hiding this comment

Uh oh!

taoyl-ms commented Mar 14, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lguohan commented Mar 14, 2017 • edited by taoyl-ms Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

stcheng Mar 9, 2017 •

edited by taoyl-ms

Loading

taoyl-ms Mar 9, 2017 •

edited

Loading

stcheng Mar 9, 2017 •

edited by taoyl-ms

Loading

lguohan Mar 13, 2017 •

edited by taoyl-ms

Loading

lguohan Mar 13, 2017 •

edited by taoyl-ms

Loading

lguohan Mar 13, 2017 •

edited by taoyl-ms

Loading

lguohan Mar 13, 2017 •

edited by taoyl-ms

Loading

lguohan Mar 13, 2017 •

edited by taoyl-ms

Loading

lguohan Mar 13, 2017 •

edited by taoyl-ms

Loading

lguohan Mar 14, 2017 •

edited by taoyl-ms

Loading

lguohan Mar 13, 2017 •

edited by taoyl-ms

Loading

lguohan Mar 13, 2017 •

edited by taoyl-ms

Loading

lguohan Mar 13, 2017 •

edited by taoyl-ms

Loading

lguohan Mar 13, 2017 •

edited by taoyl-ms

Loading

lguohan commented Mar 13, 2017 •

edited by taoyl-ms

Loading

taoyl-ms commented Mar 14, 2017 •

edited

Loading

lguohan commented Mar 14, 2017 •

edited by taoyl-ms

Loading