Skip to content

Add watchdog-control service to disable watchdog during bootup#3877

Merged
sujinmkang merged 6 commits into201811from
sujkang-wd-f-fwboot
Dec 13, 2019
Merged

Add watchdog-control service to disable watchdog during bootup#3877
sujinmkang merged 6 commits into201811from
sujkang-wd-f-fwboot

Conversation

@sujinmkang
Copy link
Copy Markdown
Collaborator

Disable only if it's applicable and the watchdog is enabled.

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@sujinmkang sujinmkang requested a review from jleveque December 12, 2019 00:21
@@ -0,0 +1,10 @@
[Unit]
Description=watchdog control service
After=rc-local.service
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is probably make more sense to put this service 'After swss.service'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could go either way. Just depends on how early we feel comfortable disabling it, and whether or not we need to disable it early to prevent unnecessary watchdogs during normal reboot.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only use this service to recover fast/warm reboot so far. After swss is fine in that sense. We could also use this to protect against not able to initiate critical services. I agree that after swss could be an issue for cold reboot on wimpy platforms.

@yxieca
Copy link
Copy Markdown
Contributor

yxieca commented Dec 12, 2019

Please wait for the sonic-utility PR merged and add submodule head change to this PR so they go in together.

@jleveque
Copy link
Copy Markdown
Contributor

@sujinmkang: It appears something went wrong with your submodule update, as GitHub is indicating there are conflicts.

@yxieca yxieca force-pushed the sujkang-wd-f-fwboot branch from b4298cf to e95c102 Compare December 13, 2019 20:40
@sujinmkang sujinmkang merged commit aea1816 into 201811 Dec 13, 2019
@sujinmkang sujinmkang deleted the sujkang-wd-f-fwboot branch December 13, 2019 20:44
rabbit-nexthop pushed a commit to nexthop-ai/sonic-buildimage that referenced this pull request Mar 25, 2026
caleb-nexthop added a commit to nexthop-ai/sonic-buildimage that referenced this pull request Mar 25, 2026
caleb-nexthop added a commit to nexthop-ai/sonic-buildimage that referenced this pull request Mar 25, 2026
caleb-nexthop added a commit to nexthop-ai/sonic-buildimage that referenced this pull request Mar 26, 2026
caleb-nexthop added a commit to nexthop-ai/sonic-buildimage that referenced this pull request Mar 26, 2026
Signed-off-by: Caleb Dueck <caleb@nexthop.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants