Skip to content

Revert "[swss.sh] When starting, call 'systemctl restart' on dependents, not 'systemctl start'"#3835

Merged
yxieca merged 1 commit intomasterfrom
revert-3807-swss_restart_dependents
Dec 2, 2019
Merged

Revert "[swss.sh] When starting, call 'systemctl restart' on dependents, not 'systemctl start'"#3835
yxieca merged 1 commit intomasterfrom
revert-3807-swss_restart_dependents

Conversation

@yxieca
Copy link
Copy Markdown
Contributor

@yxieca yxieca commented Dec 2, 2019

Reverts #3807

This change introduced a race condition at boot up time to allow teamd to restart. And the consequence is that lags are not configured with IP addresses.

@jleveque
Copy link
Copy Markdown
Contributor

jleveque commented Dec 2, 2019

I'm OK with this change as long as we can guarantee radvd and dhcp_relay get restarted (stopped and started) in the event that SwSS ever restarts.

@yxieca yxieca merged commit fc36ca6 into master Dec 2, 2019
@yxieca yxieca deleted the revert-3807-swss_restart_dependents branch December 2, 2019 23:54
yxieca added a commit that referenced this pull request Dec 2, 2019
abdosi pushed a commit that referenced this pull request Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants