[libteam]: Fixing the port add issue#3725
Draft
pavel-shirshov wants to merge 1 commit intosonic-net:masterfrom
Draft
[libteam]: Fixing the port add issue#3725pavel-shirshov wants to merge 1 commit intosonic-net:masterfrom
pavel-shirshov wants to merge 1 commit intosonic-net:masterfrom
Conversation
This was referenced Nov 7, 2019
Collaborator
|
do we need this for 201811 branch? |
Contributor
Author
|
Yes @lguohan if it fixes the issue. |
Collaborator
|
@pavel-shirshov @lguohan Still observe the issue after 2 iterations of warm reboot with this PR, on 201811 can't reproduce. |
Contributor
Author
|
@stepanblyschak Can you please share logs? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Fixed a bug #3725 . Which caused following log output. The bug was observed, because team_refresh() expect to see the port enabled, but the port is being enabled later by team_set_port_enabled().
- How I did it
I run team_set_port_enabled() function before the team_refresh() function
- How to verify it
Build libteam and run on the switch
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)