[services] make snmp.timer work again and delay telemetry.service#3657
Merged
yxieca merged 1 commit intosonic-net:masterfrom Nov 6, 2019
Merged
[services] make snmp.timer work again and delay telemetry.service#3657yxieca merged 1 commit intosonic-net:masterfrom
yxieca merged 1 commit intosonic-net:masterfrom
Conversation
Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
pavel-shirshov
approved these changes
Oct 24, 2019
Collaborator
Author
|
Retest vs please |
Contributor
|
retest vs please |
yxieca
approved these changes
Oct 26, 2019
Contributor
|
retest vs please |
1 similar comment
Collaborator
|
retest vs please |
Contributor
|
This change broke some link between swss and snmp. I think if swss restarts, the snmp won't get restart with this change. This link can be restored by adding snmp as a dependency service in swss service script, where we already have a few. |
yxieca
requested changes
Nov 1, 2019
Contributor
yxieca
left a comment
There was a problem hiding this comment.
As commented above. There is a service link between swss and snmp got broken by this change.
Contributor
|
What do you mean by "a service link"? |
Collaborator
Author
|
Isn't |
yxieca
approved these changes
Nov 5, 2019
Contributor
|
Thanks @stepanblyschak , can you also test stop and start? systemctrld behaves differently between (stop/start) and (restart). |
Collaborator
Author
|
@yxieca Looks like working correctly as it was before 'WantedBy': stop swss: start swss: |
Contributor
|
Thanks @stepanblyschak ! |
Contributor
|
@stepanblyschak Please create an PR for this change against 201811 branch. There are merge conflicts. I suspect due to telemetry not in 201811. |
Collaborator
Author
|
@yxieca I just found that you were right, start of swss does not start snmp, even though I ensured that I test this behavior on changed image. This PR requires more work and I'll try what you suggested. You can revert for now. |
zhenggen-xu
pushed a commit
to zhenggen-xu/sonic-buildimage
that referenced
this pull request
Jan 10, 2020
…nic-net#3657) Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
zhenggen-xu
pushed a commit
to zhenggen-xu/sonic-buildimage
that referenced
this pull request
Jan 10, 2020
…vice (sonic-net#3657)" (sonic-net#3729) This reverts commit d346cb3.
mssonicbld
added a commit
that referenced
this pull request
Jun 7, 2025
…lly (#22884) #### Why I did it src/sonic-swss ``` * db7d939 - (HEAD -> master, origin/master, origin/HEAD) Remove cache for high volume DASH objects (#3534) (4 hours ago) [Lawrence Lee] * 80294d5 - add parseBoolList in request parser (#3675) (9 hours ago) [Jing Zhang] * a7607be - [fpmsyncd]Fixing fpmsyncd to handle routes without protocol (#3657) (11 hours ago) [Sudharsan Dhamal Gopalarathnam] * 8067dee - [muxorch] Catch error when checking active state of missing neighbor (#3674) (11 hours ago) [Nikola Dancejic] * d073fc7 - [vstest]: Skip flaky icmp echo tests (#3687) (12 hours ago) [prabhataravind] ``` #### How I did it #### How to verify it #### Description for the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stepan Blyschak stepanb@mellanox.com
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)