[minigraph.py] Update minigraph parsing logic to include only active ports for mirror tables#3592
Merged
daall merged 2 commits intosonic-net:masterfrom Oct 17, 2019
Merged
Conversation
…ports for mirror tables - Update minigraph.py to filter out front-panel ports that are not active - Update cfggen tests to reflect new behavior Signed-off-by: Danny Allen <daall@microsoft.com>
prsunny
reviewed
Oct 16, 2019
lguohan
reviewed
Oct 16, 2019
- Update t0 tests to include additional device neighbors - Refactor xml parsing logic
prsunny
approved these changes
Oct 17, 2019
daall
added a commit
to daall/sonic-buildimage
that referenced
this pull request
Oct 18, 2019
…ports for mirror tables (sonic-net#3592) * Update minigraph.py to filter out front-panel ports that are not active * Update cfggen tests to reflect new behavior Signed-off-by: Danny Allen <daall@microsoft.com> * Incorporate PR comments - Update t0 tests to include additional device neighbors - Refactor xml parsing logic
Contributor
|
Dropped 'request for configlet' as could not be cherry-picked onto 201811. |
renukamanavalan
pushed a commit
that referenced
this pull request
Oct 24, 2019
…ports for mirror tables (#3592) (#3634) * Update minigraph.py to filter out front-panel ports that are not active * Update cfggen tests to reflect new behavior Signed-off-by: Danny Allen <daall@microsoft.com> * Incorporate PR comments - Update t0 tests to include additional device neighbors - Refactor xml parsing logic
yxieca
pushed a commit
that referenced
this pull request
Nov 7, 2019
…ports for mirror tables (#3592) (#3634) * Update minigraph.py to filter out front-panel ports that are not active * Update cfggen tests to reflect new behavior Signed-off-by: Danny Allen <daall@microsoft.com> * Incorporate PR comments - Update t0 tests to include additional device neighbors - Refactor xml parsing logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[minigraph.py] Update minigraph parsing logic to include only active ports for mirror tables
Signed-off-by: Danny Allen daall@microsoft.com
- What I did
Described above.
- How I did it
Described above.
- How to verify it
See tests.
- Description for the changelog
Update minigraph parsing logic to include only active ports for mirror tables
- A picture of a cute animal (not mandatory but encouraged)
