[teamd] fix lacp fallback mode breakage in teamd v1.28#3572
Merged
lguohan merged 1 commit intosonic-net:masterfrom Oct 11, 2019
Merged
[teamd] fix lacp fallback mode breakage in teamd v1.28#3572lguohan merged 1 commit intosonic-net:masterfrom
lguohan merged 1 commit intosonic-net:masterfrom
Conversation
In teamd v1.28, the port can only be enabled if sync bit is set in recveived LACPDU from partner by the following commit "teamd: lacp: update port state according to partner's sync bit" (jpirko/libteam@54f137c) However, lacp fallback feature needs to enable port even if partner LACPDU is not received within a given period and fallback cfg is enabled. To fix the lacp fallback breakage, we have to bypass the sync bit check in lacp fallback mode. Signed-off-by: Haiyang Zheng <haiyang.z@alibaba-inc.com>
cb9c45a to
96260f7
Compare
Collaborator
|
retest vsimage please |
pavel-shirshov
approved these changes
Oct 11, 2019
| 2017 21:07:53 -0800 | ||
| commit f475746f56602a40861b8d94eac5f0979c4703f3 | ||
| Author: yorke <yorke.yuan@asterfusion.com> | ||
| Date: Mon Jun 3 12:02:36 2019 +0800 |
Contributor
Author
There was a problem hiding this comment.
Thanks for the review. Looks like it's already merged.
Collaborator
|
@pavel-shirshov , can you also check the test mention in the pr and approve or not? |
mssonicbld
added a commit
that referenced
this pull request
Dec 10, 2024
…atically (#20573) #### Why I did it src/sonic-utilities ``` * 32e6de7 - (HEAD -> master, origin/master, origin/HEAD) Update DB migrator script to next branch 202505 (#3664) (3 days ago) [Kumaresh Perumal] * 8d00aba - (origin/test_202411_20, origin/test_202411_100, origin/kperumal_202411, origin/202411) Fix save_file command in generate_dump (#3647) (4 days ago) [DavidZagury] * 038aaa5 - Revert "Speed up route_check script" (#3653) (4 days ago) [xwjiang-ms] * 032a0e0 - [config]Restrict YANG validation to Golden Config (#3656) (4 days ago) [jingwenxie] * 47b79be - Update gcu_field_operation_validators.conf.json with Arista-7260CX3-D108C10 (#3650) (4 days ago) [Dev Ojha] * 845f46e - Update PR checker pipeline to point to bookworm (#3651) (4 days ago) [bingwang-ms] * 28e645f - [show_tech] Filter out a list of commands in generate_dump script which are not applicable to Supervisor (#3646) (5 days ago) [Marty Y. Lok] * b767cb8 - [cisco|express-boot]: Add support for cisco express boot in sonic-utilities (#3056) (6 days ago) [jhli-cisco] * f6b9912 - Fix show command column change issue (#3645) (8 days ago) [Feng-msft] * 9cd6c8d - Debug dump utility dash objects update (#3387) (8 days ago) [Gagan Punathil Ellath] * f705c45 - Validate interface name length in CLI (#3580) (8 days ago) [Stepan Blyshchak] * 3d78cb1 - [Mellanox] Update the save_file command in generate_dump to handle folders (#3631) (13 days ago) [DavidZagury] * 5086a43 - Fix counterpoll show for ENI Counters (#3618) (13 days ago) [Vivek] * 70f8139 - Extra delay between running firmware and updating firmware version (#3610) (2 weeks ago) [Stephen Sun] * 636f7f1 - Add port FEC BER show changes (#3607) (2 weeks ago) [vincentpcng] * 5e60031 - Supports FRR-VRRP configuration (#2949) (3 weeks ago) [Philo] * 9bd37dc - [ARM64][Warm-Reboot]: Get boot arguments from uboot environment (#3613) (3 weeks ago) [Parthiv Shah] * 171b16c - platform/innovium renaming to platform/marvell-teralynx (#3474) (3 weeks ago) [krismarvell] * 2cbfcc9 - [Mellanox] Add Mellanox-SN5600-C224O8 to gcu_field.json (#3612) (4 weeks ago) [noaOrMlnx] * a8f7bde - PVST Feature commit (#3567) (4 weeks ago) [Divya Kumaran Chandralekha] * 0e18807 - Refresh dump file modify timestamp before cleanup call (#3595) (4 weeks ago) [anamehra] * 8f3c5ef - [warm-reboot] Add support to pass extra kernel cmdline parameters (#3192) (4 weeks ago) [Pavan Naregundi] * 9677447 - Run yang validation in db migrator (#3102) (4 weeks ago) [ganglv] * 9708f52 - [Mellanox] Update C256X1 SKU to be C256S1 in gcu_field.json (#3611) (4 weeks ago) [noaOrMlnx] * 093ed4a - [SPM] Add logic to disable the feature before stopping it and enabling it before starting (#3344) (4 weeks ago) [Vadym Hlushko] * 7d013df - Fix slash in path. (#3573) (5 weeks ago) [Xincun Li] * 0af4386 - Consolidate the get running config way. (#3585) (5 weeks ago) [Xincun Li] * 964b489 - Fix for integer overflow of counter value if its too large (#3596) (5 weeks ago) [harjotsinghpawra] * 3354d08 - [config] Bypass standard input for reload (#3597) (5 weeks ago) [jingwenxie] * 7cbcfda - Speed up route_check script (#3544) (5 weeks ago) [Deepak Singhal] * 329fc22 - Add support of the pensando-dpu platform to generate-dump utility. (#3557) (6 weeks ago) [BHUKYA SIDDHU] * 0ae2ec1 - Add CLI for bmp configdb entity Enable/Disable (#3286) (6 weeks ago) [Feng-msft] * 5b37ee6 - Vnet_route_check TCP socket for DB connection. (#3578) (6 weeks ago) [siqbal1986] * d64a90a - Adds logic to get default disk and check disk type (#3399) (6 weeks ago) [Ashwin Srinivasan] * b2b9734 - [Banner] Added CLI commands to configure Banner and display current configuration (#3021) (6 weeks ago) [Sviatoslav Boichuk] * d0aa94a - Revert "Record and warn tables which not covered by YANG (#3583)" (#3588) (7 weeks ago) [jingwenxie] * aeda86a - Record and warn tables which not covered by YANG (#3583) (7 weeks ago) [jingwenxie] * dd34d7c - Revert "Skip default lanes dup check (#3489)" (#3572) (7 weeks ago) [Xincun Li] * 6c8007f - [Mellanox]Remove deprecated sdk sniffer cli and collect sdk dump in show techsupport (#3491) (7 weeks ago) [Yuanzhe] * 89bb87a - Add YANG validation for config reload if file is given (#3576) (7 weeks ago) [jingwenxie] ``` #### How I did it #### How to verify it #### Description for the changelog
VladimirKuk
pushed a commit
to Marvell-switching/sonic-buildimage
that referenced
this pull request
Jan 21, 2025
…atically (sonic-net#20573) #### Why I did it src/sonic-utilities ``` * 32e6de7 - (HEAD -> master, origin/master, origin/HEAD) Update DB migrator script to next branch 202505 (sonic-net#3664) (3 days ago) [Kumaresh Perumal] * 8d00aba - (origin/test_202411_20, origin/test_202411_100, origin/kperumal_202411, origin/202411) Fix save_file command in generate_dump (sonic-net#3647) (4 days ago) [DavidZagury] * 038aaa5 - Revert "Speed up route_check script" (sonic-net#3653) (4 days ago) [xwjiang-ms] * 032a0e0 - [config]Restrict YANG validation to Golden Config (sonic-net#3656) (4 days ago) [jingwenxie] * 47b79be - Update gcu_field_operation_validators.conf.json with Arista-7260CX3-D108C10 (sonic-net#3650) (4 days ago) [Dev Ojha] * 845f46e - Update PR checker pipeline to point to bookworm (sonic-net#3651) (4 days ago) [bingwang-ms] * 28e645f - [show_tech] Filter out a list of commands in generate_dump script which are not applicable to Supervisor (sonic-net#3646) (5 days ago) [Marty Y. Lok] * b767cb8 - [cisco|express-boot]: Add support for cisco express boot in sonic-utilities (sonic-net#3056) (6 days ago) [jhli-cisco] * f6b9912 - Fix show command column change issue (sonic-net#3645) (8 days ago) [Feng-msft] * 9cd6c8d - Debug dump utility dash objects update (sonic-net#3387) (8 days ago) [Gagan Punathil Ellath] * f705c45 - Validate interface name length in CLI (sonic-net#3580) (8 days ago) [Stepan Blyshchak] * 3d78cb1 - [Mellanox] Update the save_file command in generate_dump to handle folders (sonic-net#3631) (13 days ago) [DavidZagury] * 5086a43 - Fix counterpoll show for ENI Counters (sonic-net#3618) (13 days ago) [Vivek] * 70f8139 - Extra delay between running firmware and updating firmware version (sonic-net#3610) (2 weeks ago) [Stephen Sun] * 636f7f1 - Add port FEC BER show changes (sonic-net#3607) (2 weeks ago) [vincentpcng] * 5e60031 - Supports FRR-VRRP configuration (sonic-net#2949) (3 weeks ago) [Philo] * 9bd37dc - [ARM64][Warm-Reboot]: Get boot arguments from uboot environment (sonic-net#3613) (3 weeks ago) [Parthiv Shah] * 171b16c - platform/innovium renaming to platform/marvell-teralynx (sonic-net#3474) (3 weeks ago) [krismarvell] * 2cbfcc9 - [Mellanox] Add Mellanox-SN5600-C224O8 to gcu_field.json (sonic-net#3612) (4 weeks ago) [noaOrMlnx] * a8f7bde - PVST Feature commit (sonic-net#3567) (4 weeks ago) [Divya Kumaran Chandralekha] * 0e18807 - Refresh dump file modify timestamp before cleanup call (sonic-net#3595) (4 weeks ago) [anamehra] * 8f3c5ef - [warm-reboot] Add support to pass extra kernel cmdline parameters (sonic-net#3192) (4 weeks ago) [Pavan Naregundi] * 9677447 - Run yang validation in db migrator (sonic-net#3102) (4 weeks ago) [ganglv] * 9708f52 - [Mellanox] Update C256X1 SKU to be C256S1 in gcu_field.json (sonic-net#3611) (4 weeks ago) [noaOrMlnx] * 093ed4a - [SPM] Add logic to disable the feature before stopping it and enabling it before starting (sonic-net#3344) (4 weeks ago) [Vadym Hlushko] * 7d013df - Fix slash in path. (sonic-net#3573) (5 weeks ago) [Xincun Li] * 0af4386 - Consolidate the get running config way. (sonic-net#3585) (5 weeks ago) [Xincun Li] * 964b489 - Fix for integer overflow of counter value if its too large (sonic-net#3596) (5 weeks ago) [harjotsinghpawra] * 3354d08 - [config] Bypass standard input for reload (sonic-net#3597) (5 weeks ago) [jingwenxie] * 7cbcfda - Speed up route_check script (sonic-net#3544) (5 weeks ago) [Deepak Singhal] * 329fc22 - Add support of the pensando-dpu platform to generate-dump utility. (sonic-net#3557) (6 weeks ago) [BHUKYA SIDDHU] * 0ae2ec1 - Add CLI for bmp configdb entity Enable/Disable (sonic-net#3286) (6 weeks ago) [Feng-msft] * 5b37ee6 - Vnet_route_check TCP socket for DB connection. (sonic-net#3578) (6 weeks ago) [siqbal1986] * d64a90a - Adds logic to get default disk and check disk type (sonic-net#3399) (6 weeks ago) [Ashwin Srinivasan] * b2b9734 - [Banner] Added CLI commands to configure Banner and display current configuration (sonic-net#3021) (6 weeks ago) [Sviatoslav Boichuk] * d0aa94a - Revert "Record and warn tables which not covered by YANG (sonic-net#3583)" (sonic-net#3588) (7 weeks ago) [jingwenxie] * aeda86a - Record and warn tables which not covered by YANG (sonic-net#3583) (7 weeks ago) [jingwenxie] * dd34d7c - Revert "Skip default lanes dup check (sonic-net#3489)" (sonic-net#3572) (7 weeks ago) [Xincun Li] * 6c8007f - [Mellanox]Remove deprecated sdk sniffer cli and collect sdk dump in show techsupport (sonic-net#3491) (7 weeks ago) [Yuanzhe] * 89bb87a - Add YANG validation for config reload if file is given (sonic-net#3576) (7 weeks ago) [jingwenxie] ``` #### How I did it #### How to verify it #### Description for the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #951
In teamd v1.28, the port can only be enabled if sync bit is set
in recveived LACPDU from partner by the following commit
"teamd: lacp: update port state according to partner's sync bit"
(jpirko/libteam@54f137c)
However, lacp fallback feature needs to enable port even if partner
LACPDU is not received within a given period and fallback cfg is enabled.
To fix the lacp fallback breakage, we have to bypass the sync bit
check in lacp fallback mode.
Signed-off-by: Haiyang Zheng haiyang.z@alibaba-inc.com
- What I did
Fix lacp fallback mode breakage in teamd v 1.28
- How I did it
bypass the sync bit check in lacp fallback mode, which is introduced in teamd v1.28 and later
- How to verify it
verify that the port can enter and exit lacp fallback mode with the change as expected.
And the change passed the following test case
https://github.com/Azure/sonic-mgmt/pull/379/files
- Description for the changelog
[teamd] fix lacp fallback mode breakage in teamd v1.28
- A picture of a cute animal (not mandatory but encouraged)