use docker without sudo#3336
Conversation
jleveque
left a comment
There was a problem hiding this comment.
This instruction seems out-of-place between git checkout and make init. Also, it doesn't explain the purpose for needing to use docker without sudo. It seems like it belongs in a separate section for optional helpful steps.
if one install docker with sudo, and run into 'make init' section, it throws out error which requires to install the docker package. The related script is at line 55 of Makefile.work file. It is at "docker_ver := $(shell docker info)" |
|
This is a command you should only need to run once when you set up your environment. I don't think it belongs in the "Usage" section. I think it would be better in a section below "Prerequisites" (or part of that section), maybe like the following: |
Ok. I put it as part of the "Prerequisites" section. |
|
please fix your merge conflict |
|
Very helpful, avoiding compilation errors |
Users can install docker with sudo, and it requires sudo to issue docker command. This will cause few errors in Makefile.work which need use docker without sudo.
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)