[sonic-cfggen] Add Mellanox platform specific code to read base mac from machine.conf#2991
Merged
liat-grozovik merged 5 commits intosonic-net:masterfrom Jun 25, 2019
keboliu:read-mac-from-machine-conf
Merged
[sonic-cfggen] Add Mellanox platform specific code to read base mac from machine.conf#2991liat-grozovik merged 5 commits intosonic-net:masterfrom keboliu:read-mac-from-machine-conf
liat-grozovik merged 5 commits intosonic-net:masterfrom
keboliu:read-mac-from-machine-conf
Conversation
liat-grozovik
approved these changes
Jun 11, 2019
qiluo-msft
reviewed
Jun 11, 2019
qiluo-msft
reviewed
Jun 12, 2019
qiluo-msft
reviewed
Jun 12, 2019
qiluo-msft
reviewed
Jun 12, 2019
qiluo-msft
approved these changes
Jun 12, 2019
Collaborator
Author
|
retest this please |
andriymoroz-mlnx
approved these changes
Jun 14, 2019
Collaborator
Author
|
retest vs please |
mssonicbld
added a commit
that referenced
this pull request
Oct 20, 2023
…atically (#16953) #### Why I did it src/sonic-utilities ``` * 244ad2d - (HEAD -> master, origin/master, origin/HEAD) Revert "Remove syslog service validator in GCU (#2991)" (#3015) (2 hours ago) [jingwenxie] * d857eb0 - [db_migrator] Fix the broken version chain (#3014) (11 hours ago) [Vivek] * 424be9c - [fwutil] Fix python SyntaxWarning for 'is' with literals (#3013) (23 hours ago) [Kebo Liu] ``` #### How I did it #### How to verify it #### Description for the changelog
mssonicbld
added a commit
that referenced
this pull request
Oct 26, 2023
…atically (#17018) #### Why I did it src/sonic-utilities ``` * 569beb19 - (HEAD -> 202305, origin/202305) Revert "Remove syslog service validator in GCU (#2991)" (#3015) (16 hours ago) [jingwenxie] * ab7f03ea - [db_migrator] Fix the broken version chain (#3014) (16 hours ago) [Vivek] * 0f17b8d5 - [fwutil] Fix python SyntaxWarning for 'is' with literals (#3013) (16 hours ago) [Kebo Liu] ``` #### How I did it #### How to verify it #### Description for the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
With Mellanox ONIE release(2019.05-5.2.0012) and above, "onie_base_mac" was added to "/host/machine.conf":
onie_base_mac=e4:1d:2d:44:5e:80So now on Mellanox platform, we have another way to get the mac address besides decode syseeprom, by this can mitigate the dependency on the hw-management service if switch installed latest ONIE.
- How I did it
Add code to get_system_mac() for Mellanox platform to check whether base mac is availaible in "machine.conf", if not, fall back on the old way.
- How to verify it
run "sonic-cfggen -H --print-data" with the new code
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)